Skip to content

Commit 7afdbb0

Browse files
committed
Fix e2e comment/error-message accuracy (dispatch-only region note, secret names in guard)
1 parent 515ec25 commit 7afdbb0

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/e2e-tests-full.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
if: matrix.cdk-source == 'main'
6565
run: |
6666
set -euo pipefail
67-
[ -n "${CDK_REPO_TOKEN:-}" ] && [ -n "${CDK_REPO:-}" ] || { echo "::error::CDK_REPO and CDK_REPO_TOKEN must be set"; exit 1; }
67+
[ -n "${CDK_REPO_TOKEN:-}" ] && [ -n "${CDK_REPO:-}" ] || { echo "::error::Required secrets CDK_REPO_NAME and CDK_REPO_TOKEN are not configured"; exit 1; }
6868
git clone --depth 1 --branch main "https://x-access-token:${CDK_REPO_TOKEN}@github.com/${CDK_REPO}.git" /tmp/cdk-repo
6969
cd /tmp/cdk-repo
7070
npm ci

.github/workflows/e2e-tests.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ jobs:
2525
environment: e2e-testing
2626
timeout-minutes: 30
2727
env:
28-
# Single source for the AWS region default. On `workflow_dispatch` the
29-
# input applies; on other events `inputs` is empty so the fallback applies.
28+
# Single source for the AWS region default. This workflow is
29+
# dispatch-only, so the input always applies; the fallback guards the
30+
# case where the optional `aws_region` input is left blank on dispatch.
3031
AWS_REGION: ${{ inputs.aws_region || 'us-east-1' }}
3132
strategy:
3233
fail-fast: false
@@ -80,7 +81,7 @@ jobs:
8081
if: matrix.cdk-source == 'main'
8182
run: |
8283
set -euo pipefail
83-
[ -n "${CDK_REPO_TOKEN:-}" ] && [ -n "${CDK_REPO:-}" ] || { echo "::error::CDK_REPO and CDK_REPO_TOKEN must be set"; exit 1; }
84+
[ -n "${CDK_REPO_TOKEN:-}" ] && [ -n "${CDK_REPO:-}" ] || { echo "::error::Required secrets CDK_REPO_NAME and CDK_REPO_TOKEN are not configured"; exit 1; }
8485
git clone --depth 1 --branch main "https://x-access-token:${CDK_REPO_TOKEN}@github.com/${CDK_REPO}.git" /tmp/cdk-repo
8586
cd /tmp/cdk-repo
8687
npm ci

0 commit comments

Comments
 (0)