Skip to content

test(frontend): isolate diagram-list readiness before enabling fake timers #1012

Description

@seonghobae

Test reliability gap

The polluted sanitizeHandleId branches #1007 and #989 contain an unrelated change in frontend/src/App.coverage.test.tsx: four tests click the first diagram 열기 button immediately after opening the diagram panel, then enable fake timers. The candidate patch waits for at least one 열기 button before switching timers.

This finding is not part of handle-ID production performance and must not be carried by #1011.

Required validation

  1. Reproduce the predecessor failure or race with repeated focused runs under the repository-required Node 26 runtime.
  2. Prove the asynchronous boundary is the diagram-list render, not an unrelated mocked request or stale state leak.
  3. Keep waitFor under real timers and enable fake timers only after the list is visible.
  4. Preserve every existing polling, undo, terminal-refresh, and error assertion.
  5. Run at least 20 focused repetitions plus the complete frontend test, typecheck, coverage, and production build.
  6. No production, dependency, lockfile, performance, or Jules-journal change.
  7. Record the root cause and exact-head evidence in docs/doctoring/ and the product technical gap baseline only if the race reproduces.

Source disposition

#1007 and #989 mix this candidate test-only stabilization with the duplicate handle-ID optimization. Close those mixed branches after this issue preserves the unique finding.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions