You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #926 surfaced a valid but separate question beyond identifier log-safety: structured and free-form text inputs (dsn, forward DDL SQL, DBML source, annotation body) need explicit character contracts. A blanket identifier regex is not suitable because these fields have different grammars and legitimate formatting requirements.
Required decisions
DSN
Parse with the supported PostgreSQL/Snowflake DSN grammar rather than treating it as an arbitrary display string.
Determine whether CR/LF, NUL, C0/C1, U+2028, and U+2029 are rejected by parser contract, transport contract, or explicit validation.
Preserve secret redaction and avoid logging the raw DSN.
Forward DDL SQL
Preserve required horizontal tab/newline/carriage-return formatting if the accepted grammar allows it.
Reject NUL and characters that cannot occur in the bounded DDL grammar.
Keep full DDL semantic validation in the existing authoritative validation boundary; do not add a second validator in a request model unless the architecture proves that boundary is canonical and non-circular.
DBML source
Preserve legal multiline formatting.
Reject characters that the DBML parser cannot represent deterministically.
Verify error messages and logs never echo hostile raw input.
PR #926 mixes the above candidate scope with identifier changes already superseded by #887, a DDL semantic-validator relocation, a linter cleanup, workflow changes, and dependency drift. Preserve the finding through this issue, not by merging the mixed branch.
Buyer/security gap
PR #926 surfaced a valid but separate question beyond identifier log-safety: structured and free-form text inputs (
dsn, forward DDL SQL, DBML source, annotation body) need explicit character contracts. A blanket identifier regex is not suitable because these fields have different grammars and legitimate formatting requirements.Required decisions
DSN
Forward DDL SQL
DBML source
Annotation body
Implementation constraints
CHANGELOG.md,docs/doctoring/, anddocs/product-technical-gap-baseline.mdwith the decision and residual risks.Source disposition
PR #926 mixes the above candidate scope with identifier changes already superseded by #887, a DDL semantic-validator relocation, a linter cleanup, workflow changes, and dependency drift. Preserve the finding through this issue, not by merging the mixed branch.