map, String key, String value) {
if (value != null && !value.isBlank()) {
map.put(key, value);
diff --git a/etl-service/src/main/java/com/xtrmetl/etl/connector/QlikSenseTargetConnector.java b/etl-service/src/main/java/com/xtrmetl/etl/connector/QlikSenseTargetConnector.java
index e89866c6..8684fa58 100644
--- a/etl-service/src/main/java/com/xtrmetl/etl/connector/QlikSenseTargetConnector.java
+++ b/etl-service/src/main/java/com/xtrmetl/etl/connector/QlikSenseTargetConnector.java
@@ -4,10 +4,16 @@
import java.util.Map;
/**
- * Qlik Sense / Qlik Cloud target surface (reload-trigger first).
+ * Reference-only design type for a possible future Qlik Sense / Qlik Cloud integration.
*
- * Ships config contract + validation + catalog hooks. No Qlik REST client wired;
- * {@link #write} always refuses (SCAFFOLD).
+ * This type is not registered in the production target registry and has no Spring-bound
+ * production configuration. It is retained only to preserve an explicit design reference while
+ * mightyETL has no supported Qlik row-write, reload, or data-file execution path. As a scaffold,
+ * {@link #write} always refuses execution.
+ *
+ * A production Qlik integration requires a separately reviewed reload/data-file contract,
+ * maintained client implementation, credential boundary, lifecycle semantics, operator guidance,
+ * and realistic integration evidence before this type may become production-discoverable.
*
* @see docs/connectors/qlik-sense.md
*/
diff --git a/etl-service/src/main/java/com/xtrmetl/etl/connector/TargetConnectorRegistry.java b/etl-service/src/main/java/com/xtrmetl/etl/connector/TargetConnectorRegistry.java
index 4e5390af..636dbdf7 100644
--- a/etl-service/src/main/java/com/xtrmetl/etl/connector/TargetConnectorRegistry.java
+++ b/etl-service/src/main/java/com/xtrmetl/etl/connector/TargetConnectorRegistry.java
@@ -19,7 +19,6 @@ public class TargetConnectorRegistry {
public TargetConnectorRegistry() {
register(new DatabricksTargetConnector());
register(new SnowflakeTargetConnector());
- register(new QlikSenseTargetConnector());
}
public final void register(TargetConnector connector) {
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessorTest.java b/etl-service/src/test/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessorTest.java
index 76ea2b40..47cc2a91 100644
--- a/etl-service/src/test/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessorTest.java
+++ b/etl-service/src/test/java/com/xtrmetl/etl/config/MightyEtlConfigAliasEnvironmentPostProcessorTest.java
@@ -46,12 +46,7 @@ class MightyEtlConfigAliasEnvironmentPostProcessorTest {
Map.entry("connectors.snowflake.private-key", "test-private-key"),
Map.entry("connectors.snowflake.role", "ETL_ROLE"),
Map.entry("connectors.snowflake.table", "EVENTS"),
- Map.entry("connectors.snowflake.merge-keys", "id"),
- Map.entry("connectors.qlik-sense.enabled", "true"),
- Map.entry("connectors.qlik-sense.tenant-url", "https://tenant.example"),
- Map.entry("connectors.qlik-sense.api-key", "test-qlik-api-key"),
- Map.entry("connectors.qlik-sense.app-id", "test-app-id"),
- Map.entry("connectors.qlik-sense.mode", "reload-only")
+ Map.entry("connectors.snowflake.merge-keys", "id")
);
@Test
@@ -59,7 +54,6 @@ void aliasAllowListMatchesCompleteConnectorBindingSurface() {
Set expected = new TreeSet<>();
expected.addAll(writableConnectorKeys("databricks", ConnectorProperties.DatabricksProps.class));
expected.addAll(writableConnectorKeys("snowflake", ConnectorProperties.SnowflakeProps.class));
- expected.addAll(writableConnectorKeys("qlik-sense", ConnectorProperties.QlikSenseProps.class));
Set actual = new TreeSet<>();
MightyEtlConfigAliasEnvironmentPostProcessor.RELATIVE_KEYS.stream()
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/config/QlikConnectorConfigurationRetirementTest.java b/etl-service/src/test/java/com/xtrmetl/etl/config/QlikConnectorConfigurationRetirementTest.java
new file mode 100644
index 00000000..7e9417bf
--- /dev/null
+++ b/etl-service/src/test/java/com/xtrmetl/etl/config/QlikConnectorConfigurationRetirementTest.java
@@ -0,0 +1,38 @@
+package com.xtrmetl.etl.config;
+
+import com.xtrmetl.etl.connector.ConnectorProperties;
+import org.junit.jupiter.api.Test;
+
+import java.util.Arrays;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Guards removal of Qlik row-write configuration from the production connector surface while the
+ * real Qlik integration remains intentionally unimplemented.
+ */
+class QlikConnectorConfigurationRetirementTest {
+
+ @Test
+ void productionAliasRegistryDoesNotAdvertiseQlikRowWriteEnablement() {
+ assertFalse(
+ MightyEtlConfigAliasEnvironmentPostProcessor.RELATIVE_KEYS
+ .contains("connectors.qlik-sense.enabled")
+ );
+ }
+
+ @Test
+ void productionConnectorPropertiesDoNotBindQlikRowWriteCredentials() {
+ assertThrows(NoSuchMethodException.class, () -> ConnectorProperties.class.getMethod("getQlikSense"));
+ assertFalse(
+ Arrays.stream(ConnectorProperties.class.getDeclaredClasses())
+ .anyMatch(type -> type.getSimpleName().equals("QlikSenseProps"))
+ );
+
+ ConnectorProperties properties = new ConnectorProperties();
+ assertFalse(properties.isEnabled("qlik-sense"));
+ assertTrue(properties.configMap("qlik-sense").isEmpty());
+ }
+}
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/connector/QlikReferenceDocumentationTest.java b/etl-service/src/test/java/com/xtrmetl/etl/connector/QlikReferenceDocumentationTest.java
new file mode 100644
index 00000000..d79201dd
--- /dev/null
+++ b/etl-service/src/test/java/com/xtrmetl/etl/connector/QlikReferenceDocumentationTest.java
@@ -0,0 +1,32 @@
+package com.xtrmetl.etl.connector;
+
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Keeps the retained Qlik reference type aligned with its retired production lifecycle status.
+ */
+class QlikReferenceDocumentationTest {
+
+ @Test
+ void retainedReferenceTypeDoesNotClaimShippedProductionHooks() throws IOException {
+ String source = Files.readString(
+ Path.of(
+ "src/main/java/com/xtrmetl/etl/connector/",
+ "QlikSenseTargetConnector.java"
+ ),
+ StandardCharsets.UTF_8
+ );
+
+ assertTrue(source.contains("Reference-only design type"));
+ assertTrue(source.contains("not registered in the production target registry"));
+ assertFalse(source.contains("Ships config contract + validation + catalog hooks"));
+ }
+}
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorDispatcherTest.java b/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorDispatcherTest.java
index 3a9dafc1..b3a0d906 100644
--- a/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorDispatcherTest.java
+++ b/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorDispatcherTest.java
@@ -58,11 +58,12 @@ void failsValidationWhenScaffoldEnabledButConfigIncomplete() {
}
@Test
- void catalogShowsAllConnectorsDisabledByDefault() {
+ void catalogShowsAdvertisedConnectorsDisabledByDefault() {
TargetConnectorDispatcher dispatcher =
new TargetConnectorDispatcher(new TargetConnectorRegistry(), new ConnectorProperties());
- assertEquals(3, dispatcher.catalog().size());
+ assertEquals(2, dispatcher.catalog().size());
+ assertTrue(dispatcher.catalog().stream().noneMatch(row -> "qlik-sense".equals(row.get("id"))));
assertTrue(dispatcher.catalog().stream().noneMatch(row -> Boolean.TRUE.equals(row.get("writable"))));
assertTrue(dispatcher.catalog().stream().noneMatch(row -> Boolean.TRUE.equals(row.get("opened"))));
}
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorRegistryTest.java b/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorRegistryTest.java
index 2c11bb1e..73681f6b 100644
--- a/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorRegistryTest.java
+++ b/etl-service/src/test/java/com/xtrmetl/etl/connector/TargetConnectorRegistryTest.java
@@ -13,13 +13,13 @@
class TargetConnectorRegistryTest {
@Test
- void registersScaffoldConnectorsForWarehouseAndBiTargets() {
+ void registersOnlyAdvertisedWarehouseScaffolds() {
TargetConnectorRegistry registry = new TargetConnectorRegistry();
- assertEquals(3, registry.all().size());
+ assertEquals(2, registry.all().size());
assertTrue(registry.find("databricks").isPresent());
assertTrue(registry.find("snowflake").isPresent());
- assertTrue(registry.find("qlik-sense").isPresent());
+ assertFalse(registry.find("qlik-sense").isPresent());
for (TargetConnector connector : registry.all()) {
assertEquals(ConnectorStatus.SCAFFOLD, connector.status());
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/connector/WarehouseBiConnectorSurfaceTest.java b/etl-service/src/test/java/com/xtrmetl/etl/connector/WarehouseBiConnectorSurfaceTest.java
index cd9c7349..acca0a94 100644
--- a/etl-service/src/test/java/com/xtrmetl/etl/connector/WarehouseBiConnectorSurfaceTest.java
+++ b/etl-service/src/test/java/com/xtrmetl/etl/connector/WarehouseBiConnectorSurfaceTest.java
@@ -15,15 +15,14 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
- * Unit tests on shipped warehouse/BI connector classes (not live SaaS).
+ * Unit tests on warehouse target connectors intentionally exposed by the production registry.
*/
class WarehouseBiConnectorSurfaceTest {
static Stream scaffolds() {
return Stream.of(
new DatabricksTargetConnector(),
- new SnowflakeTargetConnector(),
- new QlikSenseTargetConnector()
+ new SnowflakeTargetConnector()
);
}
@@ -83,11 +82,11 @@ void snowflakeRequiresAccountPathKeys() {
}
@Test
- void qlikRequiresTenantAuthApp() {
- QlikSenseTargetConnector c = new QlikSenseTargetConnector();
- assertEquals("qlik-sense", c.id());
- assertTrue(c.requiredConfigKeys().containsAll(
- List.of("tenant-url", "api-key", "app-id")));
+ void qlikIsNotPublishedAsARowWriteTargetUntilItsRealProductBoundaryExists() {
+ TargetConnectorRegistry registry = new TargetConnectorRegistry();
+
+ assertTrue(registry.find("qlik-sense").isEmpty());
+ assertTrue(registry.all().stream().noneMatch(connector -> connector.id().equals("qlik-sense")));
}
@Test
@@ -133,12 +132,13 @@ void dispatcherValidatesBoundConfigBeforeScaffoldRefusal() {
}
@Test
- void catalogExposesRequiredKeysAndIntegrationHooks() {
+ void catalogExposesOnlyIntentionalWarehouseScaffolds() {
TargetConnectorDispatcher dispatcher =
new TargetConnectorDispatcher(new TargetConnectorRegistry(), new ConnectorProperties());
List> catalog = dispatcher.catalog();
- assertEquals(3, catalog.size());
+ assertEquals(2, catalog.size());
+ assertTrue(catalog.stream().noneMatch(row -> "qlik-sense".equals(row.get("id"))));
for (Map row : catalog) {
assertEquals("SCAFFOLD", row.get("status"));
assertEquals(false, row.get("writable"));
diff --git a/etl-service/src/test/java/com/xtrmetl/etl/controller/EtlControllerTest.java b/etl-service/src/test/java/com/xtrmetl/etl/controller/EtlControllerTest.java
index 9b935263..6c71e9b7 100644
--- a/etl-service/src/test/java/com/xtrmetl/etl/controller/EtlControllerTest.java
+++ b/etl-service/src/test/java/com/xtrmetl/etl/controller/EtlControllerTest.java
@@ -243,13 +243,15 @@ void mapsUnexpectedFailureToGenericInternalProblem() throws Exception {
}
@Test
- void connectorCatalogRemainsAvailable() throws Exception {
+ void connectorCatalogRemainsAvailableWithoutQlikRowWriteScaffold() throws Exception {
mockMvc.perform(get("/api/etl/connectors"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.product").value("mightyETL"))
.andExpect(jsonPath("$.primaryLoadPath").value("postgresql"))
- .andExpect(jsonPath("$.connectors.length()").value(3))
+ .andExpect(jsonPath("$.connectors.length()").value(2))
.andExpect(jsonPath("$.connectors[?(@.id == 'databricks')]").exists())
+ .andExpect(jsonPath("$.connectors[?(@.id == 'snowflake')]").exists())
+ .andExpect(jsonPath("$.connectors[?(@.id == 'qlik-sense')]").doesNotExist())
.andExpect(jsonPath("$.connectors[*].requiredConfigKeys").exists())
.andExpect(jsonPath("$.connectors[*].integration").exists());
}