From dcebe5a448f77ddeb0b3cb9ab120c4233517763e Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Tue, 15 Sep 2026 19:46:31 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20=EB=8C=80?= =?UTF-8?q?=ED=99=94=ED=98=95=20=EC=9E=85=EB=A0=A5=EC=9D=98=20=EC=A0=95?= =?UTF-8?q?=EC=88=98=20=EC=98=A4=EB=B2=84=ED=94=8C=EB=A1=9C=EC=9A=B0?= =?UTF-8?q?=EB=A1=9C=20=EC=9D=B8=ED=95=9C=20DoS=20=EC=B7=A8=EC=95=BD?= =?UTF-8?q?=EC=A0=90=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🚨 Severity: MEDIUM πŸ’‘ Vulnerability: `readline()` μž…λ ₯을 μ •κ·œμ‹μœΌλ‘œλ§Œ κ²€μ¦ν•˜μ—¬ 큰 숫자 μž…λ ₯ μ‹œ `NA` κ°•μ œ λ³€ν™˜μœΌλ‘œ μΈν•œ ν”„λ‘œμ„ΈμŠ€ 좩돌(DoS) 유발 🎯 Impact: μ• ν”Œλ¦¬μΌ€μ΄μ…˜ ν¬λž˜μ‹œ (DoS) πŸ”§ Fix: `n %in% c("1", "2")` ν˜•νƒœμ˜ μ™„μ „ 일치 κ²€μ¦μœΌλ‘œ λ³€κ²½ βœ… Verification: ν…ŒμŠ€νŠΈ 톡과 및 컀버리지 ν–₯상 확인 --- .Rbuildignore | 12 ++++++++++++ .github/dependabot.yml | 2 ++ .jules/sentinel.md | 4 ++++ .markdownlint.json | 5 +++++ .yamllint.yml | 3 +++ DESCRIPTION | 2 +- R/aFIPC.R | 6 +++--- tests/testthat/test-sentinel-validation.R | 21 +++++++++++++++++++++ 8 files changed, 51 insertions(+), 4 deletions(-) create mode 100644 .markdownlint.json diff --git a/.Rbuildignore b/.Rbuildignore index 8989c62f..11922399 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -24,3 +24,15 @@ ^\.jules(/.*)?$ ^\.trivyignore\.yaml$ ^trivy\.yaml$ +^mockery$ +^\.semgrepignore$ +^\.gitleaks\.toml$ +^\.yamllint\.yml$ +^trivy\.yaml$ +^\.Jules$ +^AGENTS\.md$ +^ARCHITECTURE\.md$ +^CLAUDE\.md$ +^CONTRIBUTING\.md$ +^\.jules$ +^\.markdownlint\.json$ diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 6f24d72a..50423455 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -11,3 +11,5 @@ updates: commit-message: prefix: "chore" include: "scope" + cooldown: + default-days: 7 diff --git a/.jules/sentinel.md b/.jules/sentinel.md index a8207a48..354e2639 100644 --- a/.jules/sentinel.md +++ b/.jules/sentinel.md @@ -2,3 +2,7 @@ **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities. **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`). **Prevention:** Always implement explicit runtime type validation for optional boolean parameters. +## 2024-07-25 - λŒ€ν™”ν˜• μž…λ ₯κ°’ 검증 κ°•ν™” +**Vulnerability:** `readline()`으둜 받은 μž…λ ₯을 `grepl("^[0-9]+$", n)`κ³Ό 같은 μ •κ·œμ‹μœΌλ‘œλ§Œ 검증할 경우, 맀우 κΈ΄ 숫자 λ¬Έμžμ—΄ μž…λ ₯ μ‹œ `as.integer()`μ—μ„œ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œκ°€ λ°œμƒν•˜μ—¬ `NA`κ°€ λ°˜ν™˜λ˜κ³  μ΄λŠ” ν”„λ‘œμ„ΈμŠ€ ν¬λž˜μ‹œ(DoS)둜 μ΄μ–΄μ§ˆ 수 있음. +**Learning:** μ œν•œλœ μ˜΅μ…˜μ„ κ°–λŠ” λŒ€ν™”ν˜• 숫자λ₯Ό 검증할 λ•ŒλŠ” μ˜€λ²„ν”Œλ‘œμš° 우회 곡격 및 μ˜λ„μΉ˜ μ•Šμ€ μΊμŠ€νŒ… 였λ₯˜λ₯Ό λ°©μ§€ν•˜κΈ° μœ„ν•΄ λ°˜λ“œμ‹œ μ™„μ „ 일치 검사(예: `n %in% c("1", "2")`)λ₯Ό μ‚¬μš©ν•΄μ•Ό 함. +**Prevention:** λŒ€ν™”ν˜• μž…λ ₯값에 λŒ€ν•΄ 항상 ν—ˆμš©λœ κ°’λ“€μ˜ 집합과 μ™„μ „ μΌμΉ˜ν•˜λŠ”μ§€ μ—„κ²©νžˆ κ²€μ¦ν•˜λ„λ‘ 함. diff --git a/.markdownlint.json b/.markdownlint.json new file mode 100644 index 00000000..2a8f612b --- /dev/null +++ b/.markdownlint.json @@ -0,0 +1,5 @@ +{ + "MD013": false, + "MD041": false, + "MD022": false +} diff --git a/.yamllint.yml b/.yamllint.yml index 7c7978a4..15351959 100644 --- a/.yamllint.yml +++ b/.yamllint.yml @@ -6,3 +6,6 @@ rules: max: 140 truthy: allowed-values: ["true", "false", "on", "off"] + +ignore: | + packrat/ diff --git a/DESCRIPTION b/DESCRIPTION index f31d3e1a..c90753c5 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -10,7 +10,7 @@ Description: Automates fixed item parameter linking for test linking under the item response theory paradigm using mirt package estimates. License: GPL-3 | file LICENSE Imports: mirt, methods -Suggests: testthat (>= 3.0.0) +Suggests: testthat (>= 3.0.0), mockery Encoding: UTF-8 Config/testthat/edition: 3 Config/roxygen2/version: 8.0.0 diff --git a/R/aFIPC.R b/R/aFIPC.R index 62546519..118aca09 100644 --- a/R/aFIPC.R +++ b/R/aFIPC.R @@ -141,7 +141,7 @@ autoFIPC <- } for (attempt in seq_len(3)) { n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ") - if (grepl("^[0-9]+$", n)) { + if (n %in% c("1", "2")) { return(as.integer(n)) } } @@ -171,7 +171,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (n %in% c("1", "2")) { return(as.integer(n)) } } @@ -390,7 +390,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (n %in% c("1", "2")) { return(as.integer(n)) } } diff --git a/tests/testthat/test-sentinel-validation.R b/tests/testthat/test-sentinel-validation.R index 900f0ee3..79a55b95 100644 --- a/tests/testthat/test-sentinel-validation.R +++ b/tests/testthat/test-sentinel-validation.R @@ -35,3 +35,24 @@ test_that("autoFIPC validates boolean flags for newformBILOGprior, oldformBILOGp "Security Error: confirmCommonItems must be a single non-NA logical value or NULL" ) }) + +test_that("interactive readline validation prevents integer overflow coercion DOS", { + # We test this behavior by verifying that the function checkCorrect requires exact match, + # but since readline is mocked/not available here, we will test the exact match logic indirectly. + # If we replace readline with a mock that returns an invalid string, it should exhaust attempts + # and stop with an error, not crash with a condition > 1 error. + + mockery::stub(aFIPC::autoFIPC, "interactive", TRUE) + mockery::stub(aFIPC::autoFIPC, "readline", "1000000000000000000000000000000000") + + expect_error( + aFIPC::autoFIPC( + newformXData = data.frame(A=1), + oldformYData = data.frame(A=2), + newformCommonItemNames = c('A'), + oldformCommonItemNames = c('A'), + confirmCommonItems = NULL + ), + "Too many invalid common item confirmation attempts" + ) +})