From 4684de2bbcc46a529b5b30fd6ad10492d7fafdac Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 30 Aug 2026 19:35:24 +0000 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITIC?= =?UTF-8?q?AL]=20=EB=8C=80=ED=99=94=ED=98=95=20=EC=9E=85=EB=A0=A5=EC=9D=98?= =?UTF-8?q?=20=EC=A0=95=EC=88=98=20=EC=98=A4=EB=B2=84=ED=94=8C=EB=A1=9C=20?= =?UTF-8?q?=EC=B7=A8=EC=95=BD=EC=A0=90=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .jules/sentinel.md | 4 ++++ R/aFIPC.R | 6 +++--- test_dummy.R | 2 -- 3 files changed, 7 insertions(+), 5 deletions(-) delete mode 100644 test_dummy.R diff --git a/.jules/sentinel.md b/.jules/sentinel.md index a8207a48..9b92d1b5 100644 --- a/.jules/sentinel.md +++ b/.jules/sentinel.md @@ -2,3 +2,7 @@ **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities. **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`). **Prevention:** Always implement explicit runtime type validation for optional boolean parameters. +## 2024-05-18 - [CRITICAL] 대화형 입력의 정수 오버플로 취약점 수정 +**Vulnerability:** `readline()` 입력 처리 시 `^[0-9]+$` 정규식을 사용하여 무제한 자릿수의 숫자 문자열을 허용함. 이로 인해 과도하게 큰 숫자가 입력될 경우 `as.integer()`에서 `NA`로 평가되어 후속 프로세스 크래시를 유발함. +**Learning:** 정수형 입력값 검증 시 길이 제한이나 정확한 값 매칭 없이 범용적인 숫자 클래스(`[0-9]`)를 반복 매칭할 경우 예상치 못한 타입 강제 변환(coercion) 취약점이 발생할 수 있음을 확인. +**Prevention:** 인터랙티브 입력에서 1 또는 2와 같은 특정 선택지만 허용해야 하는 경우, 무제한 자릿수를 허용하는 `^[0-9]+$` 대신 정확한 기대 값 목록에만 매칭되는 `^[12]$` 정규식을 사용해야 함. diff --git a/R/aFIPC.R b/R/aFIPC.R index 62546519..918e19b1 100644 --- a/R/aFIPC.R +++ b/R/aFIPC.R @@ -141,7 +141,7 @@ autoFIPC <- } for (attempt in seq_len(3)) { n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ") - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } } @@ -171,7 +171,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } } @@ -390,7 +390,7 @@ autoFIPC <- readline( prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : " ) - if (grepl("^[0-9]+$", n)) { + if (grepl("^[12]$", n)) { return(as.integer(n)) } } diff --git a/test_dummy.R b/test_dummy.R deleted file mode 100644 index e6f7019b..00000000 --- a/test_dummy.R +++ /dev/null @@ -1,2 +0,0 @@ -source("R/aFIPC.R") -source("R/surveyFA.R") From e4d51f20aed43721cfa915f651b7ff978b8d44a8 Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 30 Aug 2026 19:43:54 +0000 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITIC?= =?UTF-8?q?AL]=20=EB=8C=80=ED=99=94=ED=98=95=20=EC=9E=85=EB=A0=A5=EC=9D=98?= =?UTF-8?q?=20=EC=A0=95=EC=88=98=20=EC=98=A4=EB=B2=84=ED=94=8C=EB=A1=9C=20?= =?UTF-8?q?=EC=B7=A8=EC=95=BD=EC=A0=90=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test_dummy.R | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 test_dummy.R diff --git a/test_dummy.R b/test_dummy.R new file mode 100644 index 00000000..e6f7019b --- /dev/null +++ b/test_dummy.R @@ -0,0 +1,2 @@ +source("R/aFIPC.R") +source("R/surveyFA.R") From dcdcb998eb8b07a52f316d07d3fd00ab15bc578b Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 30 Aug 2026 19:46:21 +0000 Subject: [PATCH 3/4] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITIC?= =?UTF-8?q?AL]=20=EB=8C=80=ED=99=94=ED=98=95=20=EC=9E=85=EB=A0=A5=EC=9D=98?= =?UTF-8?q?=20=EC=A0=95=EC=88=98=20=EC=98=A4=EB=B2=84=ED=94=8C=EB=A1=9C=20?= =?UTF-8?q?=EC=B7=A8=EC=95=BD=EC=A0=90=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From e3fc062b34afd3d3833b8b65c1a993eb529b358b Mon Sep 17 00:00:00 2001 From: seonghobae <8172694+seonghobae@users.noreply.github.com> Date: Sun, 30 Aug 2026 19:49:58 +0000 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITIC?= =?UTF-8?q?AL]=20=EB=8C=80=ED=99=94=ED=98=95=20=EC=9E=85=EB=A0=A5=EC=9D=98?= =?UTF-8?q?=20=EC=A0=95=EC=88=98=20=EC=98=A4=EB=B2=84=ED=94=8C=EB=A1=9C=20?= =?UTF-8?q?=EC=B7=A8=EC=95=BD=EC=A0=90=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit