From baee8854e99dc416b2b907a22101c53a6eca9eca Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Tue, 1 Sep 2026 12:20:57 +0000 Subject: [PATCH 1/2] feat(api): retrieve stored interpretation-run requests by extra-segment GET Publish GET /v1/interpretation-runs/{idempotency_key}/request so operators fetch the accepted create request without POST replay. scientific_authority stays false. Naruon and LineageWeave are refused. NaruonLiveService stays POST-only. Cancel extra-segment stays refused. ADR 0085. --- .../interpretation-run-stored-request-get.md | 1 + DOCUMENTATION.md | 1 + .../interpretation_run_stored_request_http.rs | 284 ++++++++++++++++++ crates/orchestrator_live/src/lib.rs | 13 + crates/orchestrator_live/src/service.rs | 32 ++ ...tation_run_stored_request_http_contract.rs | 114 +++++++ docs/API_CONTRACT.md | 1 + docs/TRACEABILITY.md | 1 + ...5-interpretation-run-stored-request-get.md | 57 ++++ docs/adr/README.md | 1 + .../interpretation-run-stored-request-get.md | 13 + 11 files changed, 518 insertions(+) create mode 100644 CHANGELOG.d/interpretation-run-stored-request-get.md create mode 100644 crates/orchestrator_live/src/interpretation_run_stored_request_http.rs create mode 100644 crates/orchestrator_live/tests/interpretation_run_stored_request_http_contract.rs create mode 100644 docs/adr/0085-interpretation-run-stored-request-get.md create mode 100644 docs/research/interpretation-run-stored-request-get.md diff --git a/CHANGELOG.d/interpretation-run-stored-request-get.md b/CHANGELOG.d/interpretation-run-stored-request-get.md new file mode 100644 index 000000000..2b0c143a0 --- /dev/null +++ b/CHANGELOG.d/interpretation-run-stored-request-get.md @@ -0,0 +1 @@ +- `GET /v1/interpretation-runs/{idempotency_key}/request` returns the accepted contextual-orchestrator create request on `tepp-orchestrator-loopback` (ADR 0085). Metric-free; `scientific_authority` remains false. Does not infer causality. Naruon and LineageWeave refused. `NaruonLiveService` stays POST-only. Does not re-open cancel lineages. Not GAP-010 Figma/export, not persistence. diff --git a/DOCUMENTATION.md b/DOCUMENTATION.md index e82530848..0c0c2b30e 100644 --- a/DOCUMENTATION.md +++ b/DOCUMENTATION.md @@ -16,6 +16,7 @@ TEPP's approved PRD v0.4 and implementation plan are the primary product baselin | Interpretation-run CLI doctoring | [`docs/research/interpretation-run-cli.md`](docs/research/interpretation-run-cli.md) | | Interpretation-run collection GET doctoring | [`docs/research/interpretation-run-collection-http.md`](docs/research/interpretation-run-collection-http.md) | | Interpretation-run GET-by-id doctoring | [`docs/research/interpretation-run-retrieval-http.md`](docs/research/interpretation-run-retrieval-http.md) | +| Interpretation-run stored-request GET doctoring | [`docs/research/interpretation-run-stored-request-get.md`](docs/research/interpretation-run-stored-request-get.md) | | UML/runtime/scientific flows | [`docs/UML.md`](docs/UML.md) | | Logical/physical ERD | [`docs/ERD.md`](docs/ERD.md) | | Security policy | [`SECURITY.md`](SECURITY.md) | diff --git a/crates/orchestrator_live/src/interpretation_run_stored_request_http.rs b/crates/orchestrator_live/src/interpretation_run_stored_request_http.rs new file mode 100644 index 000000000..d9caa7006 --- /dev/null +++ b/crates/orchestrator_live/src/interpretation_run_stored_request_http.rs @@ -0,0 +1,284 @@ +//! Provider-owned interpretation-run stored-request GET contracts. +//! +//! GAP-003A unique slice: `GET /v1/interpretation-runs/{idempotency_key}/request` +//! returns the accepted metric-free `InterpretationRunRequest` on +//! `OrchestratorLiveService` / `tepp-orchestrator-loopback` so operators who +//! hold a retrieval identity do not replay POST. The stored request stays +//! `scientific_authority=false`. `tepp.scientific_acceptance.v1` never +//! appears. This module does not duplicate GET-by-id (#438), retrieval CLI +//! (#439), collection GET (#433), collection CLI (#436), create CLI (#425), +//! analysis-run stored-request GET (#377), cancel lineages (closed), Leiden, +//! or GAP-010 Figma/export. Persistence remains GAP-003B. Naruon and +//! `LineageWeave` are refused. `NaruonLiveService` stays POST-only. + +use crate::error::OrchestratorLiveError; +use crate::interpretation_run_cli::CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE; +use crate::interpretation_run_retrieval_http::INTERPRETATION_RUN_RETRIEVAL_ID_MAX_LEN; +use crate::request::{host_implies_table_access, require_nonempty, INTERPRETATION_RUN_PATH}; + +const FORBIDDEN_STORED_REQUEST_KEYS: [&str; 12] = [ + "rmse", + "rmse_standard_error", + "mean_bias", + "bias_standard_error", + "interval_coverage", + "se_gate_accepted", + "scientific_acceptance", + "causal_score", + "findings", + "evidence_text", + "report", + "event_label", +]; + +/// Typed GET exchange for interpretation-run stored-request retrieval. +#[derive(Clone, Debug, Eq, PartialEq)] +pub struct InterpretationRunStoredRequestHttpExchange { + /// HTTP method, always `GET`. + pub method: &'static str, + /// Absolute HTTPS target ending in `/v1/interpretation-runs/{key}/request`. + pub target_url: String, + /// Exact version, consumer, and content headers. No credentials. + pub headers: Vec<(String, String)>, + /// GET body, always empty. + pub body: String, +} + +/// Extract the opaque idempotency key from +/// `GET /v1/interpretation-runs/{key}/request`. +/// +/// # Errors +/// +/// Returns [`OrchestratorLiveError::InvalidWirePayload`] for collection, +/// GET-by-id, extra segments, a hostile encoding, empty identity, slash, or +/// NUL, and [`OrchestratorLiveError::LimitExceeded`] when oversized. +pub fn interpretation_run_stored_request_path_id( + path: &str, +) -> Result { + let remainder = path + .strip_prefix(INTERPRETATION_RUN_PATH) + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let encoded = remainder + .strip_prefix('/') + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let (encoded_id, rest) = encoded + .split_once('/') + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + if rest != "request" || encoded_id.is_empty() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let idempotency_key = decode_path_segment(encoded_id)?; + require_nonempty(&idempotency_key)?; + if idempotency_key.contains('/') || idempotency_key.contains('\0') { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + if idempotency_key.len() > INTERPRETATION_RUN_RETRIEVAL_ID_MAX_LEN { + return Err(OrchestratorLiveError::LimitExceeded); + } + Ok(idempotency_key) +} + +/// Whether `path` is the stored-request extra-segment resource. +#[must_use] +pub fn is_interpretation_run_stored_request_path(path: &str) -> bool { + interpretation_run_stored_request_path_id(path).is_ok() +} + +/// Build a credential-free contextual-orchestrator stored-request GET exchange. +/// +/// # Errors +/// +/// Returns a fail-closed origin or identity error. +pub fn contextual_orchestrator_interpretation_run_stored_request_exchange( + origin: &str, + idempotency_key: &str, +) -> Result { + require_nonempty(origin)?; + if !origin.starts_with("https://") || origin.ends_with('/') { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let rest = origin + .strip_prefix("https://") + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + if rest.contains('@') || rest.contains('?') || rest.contains('#') || rest.contains('\\') { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + if host_implies_table_access(rest) { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + require_nonempty(idempotency_key)?; + if idempotency_key.contains('/') || idempotency_key.contains('\0') { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + if idempotency_key.len() > INTERPRETATION_RUN_RETRIEVAL_ID_MAX_LEN { + return Err(OrchestratorLiveError::LimitExceeded); + } + let encoded_id = encode_path_segment(idempotency_key); + Ok(InterpretationRunStoredRequestHttpExchange { + method: "GET", + target_url: format!("{origin}{INTERPRETATION_RUN_PATH}/{encoded_id}/request"), + headers: vec![ + ("content-type".into(), "application/json".into()), + ( + "tepp-consumer".into(), + CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE.into(), + ), + ("tepp-contract-version".into(), "1".into()), + ], + body: String::new(), + }) +} + +/// Refuse stored-request JSON that already carries scientific-metric keys. +/// +/// Empty payloads are admitted for the GET request body. +/// +/// # Errors +/// +/// Returns [`OrchestratorLiveError::InvalidWirePayload`] when a forbidden +/// metric, evidence, or causal-score key is present. +pub fn refuse_metrics_on_interpretation_run_stored_request_payload( + payload: &str, +) -> Result<(), OrchestratorLiveError> { + if payload.trim().is_empty() { + return Ok(()); + } + if payload.contains("tepp.scientific_acceptance.v1") { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let value: serde_json::Value = + serde_json::from_str(payload).map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + refuse_metrics_on_json(&value) +} + +fn refuse_metrics_on_json(value: &serde_json::Value) -> Result<(), OrchestratorLiveError> { + match value { + serde_json::Value::Object(object) => { + if FORBIDDEN_STORED_REQUEST_KEYS + .iter() + .any(|key| object.contains_key(*key)) + { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + for nested in object.values() { + refuse_metrics_on_json(nested)?; + } + Ok(()) + } + serde_json::Value::Array(items) => { + for nested in items { + refuse_metrics_on_json(nested)?; + } + Ok(()) + } + _ => Ok(()), + } +} + +fn encode_path_segment(value: &str) -> String { + let mut out = String::with_capacity(value.len()); + for byte in value.bytes() { + match byte { + b'A'..=b'Z' | b'a'..=b'z' | b'0'..=b'9' | b'-' | b'.' | b'_' | b'~' => { + out.push(byte as char); + } + _ => { + let hex = b"0123456789ABCDEF"; + out.push('%'); + out.push(hex[usize::from(byte >> 4)] as char); + out.push(hex[usize::from(byte & 0x0F)] as char); + } + } + } + out +} + +fn decode_path_segment(value: &str) -> Result { + let mut out = Vec::with_capacity(value.len()); + let bytes = value.as_bytes(); + let mut index = 0; + while index < bytes.len() { + match bytes[index] { + b'%' => { + if index + 2 >= bytes.len() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let hi = from_hex(bytes[index + 1])?; + let lo = from_hex(bytes[index + 2])?; + out.push((hi << 4) | lo); + index += 3; + } + b'A'..=b'Z' | b'a'..=b'z' | b'0'..=b'9' | b'-' | b'.' | b'_' | b'~' => { + out.push(bytes[index]); + index += 1; + } + _ => return Err(OrchestratorLiveError::InvalidWirePayload), + } + } + let decoded = String::from_utf8(out).map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + if decoded.chars().any(char::is_control) { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + Ok(decoded) +} + +fn from_hex(byte: u8) -> Result { + match byte { + b'0'..=b'9' => Ok(byte - b'0'), + b'A'..=b'F' => Ok(byte - b'A' + 10), + b'a'..=b'f' => Ok(byte - b'a' + 10), + _ => Err(OrchestratorLiveError::InvalidWirePayload), + } +} + +#[cfg(test)] +mod tests { + use super::{ + contextual_orchestrator_interpretation_run_stored_request_exchange, + interpretation_run_stored_request_path_id, is_interpretation_run_stored_request_path, + }; + use crate::error::OrchestratorLiveError; + + #[test] + fn stored_request_exchange_is_metric_free_get_without_credentials() { + let exchange = contextual_orchestrator_interpretation_run_stored_request_exchange( + "https://tepp.example.test", + "idem-a", + ) + .expect("exchange"); + assert_eq!(exchange.method, "GET"); + assert!(exchange + .target_url + .ends_with("/v1/interpretation-runs/idem-a/request")); + assert!(exchange.body.is_empty()); + assert!(!exchange.headers.iter().any(|(name, _)| name + .eq_ignore_ascii_case("authorization") + || name.eq_ignore_ascii_case("idempotency-key"))); + assert!(is_interpretation_run_stored_request_path( + "/v1/interpretation-runs/idem-a/request" + )); + assert!(!is_interpretation_run_stored_request_path( + "/v1/interpretation-runs/idem-a" + )); + assert_eq!( + interpretation_run_stored_request_path_id("/v1/interpretation-runs/idem-a/request") + .expect("id"), + "idem-a" + ); + assert_eq!( + interpretation_run_stored_request_path_id("/v1/interpretation-runs/idem-a"), + Err(OrchestratorLiveError::InvalidWirePayload) + ); + assert_eq!( + interpretation_run_stored_request_path_id("/v1/interpretation-runs/idem-a/cancel"), + Err(OrchestratorLiveError::InvalidWirePayload) + ); + assert_eq!( + contextual_orchestrator_interpretation_run_stored_request_exchange( + "http://tepp.example.test", + "idem-a" + ), + Err(OrchestratorLiveError::InvalidWirePayload) + ); + } +} diff --git a/crates/orchestrator_live/src/lib.rs b/crates/orchestrator_live/src/lib.rs index 260f3c2db..b9aea0646 100644 --- a/crates/orchestrator_live/src/lib.rs +++ b/crates/orchestrator_live/src/lib.rs @@ -7,6 +7,8 @@ //! hypothetical and never scientific authority. Collection GET enumerates //! metric-free identities so operators do not guess idempotency keys. //! GET-by-id returns one of those identities without POST replay. +//! `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored +//! create request without POST replay. //! Table-access hosts, review/Copilot/GitHub credentials, and //! `COPILOT_GITHUB_TOKEN` fail closed. This crate does not implement TLS //! termination or call a model provider (ADR 0010; ADR 0011). The published @@ -19,6 +21,7 @@ mod http; mod interpretation_run_cli; mod interpretation_run_collection_http; mod interpretation_run_retrieval_http; +mod interpretation_run_stored_request_http; mod mode; mod request; mod service; @@ -89,6 +92,16 @@ pub use interpretation_run_retrieval_http::interpretation_run_retrieval_path_id; pub use interpretation_run_retrieval_http::InterpretationRunRetrievalHttpExchange; /// Maximum opaque idempotency-key length on interpretation-run GET-by-id. pub use interpretation_run_retrieval_http::INTERPRETATION_RUN_RETRIEVAL_ID_MAX_LEN; +/// Build a credential-free contextual-orchestrator stored-request GET exchange. +pub use interpretation_run_stored_request_http::contextual_orchestrator_interpretation_run_stored_request_exchange; +/// Extract the opaque idempotency key from a stored-request GET path. +pub use interpretation_run_stored_request_http::interpretation_run_stored_request_path_id; +/// Whether a path is the stored-request extra-segment resource. +pub use interpretation_run_stored_request_http::is_interpretation_run_stored_request_path; +/// Refuse metric keys on stored-request JSON. +pub use interpretation_run_stored_request_http::refuse_metrics_on_interpretation_run_stored_request_payload; +/// Typed GET exchange for interpretation-run stored-request retrieval. +pub use interpretation_run_stored_request_http::InterpretationRunStoredRequestHttpExchange; /// Closed ADR 0010 orchestration-mode vocabulary. pub use mode::OrchestrationMode; /// Accepted hypothetical interpretation-run response. diff --git a/crates/orchestrator_live/src/service.rs b/crates/orchestrator_live/src/service.rs index 969fa0349..430739e96 100644 --- a/crates/orchestrator_live/src/service.rs +++ b/crates/orchestrator_live/src/service.rs @@ -1,4 +1,6 @@ //! Loopback-only live HTTP/1.1 listener for interpretation POSTs (ADR 0010/0011). +//! `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored +//! create request without POST replay. use std::collections::HashMap; use std::net::{SocketAddr, TcpListener, TcpStream}; @@ -18,6 +20,10 @@ use crate::interpretation_run_collection_http::{ use crate::interpretation_run_retrieval_http::{ interpretation_run_retrieval_item_json, interpretation_run_retrieval_path_id, }; +use crate::interpretation_run_stored_request_http::{ + interpretation_run_stored_request_path_id, is_interpretation_run_stored_request_path, + refuse_metrics_on_interpretation_run_stored_request_payload, +}; use crate::request::{ to_json, InterpretationRunAccepted, InterpretationRunRequest, INTERPRETATION_RUN_PATH, }; @@ -30,6 +36,8 @@ use crate::request::{ /// `GET /v1/interpretation-runs` enumerates accepted hypothetical runs as /// metric-free identities. `GET /v1/interpretation-runs/{idempotency_key}` /// returns one of those identities without POST replay. +/// `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored +/// create request without POST replay. #[derive(Debug)] pub struct OrchestratorLiveService { listener: Option, @@ -180,6 +188,9 @@ impl OrchestratorLiveService { if is_interpretation_run_collection_path(path) { return self.list_interpretation_runs(path, &headers, body); } + if is_interpretation_run_stored_request_path(path) { + return self.get_interpretation_run_stored_request(path, &headers, body); + } return self.get_interpretation_run(path, &headers, body); } if method != "POST" || path != INTERPRETATION_RUN_PATH { @@ -261,6 +272,27 @@ impl OrchestratorLiveService { )) } + fn get_interpretation_run_stored_request( + &self, + path: &str, + headers: &HashMap, + body: &str, + ) -> Result { + let idempotency_key = interpretation_run_stored_request_path_id(path)?; + if !body.is_empty() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + refuse_retrieval_get_headers(headers)?; + let stored = self + .accepted_runs + .get(&idempotency_key) + .map(|(request, _)| request) + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let payload = stored.to_json()?; + refuse_metrics_on_interpretation_run_stored_request_payload(&payload)?; + Ok(OrchestratorLiveResponse::json(200, "OK", payload)) + } + fn accept_interpretation_run( &mut self, headers: &HashMap, diff --git a/crates/orchestrator_live/tests/interpretation_run_stored_request_http_contract.rs b/crates/orchestrator_live/tests/interpretation_run_stored_request_http_contract.rs new file mode 100644 index 000000000..cf87006e2 --- /dev/null +++ b/crates/orchestrator_live/tests/interpretation_run_stored_request_http_contract.rs @@ -0,0 +1,114 @@ +//! Contract tests for contextual-orchestrator interpretation-run stored-request GET. + +use std::io::{Read, Write}; + +use orchestrator_live::{ + contextual_orchestrator_interpretation_run_stored_request_exchange, + interpretation_run_stored_request_path_id, is_interpretation_run_stored_request_path, + InterpretationRunRequest, OrchestrationMode, OrchestratorLiveError, OrchestratorLiveService, + CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE, INTERPRETATION_RUN_CONTRACT_VERSION, + INTERPRETATION_RUN_PATH, +}; + +fn sample_request() -> InterpretationRunRequest { + InterpretationRunRequest::new( + INTERPRETATION_RUN_CONTRACT_VERSION, + "orch-live-idem-001", + "orch-tenant-workspace-demo", + "tepp-snapshot-demo-001", + "2026-08-01T00:00:00Z", + OrchestrationMode::Direct, + 2048, + vec!["span-001".into()], + false, + ) + .expect("sample") +} + +fn post_http(request: &InterpretationRunRequest) -> String { + let body = request.to_json().expect("json"); + format!( + "POST {INTERPRETATION_RUN_PATH} HTTP/1.1\r\nHost: 127.0.0.1\r\ncontent-type: application/json\r\ntepp-consumer: {CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE}\r\ntepp-contract-version: 1\r\nidempotency-key: {}\r\ncontent-length: {}\r\n\r\n{body}", + request.idempotency_key(), + body.len() + ) +} + +#[test] +fn stored_request_exchange_is_metric_free_get_without_credentials() { + let exchange = contextual_orchestrator_interpretation_run_stored_request_exchange( + "https://tepp.example.test", + "orch-live-idem-001", + ) + .expect("exchange"); + assert_eq!(exchange.method, "GET"); + assert!(exchange + .target_url + .ends_with("/v1/interpretation-runs/orch-live-idem-001/request")); + assert!(exchange.body.is_empty()); + assert_eq!( + interpretation_run_stored_request_path_id( + "/v1/interpretation-runs/orch-live-idem-001/request" + ) + .expect("id"), + "orch-live-idem-001" + ); + assert!(!is_interpretation_run_stored_request_path( + "/v1/interpretation-runs/orch-live-idem-001" + )); +} + +#[test] +fn live_get_returns_stored_request_without_scientific_authority() { + let request = sample_request(); + let mut service = OrchestratorLiveService::new(); + assert_eq!( + service.handle_http_request(&post_http(&request)).status_code, + 202 + ); + let got = service.handle_http_request( + "GET /v1/interpretation-runs/orch-live-idem-001/request HTTP/1.1\r\nHost: 127.0.0.1\r\ncontent-type: application/json\r\ntepp-consumer: contextual-orchestrator\r\ntepp-contract-version: 1\r\ncontent-length: 0\r\n\r\n", + ); + assert_eq!(got.status_code, 200, "{}", got.body); + let stored = InterpretationRunRequest::from_json(&got.body).expect("stored"); + assert_eq!(stored, request); + assert!(!got.body.contains("tepp.scientific_acceptance.v1")); + assert!(!got.body.contains("rmse")); + assert_eq!( + service + .handle_http_request( + "GET /v1/interpretation-runs/orch-live-idem-001/request HTTP/1.1\r\nHost: 127.0.0.1\r\ncontent-type: application/json\r\ntepp-consumer: naruon\r\ntepp-contract-version: 1\r\ncontent-length: 0\r\n\r\n" + ) + .status_code, + 400 + ); + assert_eq!( + interpretation_run_stored_request_path_id("/v1/interpretation-runs/idem-a/cancel"), + Err(OrchestratorLiveError::InvalidWirePayload) + ); +} + +#[test] +fn stored_request_serves_over_tcp() { + let request = sample_request(); + let mut service = OrchestratorLiveService::bind_loopback().expect("bind"); + assert_eq!( + service.handle_http_request(&post_http(&request)).status_code, + 202 + ); + let addr = service.local_addr().expect("addr"); + let handle = std::thread::spawn(move || { + drop(service.serve_one()); + }); + let http = "GET /v1/interpretation-runs/orch-live-idem-001/request HTTP/1.1\r\nHost: 127.0.0.1\r\ncontent-type: application/json\r\ntepp-consumer: contextual-orchestrator\r\ntepp-contract-version: 1\r\ncontent-length: 0\r\n\r\n"; + let mut stream = std::net::TcpStream::connect(addr).expect("connect"); + stream.write_all(http.as_bytes()).expect("write"); + stream.flush().expect("flush"); + let mut bytes = Vec::new(); + stream.read_to_end(&mut bytes).expect("read"); + let text = String::from_utf8(bytes).expect("utf8"); + assert!(text.contains("HTTP/1.1 200"), "{text}"); + assert!(text.contains("orch-live-idem-001"), "{text}"); + assert!(text.contains("\"scientific_authority\":false"), "{text}"); + handle.join().expect("join"); +} diff --git a/docs/API_CONTRACT.md b/docs/API_CONTRACT.md index 3698a7377..7d5705b9e 100644 --- a/docs/API_CONTRACT.md +++ b/docs/API_CONTRACT.md @@ -65,6 +65,7 @@ GET /v1/evidence-imports/{import_id} POST /v1/interpretation-runs GET /v1/interpretation-runs GET /v1/interpretation-runs/{idempotency_key} +GET /v1/interpretation-runs/{idempotency_key}/request POST /v1/analysis-runs POST /v1/temporal-context GET /v1/analysis-runs/{run_id} diff --git a/docs/TRACEABILITY.md b/docs/TRACEABILITY.md index 4f128ab0f..8b28b0cbb 100644 --- a/docs/TRACEABILITY.md +++ b/docs/TRACEABILITY.md @@ -109,6 +109,7 @@ The full APA 7th standards/literature register remains `docs/research/standards- | loopback contextual-orchestrator interpretation-run CLI | ADR 0064; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `tepp-interpretation-runs create` CLI against `tepp-orchestrator-loopback` (`POST /v1/interpretation-runs`); metric-free hypothetical JSON; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | | loopback contextual-orchestrator interpretation-run collection GET | ADR 0069; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs` on `tepp-orchestrator-loopback`; metric-free hypothetical identities; empty body; no `idempotency-key`; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | | loopback contextual-orchestrator interpretation-run GET-by-id | ADR 0071; ADR 0069; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs/{idempotency_key}` on `tepp-orchestrator-loopback`; metric-free hypothetical identity without POST replay; empty body; no pagination; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | +| loopback contextual-orchestrator interpretation-run stored-request GET | ADR 0085; ADR 0071; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs/{idempotency_key}/request` on `tepp-orchestrator-loopback`; returns stored create request; `scientific_authority` remains false; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | | foundation validation / release-readiness ledger | ADR 0014; Test Strategy | PR #24 `docs/validation/temporal-event-foundation.md` on protected main | implemented-main | | scientific claim promotion separated from design/implementation/release | ADR 0014; ADR policy | `validation_core` exact-head promotion gates on this PR; documentation/CI/domain validation remain; full package/image release bundle remaining | partial | | CSAP/SOC 2/ISO/NIST assurance readiness | `docs/COMPLIANCE_READINESS.md`; research register | repository controls + future deployment evidence | accepted-target / deployment-owned | diff --git a/docs/adr/0085-interpretation-run-stored-request-get.md b/docs/adr/0085-interpretation-run-stored-request-get.md new file mode 100644 index 000000000..2cb36e82d --- /dev/null +++ b/docs/adr/0085-interpretation-run-stored-request-get.md @@ -0,0 +1,57 @@ +# ADR 0085 — Loopback interpretation-run stored-request GET + +**Decision status:** Accepted +**Implementation maturity:** active-PR +**Date:** 2026-09-01 +**Supersedes:** None; complements ADR 0071. Does not re-open cancel lineages. +Does not supersede ADR 0014. Unique versus protected main; 0026–0084 occupied. + +## Context + +ADR 0071 retrieves one accepted interpretation-run identity. Operators still +had no extra-segment GET for the stored create request. Analysis-run +stored-request GET (#377) is naruon-owned. Duplicating GET-by-id (#438), +retrieval CLI (#439), collection GET/CLI, create CLI, Leiden, or GAP-010 +would collide with live PRs. + +## Decision + +Publish `GET /v1/interpretation-runs/{idempotency_key}/request` on +`OrchestratorLiveService`. Extra-segment parse. Slash/NUL fail closed. Empty +body. `scientific_authority` remains false. `tepp.scientific_acceptance.v1` +never appears. Cancel extra-segment stays refused. + +## Alternatives considered + +1. Re-open cancel HTTP — rejected. +2. Return GET-by-id identity — rejected (ADR 0071). +3. Loopback stored-request GET — accepted. + +## Consequences + +HTTP 200 is not measurement evidence and is not an ADR 0014 claim. + +## Failure and recovery + +Non-orchestrator consumers, nonempty bodies, extra segments, slash/NUL, +missing keys, and metric keys fail closed. + +## Verification + +- `GET /v1/interpretation-runs/{idempotency_key}/request` of an accepted run + returns the stored create request without RMSE/`tepp.scientific_acceptance.v1`; +- naruon, LineageWeave, GET-by-id path, extra segments, slash/NUL, nonempty + body, and missing keys fail closed; +- Clippy `-D warnings`, `orchestrator_live` tests, rustdoc, and exact-head + review remain required. + +## Rollback and supersession + +Rollback removes the extra-segment GET; POST and GET-by-id remain valid. A +superseding ADR is required to persist the registry, bind a public address, +re-open cancel, emit scientific-acceptance, open naruon or LineageWeave, add +GET to `NaruonLiveService`, or treat retrieval success as an ADR 0014 claim. + +## Related authority + +ADR 0071, ADR 0069, ADR 0014, RFC 9110 (Fielding, Nottingham, & Reschke, 2022). diff --git a/docs/adr/README.md b/docs/adr/README.md index 4002ba826..519289f43 100644 --- a/docs/adr/README.md +++ b/docs/adr/README.md @@ -33,6 +33,7 @@ Read [`ADR_POLICY.md`](ADR_POLICY.md) first. **Decision status and implementatio | [0064](0064-interpretation-run-cli.md) | Loopback `tepp-interpretation-runs create` is contextual-orchestrator POST /v1/interpretation-runs client | Accepted | active-PR | Complements ADR 0010/0011; does not supersede ADR 0014. Unique on protected main. Does not infer causality. | | [0069](0069-interpretation-run-collection-get.md) | Loopback `GET /v1/interpretation-runs` enumerates accepted hypothetical interpretation runs | Accepted | active-PR | Complements ADR 0010/0011/0064; does not supersede ADR 0014. Unique on this stack versus protected main (0026–0068 occupied). Does not infer causality. | | [0071](0071-interpretation-run-retrieval-get.md) | Loopback `GET /v1/interpretation-runs/{idempotency_key}` returns one accepted hypothetical identity | Accepted | active-PR | Complements ADR 0069; does not supersede ADR 0014. Unique on this interpretation stack versus protected main (0026–0070 occupied). Does not infer causality. | +| [0085](0085-interpretation-run-stored-request-get.md) | Loopback interpretation-run stored-request GET | Accepted | active-PR | Complements ADR 0071; `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored create request. Unique versus protected main (0026–0084 occupied). Does not re-open cancel lineages. | | [0023](0023-lineage-criterion-anchor-contract.md) | TEPP-owned Event Lineage criterion anchor | Accepted | active-PR | PR #237 publishes the strict accepted/rejected artifact and identities; estimator execution remains fail-closed future work. | | [0024](0024-independent-topic-importance-anchor.md) | Posterior topic-context producer contract | Accepted | contract-only active-PR | Strict DTO/schema only; the current estimator does not emit it. fast-mlsirm owns case-deletion influence. | | [0001](0001-rust-first-modular-msa.md) | Rust-first numerical core and CPU `f64` reference | Accepted | partial | ADR 0011 owns cross-service/MSA authority; 0001 retains numerical/backend authority. | diff --git a/docs/research/interpretation-run-stored-request-get.md b/docs/research/interpretation-run-stored-request-get.md new file mode 100644 index 000000000..60e43a30a --- /dev/null +++ b/docs/research/interpretation-run-stored-request-get.md @@ -0,0 +1,13 @@ +# Interpretation-run stored-request GET (doctoring) + +`GET /v1/interpretation-runs/{idempotency_key}/request` returns one accepted +contextual-orchestrator create request on `tepp-orchestrator-loopback`. HTTP +semantics follow RFC 9110 (Fielding, Nottingham, & Reschke, 2022). Fail-closed +unpublished consumers, extra segments, slash/NUL, credential flags, and +scientific-authority promotion are repository contract (ADR 0085; ADR 0014). + +`scientific_authority` remains false. `tepp.scientific_acceptance.v1` never +appears. HTTP 200 is not a scientific claim. + +Does not re-open cancel lineages, GAP-010 Figma/export, persistence, Leiden, +or an ADR 0014 claim-promotion package. From c911fbcd6e13046358cc7f3692775ed4b008dadd Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Tue, 1 Sep 2026 12:28:40 +0000 Subject: [PATCH 2/2] feat(api): mint interpretation-run stored-request GET from a dedicated CLI Publish tepp-interpretation-run-request get so operators retrieve the stored create request on spawned tepp-orchestrator-loopback TCP without POST replay. scientific_authority stays false. Empty stdin is admitted. Naruon and LineageWeave are refused. NaruonLiveService stays POST-only. Cancel extra- segment stays refused. ADR 0086. --- .../interpretation-run-stored-request-cli.md | 1 + DOCUMENTATION.md | 1 + crates/orchestrator_live/Cargo.toml | 6 + .../bin/tepp_interpretation_run_request.rs | 35 + .../interpretation_run_stored_request_cli.rs | 652 ++++++++++++++++++ crates/orchestrator_live/src/lib.rs | 20 +- ...etation_run_stored_request_cli_contract.rs | 146 ++++ docs/API_CONTRACT.md | 1 + docs/TRACEABILITY.md | 1 + ...6-interpretation-run-stored-request-cli.md | 60 ++ docs/adr/README.md | 1 + .../interpretation-run-stored-request-cli.md | 14 + 12 files changed, 937 insertions(+), 1 deletion(-) create mode 100644 CHANGELOG.d/interpretation-run-stored-request-cli.md create mode 100644 crates/orchestrator_live/src/bin/tepp_interpretation_run_request.rs create mode 100644 crates/orchestrator_live/src/interpretation_run_stored_request_cli.rs create mode 100644 crates/orchestrator_live/tests/interpretation_run_stored_request_cli_contract.rs create mode 100644 docs/adr/0086-interpretation-run-stored-request-cli.md create mode 100644 docs/research/interpretation-run-stored-request-cli.md diff --git a/CHANGELOG.d/interpretation-run-stored-request-cli.md b/CHANGELOG.d/interpretation-run-stored-request-cli.md new file mode 100644 index 000000000..0ea9a4d12 --- /dev/null +++ b/CHANGELOG.d/interpretation-run-stored-request-cli.md @@ -0,0 +1 @@ +- `tepp-interpretation-run-request get` mints contextual-orchestrator `GET /v1/interpretation-runs/{idempotency_key}/request` onto spawned `tepp-orchestrator-loopback` TCP (ADR 0086). Metric-free; `scientific_authority` remains false. Empty stdin admitted. Does not infer causality. Naruon and LineageWeave refused. `NaruonLiveService` stays POST-only. Does not re-open cancel lineages. Not GAP-010 Figma/export, not persistence. diff --git a/DOCUMENTATION.md b/DOCUMENTATION.md index 0c0c2b30e..b3850d88d 100644 --- a/DOCUMENTATION.md +++ b/DOCUMENTATION.md @@ -17,6 +17,7 @@ TEPP's approved PRD v0.4 and implementation plan are the primary product baselin | Interpretation-run collection GET doctoring | [`docs/research/interpretation-run-collection-http.md`](docs/research/interpretation-run-collection-http.md) | | Interpretation-run GET-by-id doctoring | [`docs/research/interpretation-run-retrieval-http.md`](docs/research/interpretation-run-retrieval-http.md) | | Interpretation-run stored-request GET doctoring | [`docs/research/interpretation-run-stored-request-get.md`](docs/research/interpretation-run-stored-request-get.md) | +| Interpretation-run stored-request CLI doctoring | [`docs/research/interpretation-run-stored-request-cli.md`](docs/research/interpretation-run-stored-request-cli.md) | | UML/runtime/scientific flows | [`docs/UML.md`](docs/UML.md) | | Logical/physical ERD | [`docs/ERD.md`](docs/ERD.md) | | Security policy | [`SECURITY.md`](SECURITY.md) | diff --git a/crates/orchestrator_live/Cargo.toml b/crates/orchestrator_live/Cargo.toml index 38df1a3bc..9f2edcabd 100644 --- a/crates/orchestrator_live/Cargo.toml +++ b/crates/orchestrator_live/Cargo.toml @@ -29,5 +29,11 @@ path = "src/bin/tepp_interpretation_runs.rs" test = false bench = false +[[bin]] +name = "tepp-interpretation-run-request" +path = "src/bin/tepp_interpretation_run_request.rs" +test = false +bench = false + [lints] workspace = true diff --git a/crates/orchestrator_live/src/bin/tepp_interpretation_run_request.rs b/crates/orchestrator_live/src/bin/tepp_interpretation_run_request.rs new file mode 100644 index 000000000..1b6f4ad27 --- /dev/null +++ b/crates/orchestrator_live/src/bin/tepp_interpretation_run_request.rs @@ -0,0 +1,35 @@ +//! Operator CLI for loopback contextual-orchestrator stored-request GET. + +use std::io::{self, IsTerminal}; +use std::process::ExitCode; + +use orchestrator_live::{ + execute_interpretation_run_stored_request_cli, read_interpretation_run_stored_request_cli_stdin, + render_interpretation_run_stored_request_cli_stdout, + InterpretationRunStoredRequestCliInvocation, OrchestratorLiveError, +}; + +fn main() -> ExitCode { + match run() { + Ok(()) => ExitCode::SUCCESS, + Err(_) => ExitCode::FAILURE, + } +} + +fn run() -> Result<(), OrchestratorLiveError> { + let args: Vec = std::env::args().skip(1).collect(); + match args.first().map(String::as_str) { + Some("get") => run_get(&args), + _ => Err(OrchestratorLiveError::InvalidWirePayload), + } +} + +fn run_get(args: &[String]) -> Result<(), OrchestratorLiveError> { + let body = + read_interpretation_run_stored_request_cli_stdin(io::stdin().is_terminal(), io::stdin())?; + let invocation = InterpretationRunStoredRequestCliInvocation::from_args(args, body)?; + let response = execute_interpretation_run_stored_request_cli(&invocation)?; + let stdout = render_interpretation_run_stored_request_cli_stdout(&invocation, &response)?; + println!("{stdout}"); + Ok(()) +} diff --git a/crates/orchestrator_live/src/interpretation_run_stored_request_cli.rs b/crates/orchestrator_live/src/interpretation_run_stored_request_cli.rs new file mode 100644 index 000000000..5a02f54b9 --- /dev/null +++ b/crates/orchestrator_live/src/interpretation_run_stored_request_cli.rs @@ -0,0 +1,652 @@ +//! Operator loopback CLI for contextual-orchestrator stored-request GET. +//! +//! GAP-003A unique slice: operators run `tepp-interpretation-run-request get` +//! to mint `contextual_orchestrator_interpretation_run_stored_request_exchange` +//! onto spawned `tepp-orchestrator-loopback` TCP. Stdout is the stored create +//! request with `scientific_authority=false`. `tepp.scientific_acceptance.v1` +//! never appears. The CLI does not infer causality or call a model provider. +//! Naruon and `LineageWeave` are refused. `NaruonLiveService` stays POST-only. +//! This module does not duplicate stored-request GET (#453), GET-by-id (#438), +//! retrieval CLI (#439), collection GET/CLI (#433/#436), create CLI (#425), +//! analysis-run stored-request CLI (#395), cancel lineages (closed), Leiden, +//! or GAP-010 Figma/export. Persistence remains GAP-003B. + +use std::fmt::Write as _; +use std::io::{Read, Write}; +use std::net::{SocketAddr, TcpStream}; +use std::time::Duration; + +use crate::http::{header_is_credential, map_io_error}; +use crate::interpretation_run_cli::CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE; +use crate::interpretation_run_stored_request_http::{ + contextual_orchestrator_interpretation_run_stored_request_exchange, + interpretation_run_stored_request_path_id, + refuse_metrics_on_interpretation_run_stored_request_payload, + InterpretationRunStoredRequestHttpExchange, +}; +use crate::request::{ + require_nonempty, InterpretationRunRequest, DEFAULT_INTERPRETATION_BYTE_LIMIT, +}; +use crate::{ + OrchestratorLiveError, OrchestratorLiveResponse, OrchestratorLiveService, + LIVE_HEADER_BYTE_LIMIT, LIVE_HEADER_COUNT_LIMIT, +}; + +const SCIENTIFIC_ACCEPTANCE_SCHEMA: &str = "tepp.scientific_acceptance.v1"; +const CLI_IO_TIMEOUT: Duration = Duration::from_secs(2); +const MAXIMUM_HTTP_RESPONSE_BYTES: usize = + LIVE_HEADER_BYTE_LIMIT + 4 + DEFAULT_INTERPRETATION_BYTE_LIMIT; + +/// Supported operator verbs for the loopback interpretation-run retrieval CLI. +#[derive(Clone, Copy, Debug, Eq, PartialEq)] +pub enum InterpretationRunStoredRequestCliVerb { + /// `GET /v1/interpretation-runs/{idempotency_key}/request`. + Get, +} + +impl InterpretationRunStoredRequestCliVerb { + /// Parse one exact lowercase verb token. + /// + /// # Errors + /// + /// Returns [`OrchestratorLiveError::InvalidWirePayload`] for an unknown token. + pub fn parse(token: &str) -> Result { + match token { + "get" => Ok(Self::Get), + _ => Err(OrchestratorLiveError::InvalidWirePayload), + } + } + + /// Return the canonical lowercase verb token. + #[must_use] + pub const fn as_str(self) -> &'static str { + match self { + Self::Get => "get", + } + } +} + +/// One operator CLI invocation against a loopback stored-request listener. +#[derive(Clone, Debug, Eq, PartialEq)] +pub struct InterpretationRunStoredRequestCliInvocation { + /// CLI verb to execute. + pub verb: InterpretationRunStoredRequestCliVerb, + /// Loopback `host:port` of `tepp-orchestrator-loopback`. + pub host: String, + /// Published HTTPS origin used to mint the typed retrieval exchange. + pub origin: String, + /// Published modular consumer. Retrieval GET admits + /// `contextual-orchestrator` only. + pub consumer: String, + /// Opaque idempotency key that minted the stored identity. + pub idempotency_key: String, + /// JSON body. Retrieval GET requires empty. + pub body: String, +} + +impl InterpretationRunStoredRequestCliInvocation { + /// Parse argv plus stdin body into a validated loopback retrieval invocation. + /// + /// Empty stdin is admitted. Nonempty leftover stdin fails closed. + /// + /// # Errors + /// + /// Returns a fail-closed error for unknown verbs, missing required flags, a + /// non-loopback host, a non-`https` origin, an unpublished consumer, + /// credential-shaped flags, a hostile identity, or a nonempty body. + pub fn from_args(args: I, body: impl Into) -> Result + where + I: IntoIterator, + S: AsRef, + { + let tokens: Vec = args + .into_iter() + .map(|token| token.as_ref().to_owned()) + .collect(); + let (verb_token, rest) = tokens + .split_first() + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let verb = InterpretationRunStoredRequestCliVerb::parse(verb_token)?; + let flags = parse_flags(rest)?; + assemble_invocation(verb, flags, body.into()) + } + + /// Reject a non-loopback host, unpublished consumer, or hostile GET body. + /// + /// # Errors + /// + /// Returns [`OrchestratorLiveError::AuthorizationDenied`] for a non-loopback + /// host and [`OrchestratorLiveError::InvalidWirePayload`] or + /// [`OrchestratorLiveError::LimitExceeded`] for empty, unpublished, + /// nonempty-body, or oversized fields. + pub fn validate(&self) -> Result<(), OrchestratorLiveError> { + require_loopback_host(&self.host)?; + require_nonempty(&self.origin)?; + if !self.origin.starts_with("https://") { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + require_nonempty(&self.consumer)?; + if self.consumer != CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + require_nonempty(&self.idempotency_key)?; + if self.idempotency_key.contains('/') || self.idempotency_key.contains('\0') { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + if !self.body.is_empty() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + refuse_scientific_acceptance(&self.body)?; + refuse_metrics_on_interpretation_run_stored_request_payload(&self.body)?; + Ok(()) + } +} + +struct ParsedFlags { + host: Option, + origin: Option, + consumer: Option, + idempotency_key: Option, +} + +fn parse_flags(rest: &[String]) -> Result { + let mut flags = ParsedFlags { + host: None, + origin: None, + consumer: None, + idempotency_key: None, + }; + let mut index = 0; + while index < rest.len() { + let flag = rest[index].as_str(); + if !flag.starts_with("--") { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let name = &flag[2..]; + if header_is_credential(name) { + return Err(OrchestratorLiveError::AuthorizationDenied); + } + let slot = match name { + "host" => &mut flags.host, + "origin" => &mut flags.origin, + "consumer" => &mut flags.consumer, + "idempotency-key" => &mut flags.idempotency_key, + _ => return Err(OrchestratorLiveError::InvalidWirePayload), + }; + if slot.is_some() || index + 1 >= rest.len() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let value = rest[index + 1].as_str(); + require_nonempty(value)?; + *slot = Some(value.to_owned()); + index += 2; + } + Ok(flags) +} + +fn assemble_invocation( + verb: InterpretationRunStoredRequestCliVerb, + flags: ParsedFlags, + body: String, +) -> Result { + let invocation = InterpretationRunStoredRequestCliInvocation { + verb, + host: flags + .host + .ok_or(OrchestratorLiveError::InvalidWirePayload)?, + origin: flags + .origin + .ok_or(OrchestratorLiveError::InvalidWirePayload)?, + consumer: flags + .consumer + .unwrap_or_else(|| CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE.to_owned()), + idempotency_key: flags + .idempotency_key + .ok_or(OrchestratorLiveError::InvalidWirePayload)?, + body, + }; + invocation.validate()?; + Ok(invocation) +} + +fn require_loopback_host(host: &str) -> Result { + let addr: SocketAddr = host + .parse() + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + if addr.ip().is_loopback() { + Ok(addr) + } else { + Err(OrchestratorLiveError::AuthorizationDenied) + } +} + +/// Render a typed retrieval GET exchange as HTTP/1.1 for a loopback listener. +/// +/// # Errors +/// +/// Returns [`OrchestratorLiveError::AuthorizationDenied`] for a non-loopback +/// host or a credential-bearing header, and +/// [`OrchestratorLiveError::InvalidWirePayload`] when the exchange is not a +/// GET `/v1/interpretation-runs/{idempotency_key}/request` with an empty body. +pub fn loopback_http1_from_interpretation_run_stored_request_exchange( + exchange: &InterpretationRunStoredRequestHttpExchange, + loopback_host: &str, +) -> Result { + let _addr = require_loopback_host(loopback_host)?; + let host = loopback_host.trim(); + if exchange.method != "GET" { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + if !exchange.body.is_empty() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let rest = exchange + .target_url + .strip_prefix("https://") + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let path = rest + .find('/') + .map(|index| &rest[index..]) + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let _idempotency_key = interpretation_run_stored_request_path_id(path)?; + for (name, _) in &exchange.headers { + if header_is_credential(name) { + return Err(OrchestratorLiveError::AuthorizationDenied); + } + if name.eq_ignore_ascii_case("idempotency-key") + || name.eq_ignore_ascii_case("tepp-page-limit") + || name.eq_ignore_ascii_case("tepp-page-cursor") + { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + } + let mut request = String::new(); + write!( + request, + "{} {path} HTTP/1.1\r\nHost: {host}\r\n", + exchange.method + ) + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + for (name, value) in &exchange.headers { + if name.eq_ignore_ascii_case("host") || name.eq_ignore_ascii_case("content-length") { + continue; + } + write!(request, "{name}: {value}\r\n") + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + } + write!(request, "content-length: 0\r\n\r\n") + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + Ok(request) +} + +/// Compose one HTTP/1.1 stored-request GET from the typed consumer exchange. +/// +/// # Errors +/// +/// Returns the same fail-closed errors as +/// [`InterpretationRunStoredRequestCliInvocation::validate`]. +pub fn compose_interpretation_run_stored_request_cli_http( + invocation: &InterpretationRunStoredRequestCliInvocation, +) -> Result { + invocation.validate()?; + let exchange = contextual_orchestrator_interpretation_run_stored_request_exchange( + &invocation.origin, + &invocation.idempotency_key, + )?; + loopback_http1_from_interpretation_run_stored_request_exchange(&exchange, &invocation.host) +} + +/// Dispatch one stored-request CLI invocation against an in-process listener. +/// +/// # Errors +/// +/// Returns fail-closed validation errors before the HTTP handler runs. +pub fn dispatch_interpretation_run_stored_request_cli( + service: &mut OrchestratorLiveService, + invocation: &InterpretationRunStoredRequestCliInvocation, +) -> Result { + let request = compose_interpretation_run_stored_request_cli_http(invocation)?; + Ok(service.handle_http_request(&request)) +} + +/// Execute one stored-request CLI invocation over loopback TCP. +/// +/// # Errors +/// +/// Returns fail-closed validation, transport, or response-framing errors. +pub fn execute_interpretation_run_stored_request_cli( + invocation: &InterpretationRunStoredRequestCliInvocation, +) -> Result { + let addr = require_loopback_host(&invocation.host)?; + let request = compose_interpretation_run_stored_request_cli_http(invocation)?; + let mut stream = TcpStream::connect(addr).map_err(|error| map_io_error(&error))?; + stream + .set_read_timeout(Some(CLI_IO_TIMEOUT)) + .map_err(|error| map_io_error(&error))?; + stream + .set_write_timeout(Some(CLI_IO_TIMEOUT)) + .map_err(|error| map_io_error(&error))?; + stream + .write_all(request.as_bytes()) + .map_err(|error| map_io_error(&error))?; + stream.flush().map_err(|error| map_io_error(&error))?; + let bytes = read_bounded(&mut stream, MAXIMUM_HTTP_RESPONSE_BYTES)?; + parse_http_response(&bytes) +} + +/// Filter CLI stdout so stored-request GET never prints scientific acceptance. +/// +/// # Errors +/// +/// Returns [`OrchestratorLiveError::InvalidWirePayload`] when a receipt carries +/// metric keys, evidence, causal scores, or +/// `tepp.scientific_acceptance.v1`, or when the identity does not match. +pub fn render_interpretation_run_stored_request_cli_stdout( + invocation: &InterpretationRunStoredRequestCliInvocation, + response: &OrchestratorLiveResponse, +) -> Result { + invocation.validate()?; + if response.body.is_empty() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + refuse_scientific_acceptance(&response.body)?; + refuse_metrics_on_interpretation_run_stored_request_payload(&response.body)?; + if response.status_code != 200 { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let stored = InterpretationRunRequest::from_json(&response.body)?; + if stored.idempotency_key() != invocation.idempotency_key { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + stored.to_json() +} + +fn refuse_scientific_acceptance(body: &str) -> Result<(), OrchestratorLiveError> { + if body.contains(SCIENTIFIC_ACCEPTANCE_SCHEMA) { + Err(OrchestratorLiveError::InvalidWirePayload) + } else { + Ok(()) + } +} + +fn parse_http_response(bytes: &[u8]) -> Result { + let text = std::str::from_utf8(bytes).map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + let (header_block, body) = text + .split_once("\r\n\r\n") + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + if header_block.len() > LIVE_HEADER_BYTE_LIMIT { + return Err(OrchestratorLiveError::LimitExceeded); + } + let mut lines = header_block.split("\r\n"); + let status_line = lines + .next() + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + let mut parts = status_line.split(' '); + if parts.next() != Some("HTTP/1.1") { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + let code = parts + .next() + .ok_or(OrchestratorLiveError::InvalidWirePayload)? + .parse::() + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?; + let reason_phrase = static_reason(code)?; + let mut content_length = None; + for (index, line) in lines.enumerate() { + if index >= LIVE_HEADER_COUNT_LIMIT { + return Err(OrchestratorLiveError::LimitExceeded); + } + let (name, value) = line + .split_once(':') + .ok_or(OrchestratorLiveError::InvalidWirePayload)?; + if name.eq_ignore_ascii_case("content-length") { + if content_length.is_some() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + content_length = Some( + value + .trim() + .parse::() + .map_err(|_| OrchestratorLiveError::InvalidWirePayload)?, + ); + } + } + let declared = content_length.ok_or(OrchestratorLiveError::InvalidWirePayload)?; + if declared > DEFAULT_INTERPRETATION_BYTE_LIMIT { + return Err(OrchestratorLiveError::LimitExceeded); + } + if declared != body.len() { + return Err(OrchestratorLiveError::InvalidWirePayload); + } + Ok(OrchestratorLiveResponse { + status_code: code, + reason_phrase, + body: body.to_owned(), + }) +} + +fn static_reason(code: u16) -> Result<&'static str, OrchestratorLiveError> { + match code { + 200 => Ok("OK"), + 202 => Ok("Accepted"), + 400 => Ok("Bad Request"), + 403 => Ok("Forbidden"), + 413 => Ok("Payload Too Large"), + 422 => Ok("Unprocessable Entity"), + _ => Err(OrchestratorLiveError::InvalidWirePayload), + } +} + +/// Read stdin leftover bytes on a non-terminal; retrieval GET admits empty. +/// +/// # Errors +/// +/// Returns [`OrchestratorLiveError::InvalidWirePayload`] when stdin cannot be +/// read and [`OrchestratorLiveError::LimitExceeded`] when leftover stdin +/// exceeds the interpretation-run wire limit. +pub fn read_interpretation_run_stored_request_cli_stdin( + stdin_is_terminal: bool, + mut stdin: impl Read, +) -> Result { + if stdin_is_terminal { + Ok(String::new()) + } else { + let bytes = read_bounded(&mut stdin, DEFAULT_INTERPRETATION_BYTE_LIMIT)?; + String::from_utf8(bytes).map_err(|_| OrchestratorLiveError::InvalidWirePayload) + } +} + +fn read_bounded( + reader: &mut impl Read, + maximum_bytes: usize, +) -> Result, OrchestratorLiveError> { + let mut bytes = Vec::new(); + reader + .take((maximum_bytes + 1) as u64) + .read_to_end(&mut bytes) + .map_err(|error| map_io_error(&error))?; + if bytes.len() > maximum_bytes { + return Err(OrchestratorLiveError::LimitExceeded); + } + Ok(bytes) +} + +#[cfg(test)] +mod tests { + use super::{ + compose_interpretation_run_stored_request_cli_http, + loopback_http1_from_interpretation_run_stored_request_exchange, + read_interpretation_run_stored_request_cli_stdin, InterpretationRunStoredRequestCliInvocation, + InterpretationRunStoredRequestCliVerb, + }; + use crate::interpretation_run_cli::CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE; + use crate::{ + contextual_orchestrator_interpretation_run_stored_request_exchange, OrchestratorLiveError, + }; + + const ORIGIN: &str = "https://tepp.example.test"; + + fn get_args() -> [&'static str; 9] { + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--consumer", + CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE, + "--idempotency-key", + "idem-a", + ] + } + + #[test] + fn from_args_mints_get_and_refuses_fail_closed_inputs() { + assert_eq!( + InterpretationRunStoredRequestCliVerb::parse("get").expect("get"), + InterpretationRunStoredRequestCliVerb::Get + ); + assert_eq!(InterpretationRunStoredRequestCliVerb::Get.as_str(), "get"); + assert_eq!( + InterpretationRunStoredRequestCliVerb::parse("list"), + Err(OrchestratorLiveError::InvalidWirePayload) + ); + let get = InterpretationRunStoredRequestCliInvocation::from_args(get_args(), "").expect("get"); + assert_eq!(get.verb, InterpretationRunStoredRequestCliVerb::Get); + let http = compose_interpretation_run_stored_request_cli_http(&get).expect("http"); + assert!(http.starts_with("GET /v1/interpretation-runs/idem-a/request HTTP/1.1")); + assert!(http.contains("tepp-consumer: contextual-orchestrator")); + assert!(http.contains("content-length: 0")); + assert!(!http.contains("idempotency-key:")); + assert!(!http.contains("authorization")); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "8.8.8.8:80", + "--origin", + ORIGIN, + "--idempotency-key", + "idem-a" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::AuthorizationDenied + ); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "localhost:18082", + "--origin", + ORIGIN, + "--idempotency-key", + "idem-a" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + "http://tepp.example.test", + "--idempotency-key", + "idem-a" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--idempotency-key", + "idem-a", + "--authorization", + "secret" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::AuthorizationDenied + ); + } + + #[test] + fn from_args_refuses_unpublished_body_pagination_and_non_get() { + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--consumer", + "naruon", + "--idempotency-key", + "idem-a" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args(get_args(), "{}").unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--idempotency-key", + "idem-a", + "--page-limit", + "1" + ], + "" + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + let leftover = + read_interpretation_run_stored_request_cli_stdin(false, std::io::Cursor::new(b"leftover")) + .expect("leftover"); + assert_eq!(leftover, "leftover"); + assert!( + read_interpretation_run_stored_request_cli_stdin(true, std::io::empty()) + .expect("tty") + .is_empty() + ); + let exchange = + contextual_orchestrator_interpretation_run_stored_request_exchange(ORIGIN, "idem-a") + .expect("exchange"); + let mut posted = exchange.clone(); + posted.method = "POST"; + assert_eq!( + loopback_http1_from_interpretation_run_stored_request_exchange(&posted, "127.0.0.1:18082") + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + } +} diff --git a/crates/orchestrator_live/src/lib.rs b/crates/orchestrator_live/src/lib.rs index b9aea0646..a9bdeb455 100644 --- a/crates/orchestrator_live/src/lib.rs +++ b/crates/orchestrator_live/src/lib.rs @@ -8,7 +8,8 @@ //! metric-free identities so operators do not guess idempotency keys. //! GET-by-id returns one of those identities without POST replay. //! `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored -//! create request without POST replay. +//! create request without POST replay. Published `tepp-interpretation-run-request` +//! mints that GET onto spawned `tepp-orchestrator-loopback` TCP. //! Table-access hosts, review/Copilot/GitHub credentials, and //! `COPILOT_GITHUB_TOKEN` fail closed. This crate does not implement TLS //! termination or call a model provider (ADR 0010; ADR 0011). The published @@ -21,6 +22,7 @@ mod http; mod interpretation_run_cli; mod interpretation_run_collection_http; mod interpretation_run_retrieval_http; +mod interpretation_run_stored_request_cli; mod interpretation_run_stored_request_http; mod mode; mod request; @@ -102,6 +104,22 @@ pub use interpretation_run_stored_request_http::is_interpretation_run_stored_req pub use interpretation_run_stored_request_http::refuse_metrics_on_interpretation_run_stored_request_payload; /// Typed GET exchange for interpretation-run stored-request retrieval. pub use interpretation_run_stored_request_http::InterpretationRunStoredRequestHttpExchange; +/// Compose HTTP/1.1 stored-request GET from a CLI invocation. +pub use interpretation_run_stored_request_cli::compose_interpretation_run_stored_request_cli_http; +/// Dispatch a stored-request CLI invocation against an in-process listener. +pub use interpretation_run_stored_request_cli::dispatch_interpretation_run_stored_request_cli; +/// Execute a stored-request CLI invocation over loopback TCP. +pub use interpretation_run_stored_request_cli::execute_interpretation_run_stored_request_cli; +/// Render a typed stored-request exchange onto a loopback HTTP/1.1 request. +pub use interpretation_run_stored_request_cli::loopback_http1_from_interpretation_run_stored_request_exchange; +/// Read leftover stdin for the stored-request CLI. +pub use interpretation_run_stored_request_cli::read_interpretation_run_stored_request_cli_stdin; +/// Filter stored-request CLI stdout so `scientific_authority` stays false. +pub use interpretation_run_stored_request_cli::render_interpretation_run_stored_request_cli_stdout; +/// Loopback stored-request CLI invocation. +pub use interpretation_run_stored_request_cli::InterpretationRunStoredRequestCliInvocation; +/// Loopback stored-request CLI verb. +pub use interpretation_run_stored_request_cli::InterpretationRunStoredRequestCliVerb; /// Closed ADR 0010 orchestration-mode vocabulary. pub use mode::OrchestrationMode; /// Accepted hypothetical interpretation-run response. diff --git a/crates/orchestrator_live/tests/interpretation_run_stored_request_cli_contract.rs b/crates/orchestrator_live/tests/interpretation_run_stored_request_cli_contract.rs new file mode 100644 index 000000000..f65ee0103 --- /dev/null +++ b/crates/orchestrator_live/tests/interpretation_run_stored_request_cli_contract.rs @@ -0,0 +1,146 @@ +//! Contract tests for `tepp-interpretation-run-request get`. + +use orchestrator_live::{ + compose_interpretation_run_cli_http, dispatch_interpretation_run_stored_request_cli, + execute_interpretation_run_stored_request_cli, render_interpretation_run_stored_request_cli_stdout, + InterpretationRunCliInvocation, InterpretationRunRequest, + InterpretationRunStoredRequestCliInvocation, OrchestrationMode, OrchestratorLiveError, + OrchestratorLiveResponse, OrchestratorLiveService, CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE, + INTERPRETATION_RUN_CONTRACT_VERSION, +}; + +const ORIGIN: &str = "https://tepp.example.test"; + +fn query_body(idem: &str) -> String { + InterpretationRunRequest::new( + INTERPRETATION_RUN_CONTRACT_VERSION, + idem, + "orch-tenant-demo", + "tepp-snapshot-demo-001", + "2026-08-01T00:00:00Z", + OrchestrationMode::Direct, + 2048, + vec!["span-001".into()], + false, + ) + .expect("request") + .to_json() + .expect("json") +} + +fn create_http(idem: &str) -> String { + let invocation = InterpretationRunCliInvocation::from_args( + [ + "create", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--consumer", + CONTEXTUAL_ORCHESTRATOR_CONSUMER_CODE, + ], + query_body(idem), + ) + .expect("create"); + compose_interpretation_run_cli_http(&invocation).expect("post") +} + +fn get_invocation(idem: &str) -> InterpretationRunStoredRequestCliInvocation { + InterpretationRunStoredRequestCliInvocation::from_args( + [ + "get", + "--host", + "127.0.0.1:18082", + "--origin", + ORIGIN, + "--idempotency-key", + idem, + ], + "", + ) + .expect("get") +} + +#[test] +fn dispatch_retrieves_stored_request_without_scientific_authority() { + let mut service = OrchestratorLiveService::new(); + assert_eq!( + service + .handle_http_request(&create_http("idem-a")) + .status_code, + 202 + ); + let got = dispatch_interpretation_run_stored_request_cli(&mut service, &get_invocation("idem-a")) + .expect("get"); + assert_eq!(got.status_code, 200, "{}", got.body); + let stdout = + render_interpretation_run_stored_request_cli_stdout(&get_invocation("idem-a"), &got) + .expect("out"); + assert!(!stdout.contains("tepp.scientific_acceptance.v1")); + assert!(!stdout.contains("rmse")); + assert!(!stdout.contains("causal_score")); + let stored = InterpretationRunRequest::from_json(&stdout).expect("stored"); + assert_eq!(stored.idempotency_key(), "idem-a"); + assert!(stdout.contains("\"scientific_authority\":false")); + assert_eq!( + dispatch_interpretation_run_stored_request_cli(&mut service, &get_invocation("missing")) + .expect("missing") + .status_code, + 400 + ); +} + +#[test] +fn render_refuses_metrics_schema_and_empty_bodies() { + let get = get_invocation("idem-a"); + assert_eq!( + render_interpretation_run_stored_request_cli_stdout( + &get, + &OrchestratorLiveResponse { + status_code: 200, + reason_phrase: "OK", + body: String::new(), + } + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + render_interpretation_run_stored_request_cli_stdout( + &get, + &OrchestratorLiveResponse { + status_code: 200, + reason_phrase: "OK", + body: r#"{"contract_version":1,"idempotency_key":"idem-a","tenant_workspace_id":"t","snapshot_id":"s","knowledge_cutoff":"k","orchestration_mode":"direct","compute_budget_tokens":8,"evidence_span_ids":["span-001"],"scientific_authority":false,"rmse":1.0}"#.into(), + } + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); + assert_eq!( + render_interpretation_run_stored_request_cli_stdout( + &get, + &OrchestratorLiveResponse { + status_code: 400, + reason_phrase: "Bad Request", + body: r#"{"error_code":"invalid_wire_payload"}"#.into(), + } + ) + .unwrap_err(), + OrchestratorLiveError::InvalidWirePayload + ); +} + +#[test] +fn execute_over_tcp_returns_missing_identity_as_invalid_wire() { + let mut service = OrchestratorLiveService::bind_loopback().expect("bind"); + let addr = service.local_addr().expect("addr"); + let handle = std::thread::spawn(move || { + drop(service.serve_one()); + }); + let mut invocation = get_invocation("idem-a"); + invocation.host = addr.to_string(); + let response = execute_interpretation_run_stored_request_cli(&invocation).expect("tcp"); + assert_eq!(response.status_code, 400, "{}", response.body); + handle.join().expect("join"); +} diff --git a/docs/API_CONTRACT.md b/docs/API_CONTRACT.md index 7d5705b9e..f9790f006 100644 --- a/docs/API_CONTRACT.md +++ b/docs/API_CONTRACT.md @@ -66,6 +66,7 @@ POST /v1/interpretation-runs GET /v1/interpretation-runs GET /v1/interpretation-runs/{idempotency_key} GET /v1/interpretation-runs/{idempotency_key}/request +Loopback `tepp-interpretation-run-request get` mints that stored-request GET onto spawned `tepp-orchestrator-loopback` TCP. POST /v1/analysis-runs POST /v1/temporal-context GET /v1/analysis-runs/{run_id} diff --git a/docs/TRACEABILITY.md b/docs/TRACEABILITY.md index 8b28b0cbb..f500fb679 100644 --- a/docs/TRACEABILITY.md +++ b/docs/TRACEABILITY.md @@ -110,6 +110,7 @@ The full APA 7th standards/literature register remains `docs/research/standards- | loopback contextual-orchestrator interpretation-run collection GET | ADR 0069; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs` on `tepp-orchestrator-loopback`; metric-free hypothetical identities; empty body; no `idempotency-key`; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | | loopback contextual-orchestrator interpretation-run GET-by-id | ADR 0071; ADR 0069; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs/{idempotency_key}` on `tepp-orchestrator-loopback`; metric-free hypothetical identity without POST replay; empty body; no pagination; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | | loopback contextual-orchestrator interpretation-run stored-request GET | ADR 0085; ADR 0071; ADR 0010/0011; API contract; RFC 9110 | `orchestrator_live` `GET /v1/interpretation-runs/{idempotency_key}/request` on `tepp-orchestrator-loopback`; returns stored create request; `scientific_authority` remains false; `tepp.scientific_acceptance.v1` never appears; does not infer causality; naruon and LineageWeave refused | active-PR | +| loopback contextual-orchestrator interpretation-run stored-request CLI | ADR 0086; ADR 0085; ADR 0010/0011; API contract; RFC 9110 | published `tepp-interpretation-run-request get` mints stored-request GET onto spawned `tepp-orchestrator-loopback` TCP; `scientific_authority` remains false; empty stdin admitted; naruon and LineageWeave refused | active-PR | | foundation validation / release-readiness ledger | ADR 0014; Test Strategy | PR #24 `docs/validation/temporal-event-foundation.md` on protected main | implemented-main | | scientific claim promotion separated from design/implementation/release | ADR 0014; ADR policy | `validation_core` exact-head promotion gates on this PR; documentation/CI/domain validation remain; full package/image release bundle remaining | partial | | CSAP/SOC 2/ISO/NIST assurance readiness | `docs/COMPLIANCE_READINESS.md`; research register | repository controls + future deployment evidence | accepted-target / deployment-owned | diff --git a/docs/adr/0086-interpretation-run-stored-request-cli.md b/docs/adr/0086-interpretation-run-stored-request-cli.md new file mode 100644 index 000000000..9db718b4d --- /dev/null +++ b/docs/adr/0086-interpretation-run-stored-request-cli.md @@ -0,0 +1,60 @@ +# ADR 0086 — Loopback interpretation-run stored-request CLI + +**Decision status:** Accepted +**Implementation maturity:** active-PR +**Date:** 2026-09-01 +**Supersedes:** None; complements ADR 0085. Does not re-open cancel lineages. +Does not supersede ADR 0014. Unique versus protected main; 0026–0085 occupied. + +## Context + +ADR 0085 publishes `GET /v1/interpretation-runs/{idempotency_key}/request`. +Operators still had no published binary that mints that GET onto spawned +`tepp-orchestrator-loopback` TCP. Duplicating stored-request GET (#453), +GET-by-id (#438), retrieval CLI (#439), collection GET/CLI, create CLI, +analysis-run stored-request CLI (#395), Leiden, or GAP-010 would collide with +live PRs. Cancel lineages stay closed. + +## Decision + +Publish `tepp-interpretation-run-request get` which mints +`contextual_orchestrator_interpretation_run_stored_request_exchange` onto +spawned loopback TCP. Empty stdin is admitted. Nonempty leftover stdin, public +bind, `localhost`, `http` origin, unpublished consumer, and credential flags +fail closed. `scientific_authority` remains false. +`tepp.scientific_acceptance.v1` never appears. + +## Alternatives considered + +1. Re-open cancel CLI — rejected. +2. Reuse `tepp-interpretation-run-get` — rejected; that is ADR 0072. +3. Dedicated stored-request binary — accepted. + +## Consequences + +CLI success is not measurement evidence and is not an ADR 0014 claim. + +## Failure and recovery + +Non-orchestrator consumers, nonempty leftover stdin, extra segments, slash/NUL, +missing keys, and metric keys fail closed. + +## Verification + +- `tepp-interpretation-run-request get` of an accepted run prints the stored + create request without RMSE/`tepp.scientific_acceptance.v1`; +- naruon, LineageWeave, public bind, `localhost`, `http` origin, leftover + stdin, and missing keys fail closed; +- Clippy `-D warnings`, `orchestrator_live` tests, rustdoc, and exact-head + review remain required. + +## Rollback and supersession + +Rollback removes the published binary; stored-request GET remains valid. A +superseding ADR is required to persist the registry, bind a public address, +re-open cancel, emit scientific-acceptance, open naruon or LineageWeave, add +GET to `NaruonLiveService`, or treat CLI success as an ADR 0014 claim. + +## Related authority + +ADR 0085, ADR 0071, ADR 0014, RFC 9110 (Fielding, Nottingham, & Reschke, 2022). diff --git a/docs/adr/README.md b/docs/adr/README.md index 519289f43..5fbc6f23d 100644 --- a/docs/adr/README.md +++ b/docs/adr/README.md @@ -34,6 +34,7 @@ Read [`ADR_POLICY.md`](ADR_POLICY.md) first. **Decision status and implementatio | [0069](0069-interpretation-run-collection-get.md) | Loopback `GET /v1/interpretation-runs` enumerates accepted hypothetical interpretation runs | Accepted | active-PR | Complements ADR 0010/0011/0064; does not supersede ADR 0014. Unique on this stack versus protected main (0026–0068 occupied). Does not infer causality. | | [0071](0071-interpretation-run-retrieval-get.md) | Loopback `GET /v1/interpretation-runs/{idempotency_key}` returns one accepted hypothetical identity | Accepted | active-PR | Complements ADR 0069; does not supersede ADR 0014. Unique on this interpretation stack versus protected main (0026–0070 occupied). Does not infer causality. | | [0085](0085-interpretation-run-stored-request-get.md) | Loopback interpretation-run stored-request GET | Accepted | active-PR | Complements ADR 0071; `GET /v1/interpretation-runs/{idempotency_key}/request` returns the stored create request. Unique versus protected main (0026–0084 occupied). Does not re-open cancel lineages. | +| [0086](0086-interpretation-run-stored-request-cli.md) | Loopback interpretation-run stored-request CLI | Accepted | active-PR | Complements ADR 0085; published `tepp-interpretation-run-request get`. Unique versus protected main (0026–0085 occupied). Does not re-open cancel lineages. | | [0023](0023-lineage-criterion-anchor-contract.md) | TEPP-owned Event Lineage criterion anchor | Accepted | active-PR | PR #237 publishes the strict accepted/rejected artifact and identities; estimator execution remains fail-closed future work. | | [0024](0024-independent-topic-importance-anchor.md) | Posterior topic-context producer contract | Accepted | contract-only active-PR | Strict DTO/schema only; the current estimator does not emit it. fast-mlsirm owns case-deletion influence. | | [0001](0001-rust-first-modular-msa.md) | Rust-first numerical core and CPU `f64` reference | Accepted | partial | ADR 0011 owns cross-service/MSA authority; 0001 retains numerical/backend authority. | diff --git a/docs/research/interpretation-run-stored-request-cli.md b/docs/research/interpretation-run-stored-request-cli.md new file mode 100644 index 000000000..fe096740f --- /dev/null +++ b/docs/research/interpretation-run-stored-request-cli.md @@ -0,0 +1,14 @@ +# Interpretation-run stored-request CLI (doctoring) + +`tepp-interpretation-run-request get` mints +`GET /v1/interpretation-runs/{idempotency_key}/request` onto spawned +`tepp-orchestrator-loopback` TCP. HTTP semantics follow RFC 9110 (Fielding, +Nottingham, & Reschke, 2022). Fail-closed unpublished consumers, leftover +stdin, public bind, `localhost`, `http` origin, credential flags, and +scientific-authority promotion are repository contract (ADR 0086; ADR 0014). + +`scientific_authority` remains false. `tepp.scientific_acceptance.v1` never +appears. CLI success is not a scientific claim. + +Does not re-open cancel lineages, GAP-010 Figma/export, persistence, Leiden, +or an ADR 0014 claim-promotion package.