diff --git a/AGENTS.md b/AGENTS.md index c82f0a49c..b2e674ecb 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -273,7 +273,7 @@ stops startup instead of leaving a healthy-looking partial schema, and application code must not compensate for a missing table. Period leftover pairs (ADR 0017 / 0018 / 0048 / 0049 / 0119 / 0158 / 0162 / -0163 / 0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309 / 0310 / 0311 / 0312 / 0313 / 0314 / 0315 / 0316 / 0317 / 0318 / 0319 / 0320 / 0321 / 0322 / 0323 / 0324 / 0325 / 0326 / 0327) are computed in `lineageweave/leftover_pairs.py` from the +0163 / 0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309 / 0310 / 0311 / 0312 / 0313 / 0314 / 0315 / 0316 / 0317 / 0318 / 0319 / 0320 / 0321 / 0322 / 0323 / 0324 / 0325 / 0326 / 0327 / 0328) are computed in `lineageweave/leftover_pairs.py` from the residual after a real GRM/GPCM score, never invented. Distances are Euclidean on the two-dimensional Gabriel leftover map; missing cells stay out of the factorization. Closest and farthest post–criterion pairs @@ -683,6 +683,13 @@ axis tick caption. Distinct accessible name of leftover-map axis share. Leftover-map graphic leftover-map axis ticks never name leftover-map axis share. Rank-0 unused axes still name leftover-map graphic leftover-map axis tick `σ 0.00`. Do not invent leftover-map singular values from leftover-map axis share. +ADR 0328 captions leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map +singular values `σ_k` when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map +axis tick caption. Distinct accessible name +`leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}`. Singular value omits independently +of leftover-map axis share. Leftover-map comparison graphic leftover-map axis ticks never name leftover-map +axis share. Rank-0 unused axes still name leftover-map comparison graphic leftover-map axis tick +`σ 0.00`. Do not invent leftover-map singular values from leftover-map axis share. When `R`, `R̂`, `U`, `x`, `s`, and `e` are finite, `e + s + x = 1`. When `Y`, `E`, and `R` are finite, `Y − E = R`. When `R`, `R̂`, and `U` are @@ -799,6 +806,9 @@ singular values `σ_k` when leftoverMapComparePlotAxisBadge returns a usable lef Leftover-map graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share (ADR 0327) captions leftover-map graphic leftover-map axis ticks with persisted leftover-map singular values `σ_k` when leftoverMapPlotTickAxisBadge returns a usable leftover-map axis tick caption. +Leftover-map comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +(ADR 0328) captions leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map +singular values `σ_k` when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map axis tick caption. Item complete-case coverage (ADR 0282) captions the leftover-map graphic with how many scored criteria entered the map. Item complete-case coverage on the pair list (ADR 0285) diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index edd4f3eec..07434cc54 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -764,6 +764,9 @@ axis caption. ADR 0327 captions leftover-map graphic leftover-map axis ticks with persisted leftover-map singular values `σ_k` when leftoverMapPlotTickAxisBadge returns a usable leftover-map axis tick caption independently of leftover-map axis share. +ADR 0328 captions leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map +singular values `σ_k` when leftoverMapComparePlotTickAxisBadge returns a usable leftover-map +axis tick caption independently of leftover-map axis share. Click a post marker or a pair button opens that post. Those ADRs are the normative mathematical, storage, and display contracts. Leftover-map axis share @@ -821,7 +824,8 @@ graphic-display axes (ADR 0324), leftover-map singular values on leftover-axis report badges independently of leftover-map axis share (ADR 0325), leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge (ADR 0326), leftover-map graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share -(ADR 0327); +(ADR 0327), leftover-map comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +(ADR 0328); `POST .../rebuild` scores every grouping kind (post_admin). `make seed` folds A-100/B-200 Event Lineage fixtures (and the Riverbend calendar post) that already have constructed IRT cells into the same shared diff --git a/CHANGELOG.d/2.85.0-leftover-map-compare-plot-tick-axis-badge.md b/CHANGELOG.d/2.85.0-leftover-map-compare-plot-tick-axis-badge.md new file mode 100644 index 000000000..9628626a4 --- /dev/null +++ b/CHANGELOG.d/2.85.0-leftover-map-compare-plot-tick-axis-badge.md @@ -0,0 +1,25 @@ +## 2.85.0 — Leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share + +- Caption leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map + singular values `σ_k` through leftoverMapComparePlotTickAxisBadge independently of leftover-map + axis share (ADR 0328). After `make seed`, leftover-map comparison graphic leftover-map axis + ticks name persisted leftover-map singular values when leftoverMapComparePlotTickAxisBadge + returns a usable leftover-map axis tick `σ` caption even when leftover-map axis + share is omitted; click a leftover pair opens that post. A missing, non-finite, + or negative singular value omits that `σ` tick caption and keeps + `leftover map comparison graphic leftover-map axis {k} tick {value}`. Rank-0 unused + axes still name `σ 0.00`. Leftover-map comparison graphic leftover-map axis ticks stay + `leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}` when + `σ_k` is finite so they stay distinct from leftover-map graphic leftover-map axis ticks + `leftover-map axis {k} tick {value} σ {singular}`, from leftover-map graphic leftover-map + axis `leftover-map axis {k} σ {value}`, from leftover-axis + `leftover axis {k} σ {value}`, from comparison leftover-axis + `leftover map comparison leftover axis {k} σ {value}`, from comparison graphic leftover-map + axis `leftover map comparison graphic leftover-map axis {k} σ {value}`, and from comparison + graphic leftover-map axis ticks + `leftover map comparison graphic leftover-map axis {k} tick {value}`. Do not invent + `σ_k` from leftover-map axis share. Do not invent leftover-map axis share from + `σ_k`. Leftover-map comparison graphic leftover-map axis ticks never name leftover-map axis + share. This increment does not change leftover-map graphic leftover-map axis ticks. + A finite negative leftover is shown, never clamped. Never invent a leftover score. + Never invent a theta. No new columns. diff --git a/CHANGELOG.md b/CHANGELOG.md index 90e283b3e..4c2396b72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,31 @@ All notable changes to this project are documented here. Format follows ### Added +- Period leftover pairs now caption leftover-map comparison graphic leftover-map + axis ticks with persisted leftover-map singular values `σ_k` through + leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share + (ADR 0328 / v2.85.0). After `make seed`, leftover-map comparison graphic leftover-map + axis ticks name persisted leftover-map singular values when leftoverMapComparePlotTickAxisBadge + returns a usable leftover-map axis tick `σ` caption even when leftover-map axis share + is omitted; click a leftover pair opens that post. A missing, non-finite, or + negative singular value omits that `σ` tick caption and keeps + `leftover map comparison graphic leftover-map axis {k} tick {value}`. Rank-0 unused + axes still name `σ 0.00`. Leftover-map comparison graphic leftover-map axis ticks stay + `leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}` when + `σ_k` is finite so they stay distinct from leftover-map graphic leftover-map axis ticks + `leftover-map axis {k} tick {value} σ {singular}`, from leftover-map graphic leftover-map + axis `leftover-map axis {k} σ {value}`, from leftover-axis + `leftover axis {k} σ {value}`, from comparison leftover-axis + `leftover map comparison leftover axis {k} σ {value}`, from comparison graphic leftover-map + axis `leftover map comparison graphic leftover-map axis {k} σ {value}`, and from comparison + graphic leftover-map axis ticks + `leftover map comparison graphic leftover-map axis {k} tick {value}`. Do not invent + `σ_k` from leftover-map axis share. Do not invent leftover-map axis share from + `σ_k`. Leftover-map comparison graphic leftover-map axis ticks never name leftover-map + axis share. This increment does not change leftover-map graphic leftover-map axis + ticks. A finite negative leftover is shown, never clamped. Never invent a leftover + score or a theta. No new columns. + - Period leftover pairs now caption leftover-map graphic leftover-map axis ticks with persisted leftover-map singular values `σ_k` through leftoverMapPlotTickAxisBadge independently of leftover-map axis share (ADR 0327 / v2.84.0). After `make seed`, diff --git a/CLAUDE.md b/CLAUDE.md index ff52172c1..9c94ffc03 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -49,7 +49,7 @@ cutoff. Global Ask optional `knowledge_cutoff` uses the same cover Create/start endpoint rules (ADR 0017 / 0021), tie-vs-miss similarity (ADR 0026), R&R catalog ids (ADR 0019 / 0027), leftover pairs -(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309 / 0310 / 0311 / 0312 / 0313 / 0314 / 0315 / 0316 / 0317 / 0318 / 0319 / 0320 / 0321 / 0322 / 0323 / 0324 / 0325 / 0326 / 0327), occupational construct catalog search +(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309 / 0310 / 0311 / 0312 / 0313 / 0314 / 0315 / 0316 / 0317 / 0318 / 0319 / 0320 / 0321 / 0322 / 0323 / 0324 / 0325 / 0326 / 0327 / 0328), occupational construct catalog search (ADR 0257), the text-channel embedding swap and cosine clamp (ADR 0190), per-edge channel-score persistence (ADR 0195), token-backed status notices (ADR 0220), diff --git a/docs/adr/0148-leftover-map-axis-share.md b/docs/adr/0148-leftover-map-axis-share.md index 315ef199d..7b309040d 100644 --- a/docs/adr/0148-leftover-map-axis-share.md +++ b/docs/adr/0148-leftover-map-axis-share.md @@ -15,7 +15,9 @@ [ADR 0326](0326-leftover-map-compare-plot-axis-badge.md) (leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge); [ADR 0327](0327-leftover-map-plot-tick-axis-badge.md) -(leftover-map graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share) +(leftover-map graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share); +[ADR 0328](0328-leftover-map-compare-plot-tick-axis-badge.md) +(leftover-map comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share) ## Context diff --git a/docs/adr/0320-leftover-map-compare-plot-ticks.md b/docs/adr/0320-leftover-map-compare-plot-ticks.md index 0ead801f4..4742ecf1c 100644 --- a/docs/adr/0320-leftover-map-compare-plot-ticks.md +++ b/docs/adr/0320-leftover-map-compare-plot-ticks.md @@ -99,6 +99,9 @@ and distance are finite, `R̂ = ξ · ζ` and `d = ‖ξ − ζ‖`. ## Related Independent of leftover-map singular values on leftover-axis report badges. +Independent of leftover-map comparison graphic leftover-map axis tick leftover-map +singular values independently of leftover-map axis share +([ADR 0328](0328-leftover-map-compare-plot-tick-axis-badge.md)). ## References diff --git a/docs/adr/0326-leftover-map-compare-plot-axis-badge.md b/docs/adr/0326-leftover-map-compare-plot-axis-badge.md index 93c352492..d6f601a24 100644 --- a/docs/adr/0326-leftover-map-compare-plot-axis-badge.md +++ b/docs/adr/0326-leftover-map-compare-plot-axis-badge.md @@ -119,7 +119,9 @@ singular values on the grouping comparison leftover-map graphic that still inline σ and share ([ADR 0321](0321-leftover-map-compare-plot-singular.md)). Independent of leftover-map graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share -([ADR 0327](0327-leftover-map-plot-tick-axis-badge.md)). +([ADR 0327](0327-leftover-map-plot-tick-axis-badge.md)). Independent of leftover-map +comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +([ADR 0328](0328-leftover-map-compare-plot-tick-axis-badge.md)). ## References diff --git a/docs/adr/0327-leftover-map-plot-tick-axis-badge.md b/docs/adr/0327-leftover-map-plot-tick-axis-badge.md index b2d570c69..f0bd6c0a5 100644 --- a/docs/adr/0327-leftover-map-plot-tick-axis-badge.md +++ b/docs/adr/0327-leftover-map-plot-tick-axis-badge.md @@ -76,7 +76,10 @@ leftover-map graphic leftover-map axis tick `σ` caption. This increment does not change leftover-map comparison graphic leftover-map axis ticks. Those comparison graphic leftover-map axis ticks stay -`leftover map comparison graphic leftover-map axis {axis} tick {value}` (ADR 0320). +`leftover map comparison graphic leftover-map axis {axis} tick {value}` (ADR 0320) +until leftover-map comparison graphic leftover-map axis tick leftover-map singular +values independently of leftover-map axis share +([ADR 0328](0328-leftover-map-compare-plot-tick-axis-badge.md)). This increment does not persist leftover-map inner product, cosine, or length. Do not add SQL. Do not edit shipped migrations. Do not invent a leftover @@ -105,7 +108,9 @@ singular values on leftover-map graphic-display axes singular values on leftover-axis report badges independently of leftover-map axis share ([ADR 0325](0325-leftover-map-axis-singular-only.md)). Independent of leftover-map coordinate ticks on the grouping comparison leftover-map graphic -([ADR 0320](0320-leftover-map-compare-plot-ticks.md)). +([ADR 0320](0320-leftover-map-compare-plot-ticks.md)). Independent of leftover-map +comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +([ADR 0328](0328-leftover-map-compare-plot-tick-axis-badge.md)). ## References diff --git a/docs/adr/0328-leftover-map-compare-plot-tick-axis-badge.md b/docs/adr/0328-leftover-map-compare-plot-tick-axis-badge.md new file mode 100644 index 000000000..537e91917 --- /dev/null +++ b/docs/adr/0328-leftover-map-compare-plot-tick-axis-badge.md @@ -0,0 +1,126 @@ +# ADR 0328 — Name leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share + +**Decision status:** Accepted +**Date:** 2026-08-31 + +Amends leftover-map coordinate ticks on the grouping comparison leftover-map graphic +([ADR 0320](0320-leftover-map-compare-plot-ticks.md)), leftover-map comparison graphic +leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge +([ADR 0326](0326-leftover-map-compare-plot-axis-badge.md)), leftover-map axis share +persistence ([ADR 0148](0148-leftover-map-axis-share.md)). Independent of leftover-map +graphic leftover-map axis tick leftover-map singular values independently of leftover-map +axis share ([ADR 0327](0327-leftover-map-plot-tick-axis-badge.md)), leftover-map singular +values on leftover-map graphic-display axes +([ADR 0324](0324-leftover-map-plot-axis-singular.md)), leftover-map singular values on +leftover-axis report badges independently of leftover-map axis share +([ADR 0325](0325-leftover-map-axis-singular-only.md)). + +## Context + +ADR 0148 already persists leftover-map singular values `σ_k` and leftover-map +axis share `σ_k² / Σ_j σ_j²`. ADR 0320 already ticks leftover-map comparison +graphic leftover-map axes at persisted `ξ` / `ζ` projections as +`leftover map comparison graphic leftover-map axis {k} tick {value}`. ADR 0326 +already captions leftover-map comparison graphic-display leftover-map axes with +`σ_k` through leftoverMapComparePlotAxisBadge. ADR 0327 already captions leftover-map +graphic leftover-map axis ticks with `σ_k` through leftoverMapPlotTickAxisBadge. +Those leftover-map comparison graphic leftover-map axis ticks still omit `σ_k`, so a +buyer who reads leftover-map comparison graphic leftover-map axis ticks can treat leftover-map +coordinate ticks or leftover-map axis share as leftover-map structure without a +next action. A missing, non-finite, or negative singular value is not a leftover +score and must omit independently of leftover-map axis share. Rank-0 unused axes +still persist `σ_k = 0`. A finite negative leftover is shown, never clamped. Do +not invent `σ_k` from leftover-map axis share. Do not invent leftover-map axis +share from `σ_k`. Leftover-map comparison graphic leftover-map axis ticks never name leftover-map +axis share. + +This increment names leftover-map comparison graphic leftover-map axis ticks leftover-map +singular values as leftoverMapComparePlotTickAxisBadge, matching leftoverMapPlotTickAxisBadge, +leftoverMapComparePlotAxisBadge, leftoverMapPlotAxisBadge, leftoverMapCompareAxisBadge, and leftoverMapAxisBadge. +Leftover-map comparison graphic leftover-map axis ticks stay +`leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}` when `σ_k` is finite so they stay +distinct from leftover-map graphic leftover-map axis ticks +`leftover-map axis {k} tick {value} σ {singular}` (ADR 0327), from leftover-map graphic leftover-map axis +`leftover-map axis {k} σ {value}` (ADR 0324), from leftover-axis `leftover axis {k} σ {value}` +(ADR 0325), from comparison leftover-axis `leftover map comparison leftover axis {k} σ {value}` +(ADR 0323), from comparison graphic leftover-map axis +`leftover map comparison graphic leftover-map axis {k} σ {value}` (ADR 0326), and from comparison graphic leftover-map +axis ticks `leftover map comparison graphic leftover-map axis {k} tick {value}` (ADR 0320). +It does not add columns. Do not invent a leftover score. Do not invent a theta. + +This protected increment uses **0328** so it does not collide with leftover-map +graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +(0327), leftover-map comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge +(0326), leftover-map singular values on leftover-axis report badges independently of +leftover-map axis share (0325), leftover-map singular values on leftover-map graphic-display +axes (0324), leftover-map coordinate ticks on the grouping comparison leftover-map graphic +(0320), leftover-map axis share persistence (0148), or the dashboard stacks. + +## Decision + +On leftover-map comparison graphic leftover-map axis ticks, caption leftover-map axis `k` +with persisted leftover-map singular value `σ_k` when leftoverMapComparePlotTickAxisBadge +returns a usable leftover-map axis tick caption that includes that singular value. +Share and singular value omit independently through that helper, and leftover-map +axis share is never named on leftover-map comparison graphic leftover-map axis ticks: no `σ_k` +keeps `leftover map comparison graphic leftover-map axis {k} tick {value}`; `σ_k` only is +`leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular}`. A missing, non-finite, or +negative singular value omits that `σ` tick caption and keeps a usable leftover-map +comparison graphic leftover-map axis tick coordinate caption. Rank-0 unused axes still name +`σ 0.00`. Click a post marker to open that post. Criterion markers are not post +buttons. + +Leftover-map comparison graphic leftover-map axis tick leftover-map singular values omit +independently of leftover-map graphic leftover-map axis tick leftover-map singular values, +leftover-map comparison graphic leftover-map axis singular values, leftover-map graphic-display leftover-map axis +singular values, leftover-axis report badge leftover-map singular values, and leftover-map comparison leftover-axis +singular values. A missing leftover-map axis share omits leftover-map axis share and keeps a usable +leftover-map comparison graphic leftover-map axis tick `σ` caption. + +This increment does not change leftover-map graphic leftover-map axis ticks. Those leftover-map +graphic leftover-map axis ticks stay `leftover-map axis {axis} tick {value} σ {singular}` +(ADR 0327). This increment does not persist leftover-map inner product, cosine, or length. + +Do not add SQL. Do not edit shipped migrations. Do not invent a leftover +score. Do not invent a theta. + +## Consequences + +After `make seed`, leftover-map comparison graphic leftover-map axis ticks name persisted +leftover-map singular values when leftoverMapComparePlotTickAxisBadge returns a usable +leftover-map axis tick `σ` caption even when leftover-map axis share is omitted; +click a leftover pair opens that post. Hidden posts stay hidden. Rank-0 unused +axes still name leftover-map comparison graphic leftover-map axis tick `σ 0.00`. Leftover-map +graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share +(ADR 0327), leftover-map comparison graphic leftover-map axis leftover-map singular values (ADR 0326), leftover-map +graphic-display leftover-map singular values (ADR 0324), leftover-axis report badge +leftover-map singular values independently of leftover-map axis share (ADR 0325), +and grouping comparison leftover-map graphic leftover-map axis ticks (ADR 0320) +remain. + +## Related + +Independent of leftover-map graphic leftover-map axis tick leftover-map singular values +independently of leftover-map axis share +([ADR 0327](0327-leftover-map-plot-tick-axis-badge.md)). Independent of leftover-map +comparison graphic leftover-map axis leftover-map singular values as leftoverMapComparePlotAxisBadge +([ADR 0326](0326-leftover-map-compare-plot-axis-badge.md)). Independent of leftover-map +singular values on leftover-map graphic-display axes +([ADR 0324](0324-leftover-map-plot-axis-singular.md)). Independent of leftover-map +singular values on leftover-axis report badges independently of leftover-map axis +share ([ADR 0325](0325-leftover-map-axis-singular-only.md)). Independent of leftover-map +coordinate ticks on the grouping comparison leftover-map graphic +([ADR 0320](0320-leftover-map-compare-plot-ticks.md)). + +## References + +Gabriel, K. R. (1971). The biplot graphic display of matrices with +application to principal component analysis. *Biometrika, 58*(3), +453–467. https://doi.org/10.1093/biomet/58.3.453 + +Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping +unobserved item–respondent interactions: A latent space item response +model with interaction map. *Psychometrika, 86*(2), 378–403. +https://doi.org/10.1007/s11336-021-09762-5 +(LSIRM interaction `−γ‖ξ_j − ζ_i‖` after main effects +`α_j − β_i`; typically `p = 2` for the interaction map.) diff --git a/docs/product-technical-gap-baseline.md b/docs/product-technical-gap-baseline.md index 227ea53ca..1a80939ce 100644 --- a/docs/product-technical-gap-baseline.md +++ b/docs/product-technical-gap-baseline.md @@ -1,5 +1,26 @@ # Product & Technical Gap Baseline +> Exact-head loop overlay: 2026-08-31 12:20 KST. Protected `main` is +> `cb187cadee5fb6c46d8a944815ccc154a1e028d1`. Writes work. Do not +> self-approve. #868 leftover-map singular values on leftover-map graphic leftover-map +> axis ticks independently of leftover-map axis share (v2.84.0 / ADR 0327) is +> `5218a5c`, stacked on #867 @ `cf7bb55`. Independent APPROVE is missing. Devin +> Review is COMMENTED, not APPROVE. Next buyer increment on this cycle: leftover-map +> comparison graphic leftover-map axis ticks naming persisted leftover-map singular +> values independently of leftover-map axis share (ADR 0328 / v2.85.0) delivered +> locally on `feat/leftover-map-compare-plot-tick-axis-badge-v2850`. Caption persisted leftover-map +> singular values `σ_k` on leftover-map comparison graphic leftover-map axis ticks when +> leftoverMapComparePlotTickAxisBadge returns a usable leftover-map axis tick `σ` +> caption. Distinct accessible name `leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}`. +> Rank-0 unused axes still name `σ 0.00`. Singular value omits independently of +> leftover-map axis share. Leftover-map comparison graphic leftover-map axis ticks never name +> leftover-map axis share. Do not invent `σ_k` from leftover-map axis share. Do not +> invent leftover-map axis share from `σ_k`. Do not persist leftover-map inner +> product, cosine, or length. Do not change leftover-map graphic leftover-map +> axis ticks this increment. Stack onto #868. Leave open for independent review. Do +> not squash-merge. Do not self-approve. Issues #79 and #87 stay open. Do not merge +> #808 without independent APPROVE. Never self-approve. + > Exact-head loop overlay: 2026-08-31 12:20 KST. Protected `main` is > `cb187cadee5fb6c46d8a944815ccc154a1e028d1`. Writes work. Do not > self-approve. #867 leftover-map comparison graphic leftover-map axis leftover-map diff --git a/frontend/package.json b/frontend/package.json index 68ff7eed2..e847e1ee5 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,7 +1,7 @@ { "name": "frontend", "private": true, - "version": "2.84.0", + "version": "2.85.0", "type": "module", "scripts": { "dev": "vite", diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx index b1c232ab8..b2704c933 100644 --- a/frontend/src/App.test.tsx +++ b/frontend/src/App.test.tsx @@ -4699,7 +4699,7 @@ describe("App, authenticated", () => { ).not.toBeInTheDocument(); expect( within(screen.getByLabelText("Grouping comparison")).getByLabelText( - "leftover map comparison graphic leftover-map axis 1 tick +0.50", + "leftover map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84", ), ).toBeInTheDocument(); expect( diff --git a/frontend/src/components/LeftoverMapPlot.test.tsx b/frontend/src/components/LeftoverMapPlot.test.tsx index 4ab720991..530639f68 100644 --- a/frontend/src/components/LeftoverMapPlot.test.tsx +++ b/frontend/src/components/LeftoverMapPlot.test.tsx @@ -2695,15 +2695,19 @@ describe("LeftoverMapPlot", () => { />, ); expect( - screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50"), + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84"), ).toBeInTheDocument(); expect( - screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick −0.02"), + screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick −0.02 σ 0.86"), ).toBeInTheDocument(); expect( - screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00"), + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00 σ 1.84"), ).toBeInTheDocument(); + expect( + screen.queryByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50"), + ).not.toBeInTheDocument(); expect(screen.queryByLabelText("leftover-map axis 1 tick +0.50")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("leftover-map axis 1 tick +0.50 σ 1.84")).not.toBeInTheDocument(); expect(screen.queryByLabelText("leftover-map axis 2 tick −0.02")).not.toBeInTheDocument(); expect(screen.queryByLabelText("leftover-map axis 1 tick 0.00")).not.toBeInTheDocument(); expect( @@ -2755,7 +2759,7 @@ describe("LeftoverMapPlot", () => { />, ); expect( - screen.getAllByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00").length, + screen.getAllByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00 σ 0.00").length, ).toBeGreaterThan(0); expect( screen.queryByLabelText("leftover map comparison graphic leftover-map axis 1 tick +1.00"), @@ -2811,13 +2815,14 @@ describe("LeftoverMapPlot", () => { />, ); expect( - screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00"), + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00 σ 0.00"), ).toBeInTheDocument(); expect( - screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick 0.00"), + screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick 0.00 σ 0.00"), ).toBeInTheDocument(); expect(screen.queryByLabelText("leftover-map axis 1 tick 0.00")).not.toBeInTheDocument(); expect(screen.queryByLabelText("leftover-map axis 2 tick 0.00")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("leftover-map axis 1 tick 0.00 σ 0.00")).not.toBeInTheDocument(); expect( screen.getByLabelText("leftover map comparison graphic leftover-map rank rank 0"), ).toHaveTextContent("rank 0"); @@ -2826,4 +2831,58 @@ describe("LeftoverMapPlot", () => { ).toHaveTextContent("E 0.00"); expect(screen.getByText("leftover map comparison graphic leftover-map axis 1 σ 0.00 (0%)")).toBeInTheDocument(); }); + + it("captions leftover-map comparison graphic leftover-map axis ticks with leftover-map singular values independently of leftover-map axis share", () => { + render( + , + ); + expect( + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84"), + ).toBeInTheDocument(); + expect( + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick 0.00 σ 1.84"), + ).toBeInTheDocument(); + expect( + screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick −0.02"), + ).toBeInTheDocument(); + expect( + screen.queryByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50"), + ).not.toBeInTheDocument(); + expect(screen.queryByLabelText("leftover-map axis 1 tick +0.50 σ 1.84")).not.toBeInTheDocument(); + expect( + screen.queryByText(/leftover map comparison graphic leftover-map axis 1 tick \+0\.50 \(82%\)/), + ).not.toBeInTheDocument(); + }); + + it("omits leftover-map comparison graphic leftover-map axis tick leftover-map singular values independently of leftover-map axis share", () => { + render( + , + ); + expect( + screen.getByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50"), + ).toBeInTheDocument(); + expect( + screen.getByLabelText("leftover map comparison graphic leftover-map axis 2 tick −0.02"), + ).toBeInTheDocument(); + expect( + screen.queryByLabelText("leftover map comparison graphic leftover-map axis 1 tick +0.50 σ 1.84"), + ).not.toBeInTheDocument(); + expect(screen.getByText("leftover map comparison axis 1 (82%)")).toBeInTheDocument(); + expect(screen.getByText("leftover map comparison axis 2 (18%)")).toBeInTheDocument(); + }); }); diff --git a/frontend/src/components/LeftoverMapPlot.tsx b/frontend/src/components/LeftoverMapPlot.tsx index 0c97ab533..9e862e0cc 100644 --- a/frontend/src/components/LeftoverMapPlot.tsx +++ b/frontend/src/components/LeftoverMapPlot.tsx @@ -26,6 +26,7 @@ import { } from "../leftoverMapPlotAxisShare"; import { leftoverMapComparePlotAxisBadge, + leftoverMapComparePlotTickAxisBadge, leftoverMapPlotAxisBadge, leftoverMapPlotTickAxisBadge, leftoverSingularForAxis, @@ -46,7 +47,6 @@ import { LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_EXPECTED, LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_RANK, LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_DISTANCE, - LEFTOVER_MAP_COMPARE_PLOT_TICK, LEFTOVER_MAP_PLOT_CAPTION, LEFTOVER_MAP_PLOT_POST_ACTION, LEFTOVER_MAP_PLOT_SEGMENT_CROSS_SHARE, @@ -104,10 +104,11 @@ function leftoverMapPlotTickText( leftoverMapAxes: LeftoverMapAxis[] | undefined, variant: LeftoverMapPlotVariant, ): string { + const leftoverSingular = leftoverSingularForAxis(leftoverMapAxes, axisIndex); if (variant === "comparison") { - return tf(LEFTOVER_MAP_COMPARE_PLOT_TICK, { axis: axisIndex, value: tickLabel }); + const badge = leftoverMapComparePlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); + return tf(badge.key, badge.values); } - const leftoverSingular = leftoverSingularForAxis(leftoverMapAxes, axisIndex); const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); return tf(badge.key, badge.values); } @@ -214,6 +215,9 @@ function leftoverMapPlotTickText( * ADR 0327 fail-closes leftover-map graphic leftover-map axis ticks leftover-map * singular values through leftoverMapPlotTickAxisBadge independently of leftover-map * axis share. + * ADR 0328 fail-closes leftover-map comparison graphic leftover-map axis ticks leftover-map + * singular values through leftoverMapComparePlotTickAxisBadge independently of leftover-map + * axis share. * Never invent a leftover score. */ export function LeftoverMapPlot({ diff --git a/frontend/src/i18n.test.ts b/frontend/src/i18n.test.ts index 9df575c21..dd86474dd 100644 --- a/frontend/src/i18n.test.ts +++ b/frontend/src/i18n.test.ts @@ -110,6 +110,7 @@ describe("i18n", () => { "Leftover map comparison rank", "leftover map comparison graphic leftover-map distance {label}", "leftover map comparison graphic leftover-map axis {axis} tick {value}", + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}", "leftover map comparison graphic leftover-map axis {axis} σ {value}", "leftover map comparison graphic leftover-map axis {axis} σ {value} ({share}%)", "leftover map comparison leftover axis {axis} σ {value}", @@ -700,6 +701,25 @@ describe("i18n", () => { }, ); + it.each([ + ["ko", "잔여 지도 비교 그림 축 1 눈금 +0.50 σ 1.84"], + ["zh", "残差地图比较图形轴 1 刻度 +0.50 σ 1.84"], + ["ja", "残差マップの比較図軸 1 目盛 +0.50 σ 1.84"], + ["vi", "vạch trục đồ họa so sánh bản đồ phần dư 1 +0.50 σ 1.84"], + ] as const)( + "formats leftover map comparison graphic leftover-map axis tick singular values in %s", + (locale, expected) => { + setLocale(locale); + expect( + tf("leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}", { + axis: 1, + value: "+0.50", + singular: "1.84", + }), + ).toBe(expected); + }, + ); + it.each([ ["ko", "잔여 지도 비교 그림 축 1 σ 1.84"], ["zh", "残差地图比较图形轴 1 σ 1.84"], diff --git a/frontend/src/i18n.ts b/frontend/src/i18n.ts index cd7623eed..7ab06a290 100644 --- a/frontend/src/i18n.ts +++ b/frontend/src/i18n.ts @@ -297,6 +297,8 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison rank": "잔여 지도 비교 순위", "leftover map comparison graphic leftover-map distance {label}": "잔여 지도 비교 그림 거리 {label}", "leftover map comparison graphic leftover-map axis {axis} tick {value}": "잔여 지도 비교 그림 축 {axis} 눈금 {value}", + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}": + "잔여 지도 비교 그림 축 {axis} 눈금 {value} σ {singular}", "leftover map comparison graphic leftover-map axis {axis} σ {value}": "잔여 지도 비교 그림 축 {axis} σ {value}", "leftover map comparison graphic leftover-map axis {axis} σ {value} ({share}%)": "잔여 지도 비교 그림 축 {axis} σ {value} ({share}%)", @@ -955,6 +957,8 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison rank": "残差地图比较秩", "leftover map comparison graphic leftover-map distance {label}": "残差地图比较图形距离 {label}", "leftover map comparison graphic leftover-map axis {axis} tick {value}": "残差地图比较图形轴 {axis} 刻度 {value}", + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}": + "残差地图比较图形轴 {axis} 刻度 {value} σ {singular}", "leftover map comparison graphic leftover-map axis {axis} σ {value}": "残差地图比较图形轴 {axis} σ {value}", "leftover map comparison graphic leftover-map axis {axis} σ {value} ({share}%)": "残差地图比较图形轴 {axis} σ {value} ({share}%)", @@ -1634,6 +1638,8 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison rank": "残差マップの比較階数", "leftover map comparison graphic leftover-map distance {label}": "残差マップの比較図距離 {label}", "leftover map comparison graphic leftover-map axis {axis} tick {value}": "残差マップの比較図軸 {axis} 目盛 {value}", + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}": + "残差マップの比較図軸 {axis} 目盛 {value} σ {singular}", "leftover map comparison graphic leftover-map axis {axis} σ {value}": "残差マップの比較図軸 {axis} σ {value}", "leftover map comparison graphic leftover-map axis {axis} σ {value} ({share}%)": "残差マップの比較図軸 {axis} σ {value} ({share}%)", @@ -2292,6 +2298,8 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison rank": "Hạng so sánh bản đồ phần dư", "leftover map comparison graphic leftover-map distance {label}": "khoảng cách đồ họa so sánh bản đồ phần dư {label}", "leftover map comparison graphic leftover-map axis {axis} tick {value}": "vạch trục đồ họa so sánh bản đồ phần dư {axis} {value}", + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}": + "vạch trục đồ họa so sánh bản đồ phần dư {axis} {value} σ {singular}", "leftover map comparison graphic leftover-map axis {axis} σ {value}": "trục đồ họa so sánh bản đồ phần dư {axis} σ {value}", "leftover map comparison graphic leftover-map axis {axis} σ {value} ({share}%)": diff --git a/frontend/src/leftoverMapAxisBadge.ts b/frontend/src/leftoverMapAxisBadge.ts index 3c74e05ad..31238556e 100644 --- a/frontend/src/leftoverMapAxisBadge.ts +++ b/frontend/src/leftoverMapAxisBadge.ts @@ -8,6 +8,8 @@ * leftoverMapComparePlotAxisBadge, not this helper. * ADR 0327 captions leftover-map graphic leftover-map axis ticks as * leftoverMapPlotTickAxisBadge, not this helper. + * ADR 0328 captions leftover-map comparison graphic leftover-map axis ticks as + * leftoverMapComparePlotTickAxisBadge, not this helper. */ import type { LeftoverMapAxis } from "./api"; diff --git a/frontend/src/leftoverMapPlotAxisSingular.test.ts b/frontend/src/leftoverMapPlotAxisSingular.test.ts index 028d433a3..25dc7b7e4 100644 --- a/frontend/src/leftoverMapPlotAxisSingular.test.ts +++ b/frontend/src/leftoverMapPlotAxisSingular.test.ts @@ -3,6 +3,7 @@ import { formatLeftoverMapPlotAxisSingular, leftoverMapCompareAxisBadge, leftoverMapComparePlotAxisBadge, + leftoverMapComparePlotTickAxisBadge, leftoverMapPlotAxisBadge, leftoverMapPlotTickAxisBadge, leftoverSingularForAxis, @@ -13,6 +14,7 @@ import { LEFTOVER_MAP_COMPARE_AXIS_SINGULAR_SHARE, LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR, LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR_SHARE, + LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, LEFTOVER_MAP_PLOT_AXIS_SINGULAR, LEFTOVER_MAP_PLOT_AXIS_SINGULAR_SHARE, LEFTOVER_MAP_PLOT_TICK_SINGULAR, @@ -360,11 +362,87 @@ describe("leftover-map graphic leftover-map axis tick leftover-map singular valu expect(LEFTOVER_MAP_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_AXIS_SINGULAR); expect(LEFTOVER_MAP_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_AXIS_BADGE_SINGULAR_ONLY); expect(LEFTOVER_MAP_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_PLOT_TICK); + expect(LEFTOVER_MAP_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR); expect(leftoverMapPlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( leftoverMapPlotAxisBadge(1, 1.84, null)?.key, ); expect(leftoverMapPlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( leftoverMapComparePlotAxisBadge(1, 1.84, null)?.key, ); + expect(leftoverMapPlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( + leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).key, + ); + }); +}); + +describe("leftover-map comparison graphic leftover-map axis tick leftover-map singular values", () => { + it("names persisted leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks", () => { + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, + values: { axis: 1, value: "+0.50", singular: "1.84" }, + }); + expect(leftoverMapComparePlotTickAxisBadge(2, "−0.02", 0.86)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, + values: { axis: 2, value: "−0.02", singular: "0.86" }, + }); + }); + + it("names rank-0 zero leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks", () => { + expect(leftoverMapComparePlotTickAxisBadge(1, "0.00", 0)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, + values: { axis: 1, value: "0.00", singular: "0.00" }, + }); + }); + + it("omits leftover-map singular values independently of leftover-map axis share", () => { + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", Number.NaN)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK, + values: { axis: 1, value: "+0.50" }, + }); + expect(leftoverMapComparePlotTickAxisBadge(2, "−0.02", -0.01)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK, + values: { axis: 2, value: "−0.02" }, + }); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).values.share).toBeUndefined(); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", null)).toEqual({ + key: LEFTOVER_MAP_COMPARE_PLOT_TICK, + values: { axis: 1, value: "+0.50" }, + }); + }); + + it("does not invent leftover-map singular values from leftover-map axis share", () => { + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", undefined).key).toBe( + LEFTOVER_MAP_COMPARE_PLOT_TICK, + ); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", undefined).values.singular).toBeUndefined(); + }); + + it("does not invent leftover-map axis share from leftover-map singular values", () => { + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).key).toBe( + LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, + ); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).values.share).toBeUndefined(); + }); + + it("stays distinct from leftover-axis, leftover-map graphic axis, leftover-map graphic tick, comparison leftover-axis, and comparison graphic copy", () => { + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).toBe( + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}", + ); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_PLOT_TICK); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_PLOT_TICK_SINGULAR); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_PLOT_TICK); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_PLOT_AXIS_SINGULAR); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_COMPARE_AXIS_SINGULAR); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR).not.toBe(LEFTOVER_MAP_AXIS_BADGE_SINGULAR_ONLY); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( + leftoverMapPlotTickAxisBadge(1, "+0.50", 1.84).key, + ); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( + leftoverMapComparePlotAxisBadge(1, 1.84, null)?.key, + ); + expect(leftoverMapComparePlotTickAxisBadge(1, "+0.50", 1.84).key).not.toBe( + leftoverMapPlotAxisBadge(1, 1.84, null)?.key, + ); }); }); diff --git a/frontend/src/leftoverMapPlotAxisSingular.ts b/frontend/src/leftoverMapPlotAxisSingular.ts index c45153ce1..e27656b55 100644 --- a/frontend/src/leftoverMapPlotAxisSingular.ts +++ b/frontend/src/leftoverMapPlotAxisSingular.ts @@ -6,6 +6,9 @@ * ADR 0327 names leftover-map graphic leftover-map axis ticks leftover-map * singular values as leftoverMapPlotTickAxisBadge independently of leftover-map * axis share. + * ADR 0328 names leftover-map comparison graphic leftover-map axis ticks leftover-map + * singular values as leftoverMapComparePlotTickAxisBadge independently of leftover-map + * axis share. * ADR 0323 captions leftover-axis report badges on the grouping comparison strip * as leftoverMapCompareAxisBadge, not leftoverMapComparePlotAxisBadge. */ @@ -16,7 +19,10 @@ import { LEFTOVER_MAP_COMPARE_PLOT_AXIS_SHARE, LEFTOVER_MAP_PLOT_AXIS_SHARE, } from "./leftoverMapPlotAxisShare"; -import { LEFTOVER_MAP_PLOT_TICK } from "./leftoverMapPlotLayout"; +import { + LEFTOVER_MAP_COMPARE_PLOT_TICK, + LEFTOVER_MAP_PLOT_TICK, +} from "./leftoverMapPlotLayout"; export const LEFTOVER_MAP_PLOT_AXIS_SINGULAR = "leftover-map axis {axis} σ {value}"; @@ -32,6 +38,9 @@ export const LEFTOVER_MAP_COMPARE_PLOT_AXIS_SINGULAR_SHARE = export const LEFTOVER_MAP_PLOT_TICK_SINGULAR = "leftover-map axis {axis} tick {value} σ {singular}"; +export const LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR = + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}"; + export const LEFTOVER_MAP_COMPARE_AXIS_SINGULAR = "leftover map comparison leftover axis {axis} σ {value}"; @@ -164,3 +173,18 @@ export function leftoverMapPlotTickAxisBadge( values: { axis: axisIndex, value: tickLabel, singular }, }; } + +export function leftoverMapComparePlotTickAxisBadge( + axisIndex: number, + tickLabel: string, + leftoverSingular: number | null | undefined, +): LeftoverMapCompareAxisBadge { + const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); + if (singular === null) { + return { key: LEFTOVER_MAP_COMPARE_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; + } + return { + key: LEFTOVER_MAP_COMPARE_PLOT_TICK_SINGULAR, + values: { axis: axisIndex, value: tickLabel, singular }, + }; +} diff --git a/frontend/src/leftoverMapPlotLayout.test.ts b/frontend/src/leftoverMapPlotLayout.test.ts index 2c166ec75..08ab4c3b2 100644 --- a/frontend/src/leftoverMapPlotLayout.test.ts +++ b/frontend/src/leftoverMapPlotLayout.test.ts @@ -1372,6 +1372,9 @@ describe("leftover map comparison graphic labels", () => { expect(LEFTOVER_MAP_COMPARE_PLOT_TICK).not.toBe("leftover-map axis {axis} σ {value}"); expect(LEFTOVER_MAP_COMPARE_PLOT_TICK).not.toBe("leftover axis {axis} σ {value}"); expect(LEFTOVER_MAP_COMPARE_PLOT_TICK).not.toBe("leftover-map axis {axis} tick {value} σ {singular}"); + expect(LEFTOVER_MAP_COMPARE_PLOT_TICK).not.toBe( + "leftover map comparison graphic leftover-map axis {axis} tick {value} σ {singular}", + ); expect(LEFTOVER_MAP_COMPARE_PLOT_TICK).not.toBe( "leftover map comparison leftover axis {axis} σ {value}", ); diff --git a/frontend/src/leftoverMapPlotLayout.ts b/frontend/src/leftoverMapPlotLayout.ts index af1aac55f..7df3ba874 100644 --- a/frontend/src/leftoverMapPlotLayout.ts +++ b/frontend/src/leftoverMapPlotLayout.ts @@ -94,6 +94,9 @@ * ADR 0327 fail-closes leftover-map graphic leftover-map axis ticks leftover-map * singular values through leftoverMapPlotTickAxisBadge independently of leftover-map * axis share. + * ADR 0328 fail-closes leftover-map comparison graphic leftover-map axis ticks leftover-map + * singular values through leftoverMapComparePlotTickAxisBadge independently of leftover-map + * axis share. */ import { formatLeftoverMapCoordinatePair } from "./leftoverMapCoordinates"; diff --git a/pyproject.toml b/pyproject.toml index b6bed38ce..60a1c5783 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "lineageweave" -version = "2.84.0" +version = "2.85.0" description = "Reconstructs git-branch-style lineage DAGs from scattered short records using multi-channel score fusion and LLM adjudication." readme = "README.md" license = { text = "MIT" }