diff --git a/AGENTS.md b/AGENTS.md index a689a1ef1..84a21af42 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -273,7 +273,7 @@ stops startup instead of leaving a healthy-looking partial schema, and application code must not compensate for a missing table. Period leftover pairs (ADR 0017 / 0018 / 0048 / 0049 / 0119 / 0158 / 0162 / -0163 / 0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308) are computed in `lineageweave/leftover_pairs.py` from the +0163 / 0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309) are computed in `lineageweave/leftover_pairs.py` from the residual after a real GRM/GPCM score, never invented. Distances are Euclidean on the two-dimensional Gabriel leftover map; missing cells stay out of the factorization. Closest and farthest post–criterion pairs @@ -513,8 +513,7 @@ Do not invent leftover-map item coverage from plotted criterion marker count, leftover pair count, leftover-map rank, leftover-map distance, leftover-map axis share, leftover-map reconstruction, leftover residual, leftover-map post coverage, leftover-map incomplete post coverage, leftover-map incomplete item -coverage, or the count of unused axes. This increment does not caption leftover-map -incomplete item coverage on the comparison graphic. ADR 0308 captions leftover-map +coverage, or the count of unused axes. ADR 0308 captions leftover-map incomplete post coverage on that grouping comparison leftover-map graphic when leftoverMapIncompletePostCount returns a usable dropped integer; a missing, negative, non-integer, or scored-minus-used mismatch omits that leftover-map comparison graphic incomplete posts caption and keeps leftover-map @@ -523,7 +522,15 @@ return usable complete-case integers. Do not invent leftover-map incomplete post used, plotted marker count, leftover pair count, leftover-map rank, leftover-map distance, leftover-map axis share, leftover-map reconstruction, leftover residual, leftover-map post coverage, leftover-map item coverage, leftover-map incomplete item coverage, or the count of unused -axes. +axes. ADR 0309 captions leftover-map incomplete item coverage on that grouping comparison leftover-map +graphic when leftoverMapIncompleteItemCount returns a usable dropped integer; a missing, negative, +non-integer, or scored-minus-used mismatch omits that leftover-map comparison graphic incomplete items +caption and keeps leftover-map comparison graphic coverage, leftover-map comparison graphic item +coverage, and leftover-map comparison graphic incomplete posts when those helpers return usable +integers. Do not invent leftover-map incomplete items from scored minus used, plotted criterion +marker count, leftover pair count, leftover-map rank, leftover-map distance, leftover-map axis +share, leftover-map reconstruction, leftover residual, leftover-map post coverage, leftover-map +item coverage, leftover-map incomplete post coverage, or the count of unused axes. When `R`, `R̂`, `U`, `x`, `s`, and `e` are finite, `e + s + x = 1`. When `Y`, `E`, and `R` are finite, `Y − E = R`. When `R`, `R̂`, and `U` are @@ -583,6 +590,9 @@ complete-case integers. Grouping comparison leftover-map incomplete post coverage (ADR 0308) captions that grouping comparison leftover-map graphic with persisted leftover-map incomplete post coverage when leftoverMapIncompletePostCount returns a usable dropped integer. +Grouping comparison leftover-map incomplete item coverage (ADR 0309) captions +that grouping comparison leftover-map graphic with persisted leftover-map incomplete +item coverage when leftoverMapIncompleteItemCount returns a usable dropped integer. Item complete-case coverage (ADR 0282) captions the leftover-map graphic with how many scored criteria entered the map. Item complete-case coverage on the pair list (ADR 0285) diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index 8e93b35c2..40329cc97 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -712,8 +712,10 @@ comparison leftover-map graphic when leftoverMapItemCoverageCounts returns usabl complete-case integers. ADR 0308 captions leftover-map incomplete post coverage on that grouping comparison leftover-map graphic when leftoverMapIncompletePostCount returns a usable -dropped integer and does not caption leftover-map incomplete item coverage -on that comparison plot. +dropped integer. +ADR 0309 captions leftover-map incomplete item coverage on that grouping +comparison leftover-map graphic when leftoverMapIncompleteItemCount returns a usable +dropped integer. Click a post marker or a pair button opens that post. Those ADRs are the normative mathematical, storage, and display contracts. Leftover-map axis share @@ -749,8 +751,10 @@ incomplete item coverage (ADR 0292), leftover-map reconstruction `R̂` (ADR 0304), leftover-map axis share on the grouping comparison leftover-map graphic (ADR 0305), leftover-map complete-case coverage on the grouping comparison leftover-map graphic (ADR 0306), leftover-map item complete-case -coverage on the grouping comparison leftover-map graphic (ADR 0307), and leftover-map -incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308); +coverage on the grouping comparison leftover-map graphic (ADR 0307), leftover-map +incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308), +and leftover-map incomplete item coverage on the grouping comparison leftover-map +graphic (ADR 0309); `POST .../rebuild` scores every grouping kind (post_admin). `make seed` folds A-100/B-200 Event Lineage fixtures (and the Riverbend calendar post) that already have constructed IRT cells into the same shared diff --git a/CHANGELOG.d/2.66.0-leftover-map-compare-plot-incomplete-item.md b/CHANGELOG.d/2.66.0-leftover-map-compare-plot-incomplete-item.md new file mode 100644 index 000000000..a26837385 --- /dev/null +++ b/CHANGELOG.d/2.66.0-leftover-map-compare-plot-incomplete-item.md @@ -0,0 +1,27 @@ +## 2.66.0 — Leftover-map incomplete item coverage on grouping comparison leftover-map graphic + +- Caption leftover-map incomplete item coverage on the grouping comparison + leftover-map graphic (ADR 0309). After `make seed`, closest and farthest + leftover pairs sit above the member list with the Gabriel biplot of + already-named coordinates, leftover-map axis share when finite, leftover-map + complete-case coverage when leftoverMapCoverageCounts returns usable + complete-case integers, leftover-map item complete-case coverage when + leftoverMapItemCoverageCounts returns usable complete-case integers, leftover-map + incomplete post coverage when leftoverMapIncompletePostCount returns a usable + dropped integer, and a plot caption that matches leftover-map incomplete item + coverage on the grouping comparison leftover-map graphic; click a post marker + or a pair button opens that post. A missing, negative, non-integer, or + scored-minus-used mismatch omits that leftover-map comparison graphic incomplete + items caption and keeps leftover-map comparison graphic coverage, leftover-map + comparison graphic item coverage, and leftover-map comparison graphic incomplete + posts when those helpers return usable integers. Dropped `0` is shown when that + persisted dropped count is a non-negative integer. Comparison copy uses + `Leftover map comparison graphic incomplete items` so it stays distinct from + hyphen `Leftover-map graphic incomplete items` and from strip + `Leftover map comparison incomplete items`. This increment does not caption + leftover-map reconstruction on the comparison graphic. Do not invent incomplete + items from scored minus used, plotted criterion marker count, leftover pair + count, leftover-map rank, leftover-map distance, leftover-map axis share, + leftover-map reconstruction, leftover-map post coverage, leftover-map item + coverage, leftover-map incomplete post coverage, or the count of unused axes. + Never invent a leftover score. Never invent a theta. No new columns. diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ae085260..91e551ead 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,40 @@ All notable changes to this project are documented here. Format follows ### Added +- Period leftover pairs now name leftover-map incomplete item coverage on the + grouping comparison leftover-map graphic (ADR 0309 / v2.66.0). After + `make seed`, closest and farthest leftover pairs sit above the member list + with the Gabriel biplot of already-named coordinates, leftover-map axis share + when finite, leftover-map complete-case coverage when leftoverMapCoverageCounts + returns usable complete-case integers, leftover-map item complete-case coverage + when leftoverMapItemCoverageCounts returns usable complete-case integers, + leftover-map incomplete post coverage when leftoverMapIncompletePostCount + returns a usable dropped integer, and leftover map dropped N incomplete + criteria on that grouping comparison leftover-map graphic when + leftoverMapIncompleteItemCount returns a usable dropped integer; click a post + marker or a pair button opens that post. A missing, negative, non-integer, or + scored-minus-used mismatch omits that leftover-map comparison graphic + incomplete items caption and keeps leftover-map comparison graphic coverage, + leftover-map comparison graphic item coverage, and leftover-map comparison + graphic incomplete posts when those helpers return usable integers. Dropped + `0` is shown when that persisted dropped count is a non-negative integer. + Rank-0 origin cells still plot at `(0, 0)` and still name incomplete items + when that dropped count is persisted. Comparison copy uses `Leftover map + comparison graphic incomplete items` so it stays distinct from hyphen + `Leftover-map graphic incomplete items` and from strip `Leftover map + comparison incomplete items`. Incomplete item coverage omits independently of + post coverage, item coverage, and incomplete post coverage. This increment + does not caption leftover-map reconstruction on the comparison graphic. Do + not invent leftover-map incomplete items from scored minus used, plotted + criterion marker count, leftover pair count, leftover-map rank, leftover-map + distance, leftover-map axis share, leftover expected, leftover observed, + leftover residual, leftover-map reconstruction, leftover-map unexplained + leftover, leftover-map post coverage, leftover-map item coverage, + leftover-map incomplete post coverage, or the count of unused axes. A finite + negative leftover is shown, never clamped. Omit the comparison graphic when + no leftover pair has four finite leftover-map coordinates. Never invent a + leftover score or a theta. No new columns. + - Period leftover pairs now name leftover-map incomplete post coverage on the grouping comparison leftover-map graphic (ADR 0308 / v2.65.0). After `make seed`, closest and farthest leftover pairs sit above the member list @@ -27,8 +61,7 @@ All notable changes to this project are documented here. Format follows Comparison copy uses `Leftover map comparison graphic incomplete posts` so it stays distinct from hyphen `Leftover-map graphic incomplete posts` and from strip `Leftover map comparison incomplete posts`. Incomplete post coverage omits - independently of post coverage and item coverage. This increment does not - caption leftover-map incomplete item coverage on the comparison graphic. Do + independently of post coverage and item coverage. Do not invent leftover-map incomplete posts from scored minus used, plotted marker count, leftover pair count, leftover-map rank, leftover-map distance, leftover-map axis share, leftover expected, leftover observed, leftover residual, diff --git a/CLAUDE.md b/CLAUDE.md index 92bdea17c..5a42cfb1d 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -49,7 +49,7 @@ cutoff. Global Ask optional `knowledge_cutoff` uses the same cover Create/start endpoint rules (ADR 0017 / 0021), tie-vs-miss similarity (ADR 0026), R&R catalog ids (ADR 0019 / 0027), leftover pairs -(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308), occupational construct catalog search +(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293 / 0294 / 0295 / 0296 / 0297 / 0298 / 0299 / 0300 / 0301 / 0302 / 0303 / 0304 / 0305 / 0306 / 0307 / 0308 / 0309), occupational construct catalog search (ADR 0257), the text-channel embedding swap and cosine clamp (ADR 0190), per-edge channel-score persistence (ADR 0195), token-backed status notices (ADR 0220), diff --git a/docs/adr/0284-leftover-map-plot-incomplete-item.md b/docs/adr/0284-leftover-map-plot-incomplete-item.md index 1eb30d18f..cc7d03d75 100644 --- a/docs/adr/0284-leftover-map-plot-incomplete-item.md +++ b/docs/adr/0284-leftover-map-plot-incomplete-item.md @@ -3,6 +3,9 @@ **Decision status:** Accepted **Date:** 2026-08-30 +**Amended by:** [ADR 0309](0309-leftover-map-compare-plot-incomplete-item.md) +(leftover-map incomplete item coverage on the grouping comparison leftover-map graphic) + Amends [ADR 0268](0268-leftover-map-graphic-display.md), [ADR 0049](0049-leftover-pair-report-ui.md), and leftover-map complete-case coverage ([ADR 0168](0168-leftover-map-complete-case-coverage.md)). Independent of diff --git a/docs/adr/0292-leftover-map-compare-incomplete-item.md b/docs/adr/0292-leftover-map-compare-incomplete-item.md index 977749229..15e7019b5 100644 --- a/docs/adr/0292-leftover-map-compare-incomplete-item.md +++ b/docs/adr/0292-leftover-map-compare-incomplete-item.md @@ -3,6 +3,9 @@ **Decision status:** Accepted **Date:** 2026-08-30 +**Amended by:** [ADR 0309](0309-leftover-map-compare-plot-incomplete-item.md) +(leftover-map incomplete item coverage on the grouping comparison leftover-map graphic) + Amends leftover pairs on the grouping comparison strip ([ADR 0149](0149-leftover-pairs-on-comparison-strip.md)), leftover-map complete-case coverage ([ADR 0168](0168-leftover-map-complete-case-coverage.md)), diff --git a/docs/adr/0304-leftover-map-compare-graphic.md b/docs/adr/0304-leftover-map-compare-graphic.md index d71ea7494..480a7a38d 100644 --- a/docs/adr/0304-leftover-map-compare-graphic.md +++ b/docs/adr/0304-leftover-map-compare-graphic.md @@ -10,7 +10,9 @@ [ADR 0307](0307-leftover-map-compare-plot-item-coverage.md) (leftover-map item complete-case coverage on the grouping comparison leftover-map graphic), [ADR 0308](0308-leftover-map-compare-plot-incomplete-post.md) -(leftover-map incomplete post coverage on the grouping comparison leftover-map graphic) +(leftover-map incomplete post coverage on the grouping comparison leftover-map graphic), +[ADR 0309](0309-leftover-map-compare-plot-incomplete-item.md) +(leftover-map incomplete item coverage on the grouping comparison leftover-map graphic) Amends leftover pairs on the grouping comparison strip ([ADR 0149](0149-leftover-pairs-on-comparison-strip.md)), leftover-map diff --git a/docs/adr/0307-leftover-map-compare-plot-item-coverage.md b/docs/adr/0307-leftover-map-compare-plot-item-coverage.md index fcf5b1b6e..4044b5d90 100644 --- a/docs/adr/0307-leftover-map-compare-plot-item-coverage.md +++ b/docs/adr/0307-leftover-map-compare-plot-item-coverage.md @@ -4,7 +4,9 @@ **Date:** 2026-08-31 **Amended by:** [ADR 0308](0308-leftover-map-compare-plot-incomplete-post.md) -(leftover-map incomplete post coverage on the grouping comparison leftover-map graphic) +(leftover-map incomplete post coverage on the grouping comparison leftover-map graphic), +[ADR 0309](0309-leftover-map-compare-plot-incomplete-item.md) +(leftover-map incomplete item coverage on the grouping comparison leftover-map graphic) Amends leftover-map item complete-case coverage on the graphic display ([ADR 0282](0282-leftover-map-plot-item-coverage.md)), leftover-map item diff --git a/docs/adr/0308-leftover-map-compare-plot-incomplete-post.md b/docs/adr/0308-leftover-map-compare-plot-incomplete-post.md index 1c1a21dee..b26275d46 100644 --- a/docs/adr/0308-leftover-map-compare-plot-incomplete-post.md +++ b/docs/adr/0308-leftover-map-compare-plot-incomplete-post.md @@ -3,6 +3,9 @@ **Decision status:** Accepted **Date:** 2026-08-31 +**Amended by:** [ADR 0309](0309-leftover-map-compare-plot-incomplete-item.md) +(leftover-map incomplete item coverage on the grouping comparison leftover-map graphic) + Amends leftover-map incomplete post coverage on the graphic display ([ADR 0283](0283-leftover-map-plot-incomplete.md)), leftover-map incomplete post coverage on the grouping comparison strip diff --git a/docs/adr/0309-leftover-map-compare-plot-incomplete-item.md b/docs/adr/0309-leftover-map-compare-plot-incomplete-item.md new file mode 100644 index 000000000..da8c5c54e --- /dev/null +++ b/docs/adr/0309-leftover-map-compare-plot-incomplete-item.md @@ -0,0 +1,260 @@ +# ADR 0309 — Name leftover-map incomplete item coverage on the grouping comparison leftover-map graphic + +**Decision status:** Accepted +**Date:** 2026-08-31 + +Amends leftover-map incomplete item coverage on the graphic display +([ADR 0284](0284-leftover-map-plot-incomplete-item.md)), leftover-map incomplete +item coverage on the grouping comparison strip +([ADR 0292](0292-leftover-map-compare-incomplete-item.md)), leftover-map incomplete +post coverage on the grouping comparison leftover-map graphic +([ADR 0308](0308-leftover-map-compare-plot-incomplete-post.md)), leftover-map item +complete-case coverage on the grouping comparison leftover-map graphic +([ADR 0307](0307-leftover-map-compare-plot-item-coverage.md)), leftover-map +complete-case coverage on the grouping comparison leftover-map graphic +([ADR 0306](0306-leftover-map-compare-plot-coverage.md)), leftover-map graphic +display on the grouping comparison strip +([ADR 0304](0304-leftover-map-compare-graphic.md)), leftover-map axis share +on the grouping comparison leftover-map graphic +([ADR 0305](0305-leftover-map-compare-plot-axis-share.md)), leftover-map +complete-case coverage persistence +([ADR 0168](0168-leftover-map-complete-case-coverage.md)), leftover pairs on +the grouping comparison strip +([ADR 0149](0149-leftover-pairs-on-comparison-strip.md)), leftover-map +coordinates on the compare leftover-pair payload +([ADR 0303](0303-leftover-map-compare-coordinates-payload.md)), leftover-map +coordinates on grouping comparison strip pair rows +([ADR 0302](0302-leftover-map-compare-coordinates.md)), leftover-map +rank on grouping comparison strip pair rows +([ADR 0301](0301-leftover-map-compare-rank.md)), leftover expected on grouping +comparison strip pair rows +([ADR 0300](0300-leftover-map-compare-expected.md)), leftover observed on +grouping comparison strip pair rows +([ADR 0299](0299-leftover-map-compare-observed.md)), leftover residual +on grouping comparison strip pair rows +([ADR 0298](0298-leftover-map-compare-residual.md)), leftover-map unexplained leftover +on grouping comparison strip pair rows +([ADR 0297](0297-leftover-map-compare-unexplained.md)), leftover-map cross share +on grouping comparison strip pair rows +([ADR 0296](0296-leftover-map-compare-cross-share.md)), leftover-map unexplained +leftover share on grouping comparison strip pair rows +([ADR 0295](0295-leftover-map-compare-unexplained-share.md)), leftover-map +explained leftover share on grouping comparison strip pair rows +([ADR 0294](0294-leftover-map-compare-explained-share.md)), leftover-map +reconstruction on grouping comparison strip pair rows +([ADR 0293](0293-leftover-map-compare-reconstruction.md)), leftover-map +incomplete post coverage on the grouping comparison strip +([ADR 0291](0291-leftover-map-compare-incomplete-post.md)), leftover-map item +complete-case coverage on the grouping comparison strip +([ADR 0290](0290-leftover-map-compare-item-coverage.md)), leftover-map +complete-case coverage on the grouping comparison strip +([ADR 0289](0289-leftover-map-compare-coverage.md)), leftover residual +disclosure ([ADR 0162](0162-leftover-residual-disclosure.md)), leftover +observed `Y` / expected `E` ([ADR 0163](0163-leftover-observed-expected.md)), leftover-map unexplained leftover persistence ([ADR 0182](0182-leftover-map-unexplained.md)), +leftover-map reconstruction persistence +([ADR 0201](0201-leftover-map-reconstruction.md)), leftover-map rank +([ADR 0164](0164-leftover-map-rank.md)), leftover-map rank on pair segments +([ADR 0280](0280-leftover-map-segment-rank.md)), leftover-map coordinate ticks +([ADR 0270](0270-leftover-map-coordinate-ticks.md)), leftover-map graphic display +([ADR 0268](0268-leftover-map-graphic-display.md)), leftover-map axis share on +the graphic display ([ADR 0269](0269-leftover-map-axis-share-plot.md)), leftover-map +complete-case coverage on the graphic display +([ADR 0281](0281-leftover-map-plot-coverage.md)), leftover-map item complete-case +coverage on the graphic display +([ADR 0282](0282-leftover-map-plot-item-coverage.md)), leftover-map incomplete +post coverage on the graphic display +([ADR 0283](0283-leftover-map-plot-incomplete.md)), and leftover-map coordinates +([ADR 0267](0267-leftover-map-coordinates.md)). Independent of leftover-map +post complete-case coverage fail-closed on the pair list +([ADR 0288](0288-leftover-map-list-post-coverage-helper.md)), leftover-map +incomplete item coverage on the pair list +([ADR 0287](0287-leftover-map-list-incomplete-item.md)), leftover-map incomplete +post coverage on the pair list +([ADR 0286](0286-leftover-map-list-incomplete-post.md)), leftover-map item +complete-case coverage on the pair list +([ADR 0285](0285-leftover-map-list-item-coverage.md)), leftover expected on pair +segments ([ADR 0279](0279-leftover-map-segment-expected.md)), leftover observed +on pair segments ([ADR 0278](0278-leftover-map-segment-observed.md)), leftover +residual on pair segments ([ADR 0277](0277-leftover-map-segment-residual.md)), +leftover-map unexplained leftover on pair segments +([ADR 0276](0276-leftover-map-segment-unexplained-leftover.md)), leftover-map +cross share on pair segments ([ADR 0275](0275-leftover-map-segment-cross-share.md)), +leftover-map unexplained leftover share on pair segments +([ADR 0274](0274-leftover-map-segment-unexplained-share.md)), leftover-map +explained leftover share on pair segments +([ADR 0273](0273-leftover-map-segment-explained-share.md)), leftover-map +reconstruction on pair segments +([ADR 0272](0272-leftover-map-segment-reconstruction.md)), leftover-map +distance on pair segments ([ADR 0271](0271-leftover-map-segment-distance.md)), +leftover-map cross share persistence ([ADR 0185](0185-leftover-map-cross-share.md)), leftover-map +unexplained leftover share persistence +([ADR 0233](0233-leftover-map-unexplained-share.md)), leftover-map explained leftover +share persistence ([ADR 0266](0266-leftover-map-explained-share.md)), and leftover-map +reconstruction on the grouping comparison leftover-map graphic. + +## Context + +ADR 0168 already persists `incomplete_item_count` on +`report_leftover_map_coverage`. ADR 0284 already captions the period-report +leftover-map graphic with `Leftover map dropped N incomplete criteria` under +accessible name `Leftover-map graphic incomplete items`. ADR 0292 already +captions the grouping comparison strip with that same body under accessible +name `Leftover map comparison incomplete items`. ADR 0304 already draws the +leftover-map graphic of persisted `ξ_{1:2}` / `ζ_{1:2}` above grouping +comparison leftover-pair buttons. ADR 0306 already captions leftover-map +complete-case coverage on that graphic. ADR 0307 already captions leftover-map +item complete-case coverage on that graphic. ADR 0308 already captions leftover-map +incomplete post coverage on that graphic. The comparison graphic still +omits leftover-map incomplete item coverage, so a buyer who reads `used 2 of 2 +scored criteria (complete-case)` can treat those two markers as the scored-criterion +census even after the strip note names dropped criteria. Incomplete columns are +dropped from Gabriel factorization; hiding the dropped count on the comparison +graphic lets a sparse criterion with one missing post vanish without a next +action. + +This increment captions leftover-map incomplete item coverage on the grouping +comparison leftover-map graphic from already-named `leftover_map_coverage`. +Comparison copy uses the accessible name +`Leftover map comparison graphic incomplete items` so it stays distinct from +hyphen `Leftover-map graphic incomplete items` on the period-report graphic +and from strip `Leftover map comparison incomplete items`. It does not add +columns. It does not recompute leftover-map incomplete items from leftover-map +rank, leftover-map distance, leftover expected, leftover observed, leftover +residual, leftover-map reconstruction, leftover-map unexplained leftover, +leftover-map axis share, leftover-map post coverage, leftover-map item +coverage, leftover-map incomplete post coverage, plotted criterion marker count, +leftover pair count, scored minus used, or the count of unused axes. It does +not persist leftover-map inner product, cosine, or length as separate columns. +Do not invent a leftover score. Do not invent a theta. + +The dashboard stack already used neighbouring leftover facts under other +numbers. This protected increment uses **0309** so it does not collide with +leftover-map incomplete post coverage on the grouping comparison leftover-map +graphic (0308), leftover-map item complete-case coverage on the grouping comparison leftover-map +graphic (0307), leftover-map complete-case coverage on the grouping comparison +leftover-map graphic (0306), leftover-map axis share on the grouping comparison leftover-map +graphic (0305), leftover-map graphic display on the grouping comparison strip +(0304), leftover-map incomplete item coverage on the graphic display (0284), leftover-map +incomplete item coverage on the grouping comparison strip (0292), leftover-map graphic +display (0268), leftover-map coordinates (0267), or the dashboard stacks. + +## Decision + +On the grouping comparison leftover-map graphic, caption persisted leftover-map +incomplete item coverage as `Leftover map dropped N incomplete criteria`, using +the same `incomplete_item_count` integer the strip note already shows through +leftoverMapIncompleteItemCount. Use the distinct accessible name +`Leftover map comparison graphic incomplete items` so the graphic caption is +not the strip note (`Leftover map comparison incomplete items`) and is not the +period-report graphic caption (`Leftover-map graphic incomplete items`). A +missing coverage row, a negative dropped count, a non-integer dropped count, or +a dropped count that does not equal scored minus used when complete-case +integers are usable omits that leftover-map comparison graphic incomplete items +caption and keeps leftover-map comparison graphic coverage when leftoverMapCoverageCounts +returns usable complete-case integers, leftover-map comparison graphic item +coverage when leftoverMapItemCoverageCounts returns usable complete-case +integers, leftover-map comparison graphic incomplete posts when leftoverMapIncompletePostCount +returns a usable dropped integer, leftover map comparison axis share when finite, leftover map +comparison axis text, leftover-map rank when that rank is a non-negative +integer, leftover expected `E` when finite, leftover observed `Y` when finite, +leftover residual `R` when finite, leftover-map unexplained leftover `U` when +finite, leftover-map cross share `x` when finite, leftover-map unexplained leftover +share `s` when finite, leftover-map explained leftover share `e` when finite, +leftover-map reconstruction `R̂` when finite, leftover-map distance `d`, plus +the strip coverage notes. Dropped `0` is shown when that persisted dropped count +is a non-negative integer. Rank-0 origin cells still name incomplete items when +that dropped count is persisted. Do not invent incomplete items from scored minus +used, plotted criterion marker count, leftover pair count, leftover-map rank, leftover-map +distance, leftover-map axis share, leftover expected, leftover observed, leftover +residual, leftover-map reconstruction, leftover-map unexplained leftover, +leftover-map post coverage, leftover-map item coverage, leftover-map incomplete +post coverage, or the count of unused axes. Click a post marker to open that post. + +Incomplete item coverage omits independently of post coverage, item coverage, and +incomplete post coverage. +A scored-minus-used mismatch omits leftover-map comparison graphic incomplete +items and keeps a usable post caption, a usable item caption, and a usable +incomplete posts caption. + +This increment does not caption leftover-map reconstruction on the +comparison graphic. That reconstruction already sits on the strip through ADR 0293. A +finite negative leftover on neighbouring fields is shown, never clamped. + +Do not add SQL migrations. Do not edit shipped migrations. Do not persist inner +product, cosine, or length as separate columns. Do not invent a leftover +score. Do not invent a theta. + +## Consequences + +After `make seed`, grouping comparison leftover pairs that already show +the leftover-map graphic of persisted `ξ` / `ζ` also name leftover-map +incomplete item coverage on that graphic when leftoverMapIncompleteItemCount +returns a usable dropped integer. Rank-0 unused axes still plot at +the origin and still name incomplete items when that dropped count is persisted. +Click a post marker or a pair button opens that post. Hidden posts stay hidden. +When `Y`, `E`, and `R` are finite, `Y − E = R`. When `R`, `R̂`, and `U` +are finite, `U + R̂ = R`. When `R`, `R̂`, `U`, `x`, `s`, and `e` are +finite, `e + s + x = 1`. When coordinates, reconstruction, and distance +are finite, `R̂ = ξ · ζ` and `d = ‖ξ − ζ‖`. + +## Related + +Independent of leftover interaction-map persistence, leftover-criterion +evaluation landing, leftover residual disclosure, leftover-map +complete-case coverage persistence, leftover pairs on the grouping comparison +strip, leftover-map complete-case coverage on the grouping comparison strip, +leftover-map item complete-case coverage on the grouping comparison strip, +leftover-map incomplete post coverage on the grouping comparison strip, +leftover-map incomplete item coverage on the grouping comparison strip, +leftover-map reconstruction on grouping comparison strip pair rows, +leftover-map explained leftover share on grouping comparison strip pair rows, +leftover-map unexplained leftover share on grouping comparison strip pair rows, +leftover-map cross share on grouping comparison strip pair rows, +leftover-map unexplained leftover on grouping comparison strip pair rows, +leftover residual on grouping comparison strip pair rows, leftover observed +on grouping comparison strip pair rows, leftover expected on grouping +comparison strip pair rows, leftover-map rank on grouping comparison strip +pair rows, leftover-map coordinates on grouping comparison strip pair rows, +leftover-map coordinates on the compare leftover-pair payload, leftover-map +inner product, leftover-map cosine, leftover-map length, leftover residual +on pair segments, leftover observed on pair segments, leftover expected on +pair segments, leftover-map rank on pair segments, leftover-map unexplained +leftover on pair segments, leftover-map unexplained leftover persistence, +leftover-map cross share on pair segments, leftover-map cross share +persistence, leftover-map unexplained leftover share on pair segments, +leftover-map unexplained leftover share persistence, leftover-map explained +leftover share on pair segments, leftover-map explained leftover share +persistence, leftover-map reconstruction on pair segments, leftover-map +reconstruction persistence, leftover-map item complete-case coverage on the +graphic display, leftover-map item complete-case coverage on the pair list, +leftover-map incomplete post coverage on the graphic display, leftover-map +incomplete post coverage on the pair list, leftover-map incomplete item +coverage on the graphic display, leftover-map incomplete item coverage on +the pair list, leftover-map post complete-case coverage fail-closed on the +pair list, leftover-map rank persistence, leftover-map coordinate +persistence, leftover-map coordinate ticks, leftover-map complete-case +coverage on the graphic display, leftover-map complete-case coverage on the +grouping comparison leftover-map graphic, leftover-map item complete-case +coverage on the grouping comparison leftover-map graphic, leftover-map +incomplete post coverage on the grouping comparison leftover-map graphic, leftover-map axis +share on the grouping comparison leftover-map graphic, and leftover-map +reconstruction on the grouping comparison leftover-map graphic. + +## References + +Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping +unobserved item–respondent interactions: A latent space item response +model with interaction map. *Psychometrika, 86*(2), 378–403. +https://doi.org/10.1007/s11336-021-09762-5 +(LSIRM interaction `−γ‖ξ_j − ζ_i‖` after main effects +`α_j − β_i`; typically `p = 2` for the interaction map. Incomplete columns +are dropped from the complete-case residual rectangle; incomplete item +coverage names how many scored criteria stayed out of that factorization. +Grouping comparison leftover-map incomplete item coverage captions that +persisted dropped count on the grouping comparison leftover-map graphic only +when leftoverMapIncompleteItemCount returns a usable dropped integer. Rank-0 +unused axes still name incomplete items when that dropped count is stored.) + +Gabriel, K. R. (1971). The biplot graphic display of matrices with +application to principal component analysis. *Biometrika, 58*(3), +453–467. https://doi.org/10.1093/biomet/58.3.453 diff --git a/docs/product-technical-gap-baseline.md b/docs/product-technical-gap-baseline.md index 8fd47eff9..de4912bf2 100644 --- a/docs/product-technical-gap-baseline.md +++ b/docs/product-technical-gap-baseline.md @@ -1,5 +1,24 @@ # Product & Technical Gap Baseline +> Exact-head loop overlay: 2026-08-31 05:20 KST. Protected `main` is +> `cb187cadee5fb6c46d8a944815ccc154a1e028d1`. Writes work. Do not +> self-approve. #848 leftover-map incomplete posts on the grouping comparison leftover-map +> graphic (v2.65.0 / ADR 0308) is `6707725`, stacked on #846 @ `4779764`. +> Next buyer increment on this cycle: leftover-map incomplete item coverage on +> the grouping comparison leftover-map graphic (ADR 0309 / v2.66.0) delivered +> locally on `feat/leftover-map-compare-plot-incomplete-item-v2660`. Caption leftover +> map dropped N incomplete criteria on that comparison graphic from already-named +> leftover_map_coverage. Distinct accessible name `Leftover map comparison graphic +> incomplete items`. Omit when leftoverMapIncompleteItemCount fail-closes. Do not +> caption leftover-map reconstruction on that comparison graphic this increment. +> Do not invent leftover-map incomplete items from scored minus used, plotted +> criterion marker count, leftover pair count, leftover-map rank, leftover-map +> distance, leftover-map axis share, leftover-map reconstruction, leftover-map +> post coverage, leftover-map item coverage, leftover-map incomplete post +> coverage, or the count of unused axes. Stack onto #848. Leave open for +> independent review. Do not squash-merge. Issues #79 and #87 stay open. #96 is +> already closed. Do not merge #808 without independent APPROVE. + > Exact-head loop overlay: 2026-08-31 05:20 KST. Protected `main` is > `cb187cadee5fb6c46d8a944815ccc154a1e028d1`. Writes work. Do not > self-approve. #846 leftover-map item coverage on the grouping comparison leftover-map diff --git a/docs/storybook-inventory.md b/docs/storybook-inventory.md index 52a0d4e5f..26b00286f 100644 --- a/docs/storybook-inventory.md +++ b/docs/storybook-inventory.md @@ -5,7 +5,7 @@ operator-facing control you can click before changing product CSS. | Story | Operator next action | Token / module | |---|---|---| -| `Reports/LeftoverMapPlot` | Read the leftover-map graphic display of persisted `ξ` (posts) and `ζ` (criteria), match axis ticks to those coordinates, pair-segment `d` to leftover-map distance, pair-segment `R̂` to leftover-map reconstruction, pair-segment `R̂²/R²` to leftover-map explained leftover share, pair-segment `U²/R²` to leftover-map unexplained leftover share, pair-segment `2R̂U/R²` to leftover-map cross share, pair-segment `U` to leftover-map unexplained leftover, pair-segment `R` to leftover residual, pair-segment `Y` to leftover observed, pair-segment `E` to leftover expected, and pair-segment leftover-map rank, then click a post marker to open that post. Leftover-map axes name persisted leftover-map axis share when finite. The plot names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. The comparison variant names leftover-map complete-case coverage under `Leftover map comparison graphic coverage` and leftover-map item complete-case coverage under `Leftover map comparison graphic item coverage` and leftover-map incomplete post coverage under `Leftover map comparison graphic incomplete posts` and omits leftover-map incomplete item coverage on that comparison plot. `ClosestAndFarthest`, `RankZeroOrigin`, `MissingCoordinates`, `MissingAxisShare`, `Comparison`, `ComparisonMissingCoverage`, `ComparisonMissingItemCoverage`, and `ComparisonMissingIncompletePosts` cover two-pair maps, rank-0 origin with 0% share, a `0` tick, `d 0.00`, `R̂ 0.00`, `R̂²/R² 0.00`, `U²/R² 0.00`, `2R̂U/R² 0.00`, `U 0.00`, `R 0.00`, `Y 0.00`, `E 0.00`, and `rank 0`, omitted plots, missing share that keeps existing leftover-map axis text, grouping comparison leftover-map graphic coverage that matches leftover map used N of M scored posts, omitted comparison graphic coverage when leftoverMapCoverageCounts fail-closes, grouping comparison leftover-map graphic item coverage that matches leftover map used N of M scored criteria, omitted comparison graphic item coverage when leftoverMapItemCoverageCounts fail-closes, grouping comparison leftover-map graphic incomplete posts that matches leftover map dropped N incomplete posts, and omitted comparison graphic incomplete posts when leftoverMapIncompletePostCount fail-closes. The plot does not invent a leftover score. | `LeftoverMapPlot`, `leftoverMapPlotLayout`, `leftoverMapPlotAxisShare`, `--color-primary`, `--color-palette-blue-mid` | +| `Reports/LeftoverMapPlot` | Read the leftover-map graphic display of persisted `ξ` (posts) and `ζ` (criteria), match axis ticks to those coordinates, pair-segment `d` to leftover-map distance, pair-segment `R̂` to leftover-map reconstruction, pair-segment `R̂²/R²` to leftover-map explained leftover share, pair-segment `U²/R²` to leftover-map unexplained leftover share, pair-segment `2R̂U/R²` to leftover-map cross share, pair-segment `U` to leftover-map unexplained leftover, pair-segment `R` to leftover residual, pair-segment `Y` to leftover observed, pair-segment `E` to leftover expected, and pair-segment leftover-map rank, then click a post marker to open that post. Leftover-map axes name persisted leftover-map axis share when finite. The plot names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. The comparison variant names leftover-map complete-case coverage under `Leftover map comparison graphic coverage` and leftover-map item complete-case coverage under `Leftover map comparison graphic item coverage` and leftover-map incomplete post coverage under `Leftover map comparison graphic incomplete posts` and leftover-map incomplete item coverage under `Leftover map comparison graphic incomplete items`. `ClosestAndFarthest`, `RankZeroOrigin`, `MissingCoordinates`, `MissingAxisShare`, `Comparison`, `ComparisonMissingCoverage`, `ComparisonMissingItemCoverage`, `ComparisonMissingIncompletePosts`, and `ComparisonMissingIncompleteItems` cover two-pair maps, rank-0 origin with 0% share, a `0` tick, `d 0.00`, `R̂ 0.00`, `R̂²/R² 0.00`, `U²/R² 0.00`, `2R̂U/R² 0.00`, `U 0.00`, `R 0.00`, `Y 0.00`, `E 0.00`, and `rank 0`, omitted plots, missing share that keeps existing leftover-map axis text, grouping comparison leftover-map graphic coverage that matches leftover map used N of M scored posts, omitted comparison graphic coverage when leftoverMapCoverageCounts fail-closes, grouping comparison leftover-map graphic item coverage that matches leftover map used N of M scored criteria, omitted comparison graphic item coverage when leftoverMapItemCoverageCounts fail-closes, grouping comparison leftover-map graphic incomplete posts that matches leftover map dropped N incomplete posts, omitted comparison graphic incomplete posts when leftoverMapIncompletePostCount fail-closes, grouping comparison leftover-map graphic incomplete items that matches leftover map dropped N incomplete criteria, and omitted comparison graphic incomplete items when leftoverMapIncompleteItemCount fail-closes. The plot does not invent a leftover score. | `LeftoverMapPlot`, `leftoverMapPlotLayout`, `leftoverMapPlotAxisShare`, `--color-primary`, `--color-palette-blue-mid` | | `Reports/LeftoverPairList` | Read closest/farthest leftover pairs with named `R`, `Y`/`E`, rank, `U`, `s`, `e`, `x`, `R̂`, `ξ`/`ζ`, and `d`, then open that post. The leftover-map graphic display sits above the pair buttons when coordinates are finite, leftover-map axes name persisted leftover-map axis share, leftover-map axis ticks name persisted coordinates, pair segments name persisted leftover-map distance, pair segments name persisted leftover-map reconstruction, pair segments name persisted leftover-map explained leftover share, pair segments name persisted leftover-map unexplained leftover share, pair segments name persisted leftover-map cross share, pair segments name persisted leftover-map unexplained leftover, pair segments name persisted leftover residual, pair segments name persisted leftover observed, pair segments name persisted leftover expected, and pair segments name persisted leftover-map rank. The pair-list note names leftover-map complete-case coverage only when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. The grouping comparison strip names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage with distinct comparison labels when leftoverMapCoverageCounts / leftoverMapItemCoverageCounts / leftoverMapIncompletePostCount / leftoverMapIncompleteItemCount return usable integers. | `LeftoverPairList`, `LeftoverMapPlot`, `ticket-list`, `post-badge` | | `Workspace/OperationsDashboard` | Compare Event and post counts, inspect external-information coverage, then open the cited source behind a claim, handover, or repeat-issue fact. `EvidenceReady`, `NarrowViewport`, `AnalysisPendingAndMissingEvidence`, `AnalysisFailed`, and `LoadError` cover populated, mobile, unavailable-evidence, analysis-pending, retryable failure, and transport-error states. | `--color-dashboard-*`, `OperationsDashboard` | | `Post/SimilarVocPanel` | Compare ontology/semantic similar VOC and prior action evidence, then open the source; unavailable states show no fabricated TEPP theta or weight. | `SimilarVocPanel.css`, `SimilarVocPanel` | diff --git a/frontend/package.json b/frontend/package.json index e469211db..b8b217d5c 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,7 +1,7 @@ { "name": "frontend", "private": true, - "version": "2.65.0", + "version": "2.66.0", "type": "module", "scripts": { "dev": "vite", diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx index 523341e70..0faf4b91a 100644 --- a/frontend/src/App.test.tsx +++ b/frontend/src/App.test.tsx @@ -4228,6 +4228,9 @@ describe("App, authenticated", () => { expect(screen.getByLabelText("Leftover map comparison graphic incomplete posts")).toHaveTextContent( "Leftover map dropped 1 incomplete posts", ); + expect(screen.getByLabelText("Leftover map comparison graphic incomplete items")).toHaveTextContent( + "Leftover map dropped 0 incomplete criteria", + ); expect(screen.getByLabelText("Leftover-map graphic item coverage")).toHaveTextContent( "Leftover map used 2 of 2 scored criteria (complete-case)", ); @@ -4396,6 +4399,21 @@ describe("App, authenticated", () => { "Leftover-map graphic incomplete posts", ), ).not.toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).getByLabelText( + "Leftover map comparison graphic incomplete items", + ), + ).toHaveTextContent("Leftover map dropped 0 incomplete criteria"); + expect( + within(screen.getByLabelText("Grouping comparison")).getAllByLabelText( + "Leftover map comparison graphic incomplete items", + ), + ).toHaveLength(1); + expect( + within(screen.getByLabelText("Grouping comparison")).queryByLabelText( + "Leftover-map graphic incomplete items", + ), + ).not.toBeInTheDocument(); expect( within(screen.getByLabelText("Grouping comparison")).queryByLabelText("Leftover map item coverage"), ).not.toBeInTheDocument(); diff --git a/frontend/src/components/LeftoverMapPlot.stories.tsx b/frontend/src/components/LeftoverMapPlot.stories.tsx index 4adae30c8..5b263468a 100644 --- a/frontend/src/components/LeftoverMapPlot.stories.tsx +++ b/frontend/src/components/LeftoverMapPlot.stories.tsx @@ -178,3 +178,17 @@ export const ComparisonMissingIncompletePosts: Story = { }, }, }; + +export const ComparisonMissingIncompleteItems: Story = { + args: { + variant: "comparison", + leftoverMapCoverage: { + map_post_count: 2, + scored_post_count: 3, + map_item_count: 2, + scored_item_count: 2, + incomplete_post_count: 1, + incomplete_item_count: 1, + }, + }, +}; diff --git a/frontend/src/components/LeftoverMapPlot.test.tsx b/frontend/src/components/LeftoverMapPlot.test.tsx index 45def7584..148501159 100644 --- a/frontend/src/components/LeftoverMapPlot.test.tsx +++ b/frontend/src/components/LeftoverMapPlot.test.tsx @@ -924,6 +924,9 @@ describe("LeftoverMapPlot", () => { expect(screen.getByLabelText("Leftover map comparison graphic incomplete posts")).toHaveTextContent( "Leftover map dropped 1 incomplete posts", ); + expect(screen.getByLabelText("Leftover map comparison graphic incomplete items")).toHaveTextContent( + "Leftover map dropped 0 incomplete criteria", + ); expect(screen.queryByLabelText("Leftover-map graphic coverage")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover map comparison coverage")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover-map graphic item coverage")).not.toBeInTheDocument(); @@ -931,6 +934,7 @@ describe("LeftoverMapPlot", () => { expect(screen.queryByLabelText("Leftover-map graphic incomplete posts")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover map comparison incomplete posts")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover-map graphic incomplete items")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("Leftover map comparison incomplete items")).not.toBeInTheDocument(); expect(screen.getByText("leftover map comparison axis 1 (82%)")).toBeInTheDocument(); expect(screen.getByText("leftover map comparison axis 2 (18%)")).toBeInTheDocument(); }); @@ -1092,6 +1096,70 @@ describe("LeftoverMapPlot", () => { expect(screen.getByText("leftover map comparison axis 1 (82%)")).toBeInTheDocument(); }); + it("omits leftover-map comparison graphic incomplete items when incomplete item coverage is missing or not usable", () => { + const { rerender } = render( + , + ); + expect(screen.getByLabelText("Leftover map comparison graphic coverage")).toHaveTextContent( + "Leftover map used 2 of 3 scored posts (complete-case)", + ); + expect(screen.getByLabelText("Leftover map comparison graphic item coverage")).toHaveTextContent( + "Leftover map used 2 of 2 scored criteria (complete-case)", + ); + expect(screen.getByLabelText("Leftover map comparison graphic incomplete posts")).toHaveTextContent( + "Leftover map dropped 1 incomplete posts", + ); + expect(screen.queryByLabelText("Leftover map comparison graphic incomplete items")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("Leftover-map graphic incomplete items")).not.toBeInTheDocument(); + expect(screen.getByText("leftover map comparison axis 1 (82%)")).toBeInTheDocument(); + rerender( + , + ); + expect(screen.getByLabelText("Leftover map comparison graphic coverage")).toHaveTextContent( + "Leftover map used 2 of 3 scored posts (complete-case)", + ); + expect(screen.getByLabelText("Leftover map comparison graphic incomplete posts")).toHaveTextContent( + "Leftover map dropped 1 incomplete posts", + ); + expect(screen.queryByLabelText("Leftover map comparison graphic incomplete items")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("Leftover-map graphic incomplete items")).not.toBeInTheDocument(); + expect(screen.getByText("leftover map comparison axis 1 (82%)")).toBeInTheDocument(); + }); + it("names leftover-map comparison graphic coverage 0 of M on a rank-0 origin when that persisted used count is a non-negative integer", () => { render( { expect(screen.getByLabelText("Leftover map comparison graphic incomplete posts")).toHaveTextContent( "Leftover map dropped 3 incomplete posts", ); + expect(screen.getByLabelText("Leftover map comparison graphic incomplete items")).toHaveTextContent( + "Leftover map dropped 2 incomplete criteria", + ); expect(screen.queryByLabelText("Leftover-map graphic coverage")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover-map graphic item coverage")).not.toBeInTheDocument(); expect(screen.queryByLabelText("Leftover-map graphic incomplete posts")).not.toBeInTheDocument(); + expect(screen.queryByLabelText("Leftover-map graphic incomplete items")).not.toBeInTheDocument(); expect(screen.getByText("leftover map comparison axis 1 (0%)")).toBeInTheDocument(); expect(screen.getByText("leftover map comparison axis 2 (0%)")).toBeInTheDocument(); }); diff --git a/frontend/src/components/LeftoverMapPlot.tsx b/frontend/src/components/LeftoverMapPlot.tsx index fe1b4ad08..d8a1c145e 100644 --- a/frontend/src/components/LeftoverMapPlot.tsx +++ b/frontend/src/components/LeftoverMapPlot.tsx @@ -9,6 +9,7 @@ import { LEFTOVER_MAP_COMPARE_PLOT_COVERAGE_LABEL, LEFTOVER_MAP_COMPARE_PLOT_ITEM_COVERAGE_LABEL, LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_POST_LABEL, + LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL, LEFTOVER_MAP_PLOT_COVERAGE, LEFTOVER_MAP_PLOT_COVERAGE_LABEL, LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM, @@ -133,8 +134,10 @@ function leftoverMapPlotAxisText( * labels and does not caption leftover-map incomplete item coverage on that * comparison plot. ADR 0308 captions leftover-map incomplete post coverage * on that comparison graphic from already-named leftover-map coverage with - * distinct leftover map comparison graphic incomplete posts labels and does - * not caption leftover-map incomplete item coverage on that comparison plot. + * distinct leftover map comparison graphic incomplete posts labels. ADR 0309 + * captions leftover-map incomplete item coverage on that comparison graphic + * from already-named leftover-map coverage with distinct leftover map + * comparison graphic incomplete items labels. * Never invent a leftover score. */ export function LeftoverMapPlot({ @@ -208,11 +211,15 @@ export function LeftoverMapPlot({ {tf(LEFTOVER_MAP_PLOT_INCOMPLETE_POST, incompletePostCount)}

) : null} - {variant !== "comparison" && incompleteItemCount !== null ? ( + {incompleteItemCount !== null ? (

{tf(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM, incompleteItemCount)}

diff --git a/frontend/src/components/LeftoverPairList.tsx b/frontend/src/components/LeftoverPairList.tsx index a034c548b..12da39370 100644 --- a/frontend/src/components/LeftoverPairList.tsx +++ b/frontend/src/components/LeftoverPairList.tsx @@ -112,7 +112,9 @@ export type LeftoverPairListProps = { * leftover-map graphic, not this pair list. ADR 0307 captions leftover-map * item complete-case coverage on that grouping comparison leftover-map graphic, * not this pair list. ADR 0308 captions leftover-map incomplete post coverage - * on that grouping comparison leftover-map graphic, not this pair list. Every badge still + * on that grouping comparison leftover-map graphic, not this pair list. ADR 0309 + * captions leftover-map incomplete item coverage on that grouping comparison + * leftover-map graphic, not this pair list. Every badge still * renders together before opening the named post. */ export function LeftoverPairList({ diff --git a/frontend/src/i18n.test.ts b/frontend/src/i18n.test.ts index b0a7f0ad1..a67fb7349 100644 --- a/frontend/src/i18n.test.ts +++ b/frontend/src/i18n.test.ts @@ -84,6 +84,7 @@ describe("i18n", () => { "Leftover map comparison incomplete posts", "Leftover map comparison graphic incomplete posts", "Leftover map comparison incomplete items", + "Leftover map comparison graphic incomplete items", "Leftover map comparison reconstruction", "Leftover map comparison explained leftover share", "Leftover map comparison unexplained leftover share", @@ -473,6 +474,16 @@ describe("i18n", () => { expect(t("Leftover map comparison incomplete items")).toBe(expected); }); + it.each([ + ["ko", "잔여 지도 비교 그림 불완전 기준"], + ["zh", "残差地图比较图形不完整准则"], + ["ja", "残差マップの比較図不完全基準"], + ["vi", "Tiêu chí không đầy đủ đồ họa so sánh trên bản đồ phần dư"], + ] as const)("formats leftover map comparison graphic incomplete items label in %s", (locale, expected) => { + setLocale(locale); + expect(t("Leftover map comparison graphic incomplete items")).toBe(expected); + }); + it.each([ ["ko", "잔여 지도 비교 재구성"], ["zh", "残差地图比较重建"], diff --git a/frontend/src/i18n.ts b/frontend/src/i18n.ts index 911b94e9f..80217f2f7 100644 --- a/frontend/src/i18n.ts +++ b/frontend/src/i18n.ts @@ -275,6 +275,7 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison incomplete posts": "잔여 지도 비교 불완전 글", "Leftover map comparison graphic incomplete posts": "잔여 지도 비교 그림 불완전 글", "Leftover map comparison incomplete items": "잔여 지도 비교 불완전 기준", + "Leftover map comparison graphic incomplete items": "잔여 지도 비교 그림 불완전 기준", "Leftover map comparison reconstruction": "잔여 지도 비교 재구성", "Leftover map comparison explained leftover share": "잔여 지도 비교 설명 잔여 점유율", "Leftover map comparison unexplained leftover share": "잔여 지도 비교 미설명 잔여 점유율", @@ -905,6 +906,7 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison incomplete posts": "残差地图比较不完整帖文", "Leftover map comparison graphic incomplete posts": "残差地图比较图形不完整帖文", "Leftover map comparison incomplete items": "残差地图比较不完整准则", + "Leftover map comparison graphic incomplete items": "残差地图比较图形不完整准则", "Leftover map comparison reconstruction": "残差地图比较重建", "Leftover map comparison explained leftover share": "残差地图比较已解释残差份额", "Leftover map comparison unexplained leftover share": "残差地图比较未解释残差份额", @@ -1556,6 +1558,7 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison incomplete posts": "残差マップの比較不完全投稿", "Leftover map comparison graphic incomplete posts": "残差マップの比較図不完全投稿", "Leftover map comparison incomplete items": "残差マップの比較不完全基準", + "Leftover map comparison graphic incomplete items": "残差マップの比較図不完全基準", "Leftover map comparison reconstruction": "残差マップの比較再構成", "Leftover map comparison explained leftover share": "残差マップの比較説明済み残差割合", "Leftover map comparison unexplained leftover share": "残差マップの比較未説明残差割合", @@ -2186,6 +2189,7 @@ const TRANSLATIONS: Partial>> = { "Leftover map comparison incomplete posts": "Bài không đầy đủ so sánh trên bản đồ phần dư", "Leftover map comparison graphic incomplete posts": "Bài không đầy đủ đồ họa so sánh trên bản đồ phần dư", "Leftover map comparison incomplete items": "Tiêu chí không đầy đủ so sánh trên bản đồ phần dư", + "Leftover map comparison graphic incomplete items": "Tiêu chí không đầy đủ đồ họa so sánh trên bản đồ phần dư", "Leftover map comparison reconstruction": "Tái dựng so sánh bản đồ phần dư", "Leftover map comparison explained leftover share": "Phần dư giải thích so sánh bản đồ phần dư", "Leftover map comparison unexplained leftover share": "Phần dư chưa giải thích so sánh bản đồ phần dư", diff --git a/frontend/src/leftoverMapCoverage.test.ts b/frontend/src/leftoverMapCoverage.test.ts index 871539c56..cbdda8d0c 100644 --- a/frontend/src/leftoverMapCoverage.test.ts +++ b/frontend/src/leftoverMapCoverage.test.ts @@ -12,6 +12,7 @@ import { LEFTOVER_MAP_COMPARE_PLOT_COVERAGE_LABEL, LEFTOVER_MAP_COMPARE_PLOT_ITEM_COVERAGE_LABEL, LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_POST_LABEL, + LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL, LEFTOVER_MAP_LIST_COVERAGE_LABEL, LEFTOVER_MAP_LIST_INCOMPLETE_ITEM_LABEL, LEFTOVER_MAP_LIST_INCOMPLETE_POST_LABEL, @@ -258,4 +259,16 @@ describe("leftoverMapIncompleteItemCount", () => { expect(LEFTOVER_MAP_COMPARE_INCOMPLETE_ITEM_LABEL).not.toBe(LEFTOVER_MAP_LIST_INCOMPLETE_ITEM_LABEL); expect(LEFTOVER_MAP_COMPARE_INCOMPLETE_ITEM_LABEL).not.toBe(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM_LABEL); }); + + it("keeps the grouping comparison graphic incomplete item label distinct from the pair-list, graphic, strip, and comparison graphic incomplete post labels", () => { + expect(LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL).toBe( + "Leftover map comparison graphic incomplete items", + ); + expect(LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL).not.toBe(LEFTOVER_MAP_LIST_INCOMPLETE_ITEM_LABEL); + expect(LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL).not.toBe(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM_LABEL); + expect(LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL).not.toBe(LEFTOVER_MAP_COMPARE_INCOMPLETE_ITEM_LABEL); + expect(LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL).not.toBe( + LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_POST_LABEL, + ); + }); }); diff --git a/frontend/src/leftoverMapCoverage.ts b/frontend/src/leftoverMapCoverage.ts index 7521ce431..fe56e1883 100644 --- a/frontend/src/leftoverMapCoverage.ts +++ b/frontend/src/leftoverMapCoverage.ts @@ -1,4 +1,4 @@ -/** Leftover-map complete-case coverage after IRT main effects (ADR 0168 / ADR 0281 / ADR 0282 / ADR 0283 / ADR 0284 / ADR 0285 / ADR 0286 / ADR 0287 / ADR 0288 / ADR 0289 / ADR 0290 / ADR 0291 / ADR 0292 / ADR 0306 / ADR 0307 / ADR 0308). */ +/** Leftover-map complete-case coverage after IRT main effects (ADR 0168 / ADR 0281 / ADR 0282 / ADR 0283 / ADR 0284 / ADR 0285 / ADR 0286 / ADR 0287 / ADR 0288 / ADR 0289 / ADR 0290 / ADR 0291 / ADR 0292 / ADR 0306 / ADR 0307 / ADR 0308 / ADR 0309). */ import type { LeftoverMapCoverage } from "./api"; @@ -23,6 +23,9 @@ export const LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_POST_LABEL = export const LEFTOVER_MAP_COMPARE_INCOMPLETE_ITEM_LABEL = "Leftover map comparison incomplete items"; +export const LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL = + "Leftover map comparison graphic incomplete items"; + export const LEFTOVER_MAP_PLOT_COVERAGE = "Leftover map used {used} of {scored} scored posts (complete-case)"; diff --git a/frontend/src/leftoverMapPlotLayout.ts b/frontend/src/leftoverMapPlotLayout.ts index 17b5c83cc..d63903e4c 100644 --- a/frontend/src/leftoverMapPlotLayout.ts +++ b/frontend/src/leftoverMapPlotLayout.ts @@ -35,8 +35,9 @@ * (ADR 0304), grouping comparison leftover-map axis share on that * graphic (ADR 0305), grouping comparison leftover-map complete-case * coverage on that graphic (ADR 0306), grouping comparison leftover-map - * item complete-case coverage on that graphic (ADR 0307), and grouping comparison leftover-map - * incomplete post coverage on that graphic (ADR 0308) caption the pair list or the grouping comparison + * item complete-case coverage on that graphic (ADR 0307), grouping comparison leftover-map + * incomplete post coverage on that graphic (ADR 0308), and grouping comparison leftover-map + * incomplete item coverage on that graphic (ADR 0309) caption the pair list or the grouping comparison * strip. ADR 0304 reuses this graphic layout on the grouping comparison * strip. ADR 0305 captions leftover-map axis share on that comparison * graphic from already-named leftover-map axes. ADR 0306 captions leftover-map @@ -44,8 +45,8 @@ * coverage. ADR 0307 captions leftover-map item complete-case coverage on that * comparison graphic from already-named leftover-map coverage. ADR 0308 captions leftover-map * incomplete post coverage on that comparison graphic from already-named leftover-map - * coverage and does not caption leftover-map incomplete item coverage on that - * comparison plot. + * coverage. ADR 0309 captions leftover-map incomplete item coverage on that + * comparison graphic from already-named leftover-map coverage. */ import { formatLeftoverMapCoordinatePair } from "./leftoverMapCoordinates"; diff --git a/pyproject.toml b/pyproject.toml index 80ae7f8e9..f43e3ee7a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "lineageweave" -version = "2.65.0" +version = "2.66.0" description = "Reconstructs git-branch-style lineage DAGs from scattered short records using multi-channel score fusion and LLM adjudication." readme = "README.md" license = { text = "MIT" }