From e79137611f0d3041ad836c21e49a95bf7ef1001e Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Sun, 30 Aug 2026 15:31:29 +0000 Subject: [PATCH 1/9] feat(reports): leftover-map axis share on grouping comparison strip (v2.50.0) Caption persisted leftover-map axis share on GET /api/reports/compare/{period} through leftoverMapCompareAxisShare (ADR 0293). Distinct aria-label Leftover map comparison axis share. Omit missing or non-finite share. Do not invent leftover-map axis share from leftover-map singular value. No SQL. No leftover score or theta. --- AGENTS.md | 8 + ARCHITECTURE.md | 2 + .../2.50.0-leftover-map-compare-axis-share.md | 39 ++++ CHANGELOG.md | 39 ++++ CLAUDE.md | 2 +- backend/app/report_ingestion.py | 25 +++ backend/tests/test_api.py | 9 + .../0293-leftover-map-compare-axis-share.md | 180 ++++++++++++++++++ docs/product-technical-gap-baseline.md | 71 +++++++ docs/storybook-inventory.md | 2 +- frontend/package.json | 2 +- frontend/src/App.test.tsx | 36 ++++ frontend/src/App.tsx | 20 ++ frontend/src/api.ts | 1 + frontend/src/components/LeftoverPairList.tsx | 4 +- frontend/src/i18n.test.ts | 2 + frontend/src/i18n.ts | 8 + frontend/src/leftoverMapCompareAxis.test.ts | 65 +++++++ frontend/src/leftoverMapCompareAxis.ts | 34 ++++ frontend/src/leftoverMapPlotLayout.ts | 5 +- pyproject.toml | 2 +- 21 files changed, 549 insertions(+), 7 deletions(-) create mode 100644 CHANGELOG.d/2.50.0-leftover-map-compare-axis-share.md create mode 100644 docs/adr/0293-leftover-map-compare-axis-share.md create mode 100644 frontend/src/leftoverMapCompareAxis.test.ts create mode 100644 frontend/src/leftoverMapCompareAxis.ts diff --git a/AGENTS.md b/AGENTS.md index 30380bc66..9f55e640a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -416,6 +416,14 @@ dropped count that contradicts usable item complete-case integers, omits that le comparison incomplete item note and does not invent dropped criteria from scored minus used or from leftover pair count. Dropped `0` is shown when persisted. The strip does not gain the leftover-map graphic. +ADR 0293 captions the grouping comparison strip with persisted leftover-map +axis share through leftoverMapCompareAxisShare so a buyer who compares leftover +pairs can read Gabriel inertia of residual SVD axes 1 and 2 for that grouping; +a missing or non-finite share omits that leftover-map comparison axis share +badge and does not invent leftover-map axis share from leftover-map singular +value, leftover pair count, or plotted marker count. Share `0` is shown when +persisted, including rank-0 unused axes. The strip does not gain leftover-map +singular values or the leftover-map graphic. When `R`, `R̂`, `U`, `x`, `s`, and `e` are finite, `e + s + x = 1`. When `Y`, `E`, and `R` are finite, `Y − E = R`. When `R`, `R̂`, and `U` are diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index 346afb687..dd6bc8a4e 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -675,6 +675,8 @@ ADR 0291 captions the grouping comparison strip with persisted leftover-map inco post coverage through leftoverMapIncompletePostCount. ADR 0292 captions the grouping comparison strip with persisted leftover-map incomplete item coverage through leftoverMapIncompleteItemCount. +ADR 0293 captions the grouping comparison strip with persisted leftover-map axis share +through leftoverMapCompareAxisShare. Click a post marker or a pair button opens that post. Those ADRs are the normative mathematical, storage, and display contracts. Leftover-map axis share diff --git a/CHANGELOG.d/2.50.0-leftover-map-compare-axis-share.md b/CHANGELOG.d/2.50.0-leftover-map-compare-axis-share.md new file mode 100644 index 000000000..683f6bf52 --- /dev/null +++ b/CHANGELOG.d/2.50.0-leftover-map-compare-axis-share.md @@ -0,0 +1,39 @@ +## 2.50.0 — Leftover-map axis share on the grouping comparison strip + +- Caption leftover-map axis share on the grouping comparison strip through + leftoverMapCompareAxisShare (ADR 0293). After `make seed`, closest and + farthest leftover pairs sit above the member list with the Gabriel biplot + of already-named coordinates, leftover-map axis share when finite, axis + ticks that match `ξ (x, y) ζ (x, y)` on the pair row, pair segments that + match `d` on the pair row, pair segments that match `R̂` on the pair row, + pair segments that match `R̂²/R²` on the pair row, pair segments that match + `U²/R²` on the pair row, pair segments that match `2R̂U/R²` on the pair + row, pair segments that match `U` on the pair row, pair segments that + match `R` on the pair row, pair segments that match `Y` on the pair row, + pair segments that match `E` on the pair row, pair segments that match + leftover-map rank on the pair row, a plot caption that matches leftover-map + complete-case coverage above the pair list, a plot caption that matches + leftover-map item complete-case coverage, a plot caption that matches + leftover-map incomplete post coverage, a plot caption that matches + leftover-map incomplete item coverage, a pair-list note that matches + leftover-map post complete-case coverage, a pair-list note that matches + leftover-map item complete-case coverage, a pair-list note that matches + leftover-map incomplete post coverage, a pair-list note that matches + leftover-map incomplete item coverage, a grouping comparison note that + matches leftover-map post complete-case coverage, a grouping comparison + note that matches leftover-map item complete-case coverage, a grouping + comparison note that matches leftover-map incomplete post coverage, a + grouping comparison note that matches leftover-map incomplete item + coverage, and a grouping comparison leftover-map axis share badge that + matches leftover-axis report badges; click a post marker or a pair button + opens that post. A missing or non-finite share omits that leftover-map + comparison axis share badge. Share `0` is shown when that persisted share + is a finite number, including rank-0 unused axes. A finite negative share + is shown; do not clamp to nonnegative. Do not invent leftover-map axis + share from leftover-map singular value, leftover pair count, plotted + marker count, leftover-map distance, leftover-map rank, leftover-map post + coverage, leftover-map item coverage, leftover-map incomplete post + coverage, leftover-map incomplete item coverage, or the count of unused + axes. The strip does not gain leftover-map singular values or the + leftover-map graphic. Never invent a leftover score. Never invent a + theta. No new columns. diff --git a/CHANGELOG.md b/CHANGELOG.md index a416d2f8b..2706f7c31 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,45 @@ All notable changes to this project are documented here. Format follows ### Added +- Period leftover pairs now caption the grouping comparison strip with + persisted leftover-map axis share through leftoverMapCompareAxisShare + (ADR 0293 / v2.50.0). After `make seed`, closest and farthest leftover + pairs sit above the member list with the Gabriel biplot of already-named + coordinates, leftover-map axis share when finite, axis ticks that match + `ξ (x, y) ζ (x, y)` on the pair row, pair segments that match `d` on the + pair row, pair segments that match `R̂` on the pair row, pair segments + that match `R̂²/R²` on the pair row, pair segments that match `U²/R²` on + the pair row, pair segments that match `2R̂U/R²` on the pair row, pair + segments that match `U` on the pair row, pair segments that match `R` on + the pair row, pair segments that match `Y` on the pair row, pair + segments that match `E` on the pair row, pair segments that match + leftover-map rank on the pair row, a plot caption that matches leftover-map + complete-case coverage above the pair list, a plot caption that matches + leftover-map item complete-case coverage, a plot caption that matches + leftover-map incomplete post coverage, a plot caption that matches + leftover-map incomplete item coverage, a pair-list note that matches + leftover-map post complete-case coverage, a pair-list note that matches + leftover-map item complete-case coverage, a pair-list note that matches + leftover-map incomplete post coverage, a pair-list note that matches + leftover-map incomplete item coverage, a grouping comparison note that + matches leftover-map post complete-case coverage, a grouping comparison + note that matches leftover-map item complete-case coverage, a grouping + comparison note that matches leftover-map incomplete post coverage, a + grouping comparison note that matches leftover-map incomplete item + coverage, and a grouping comparison leftover-map axis share badge that + matches leftover-axis report badges; click a post marker or a pair button + opens that post. A missing or non-finite share omits that leftover-map + comparison axis share badge. Share `0` is shown when that persisted share + is a finite number, including rank-0 unused axes. A finite negative share + is shown; do not clamp to nonnegative. Do not invent leftover-map axis + share from leftover-map singular value, leftover pair count, plotted + marker count, leftover-map distance, leftover-map rank, leftover-map post + coverage, leftover-map item coverage, leftover-map incomplete post + coverage, leftover-map incomplete item coverage, or the count of unused + axes. The strip does not gain leftover-map singular values or the + leftover-map graphic. Never invent a leftover score or a theta. No new + columns. + - Period leftover pairs now caption the grouping comparison strip with persisted leftover-map incomplete item coverage through leftoverMapIncompleteItemCount (ADR 0292 / v2.49.0). After `make seed`, diff --git a/CLAUDE.md b/CLAUDE.md index 3a6fbb514..1963b8114 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -49,7 +49,7 @@ cutoff. Global Ask optional `knowledge_cutoff` uses the same cover Create/start endpoint rules (ADR 0017 / 0021), tie-vs-miss similarity (ADR 0026), R&R catalog ids (ADR 0019 / 0027), leftover pairs -(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292), occupational construct catalog search +(ADR 0048–0164 / 0182 / 0185 / 0201 / 0233 / 0266 / 0267 / 0268 / 0269 / 0270 / 0271 / 0272 / 0273 / 0274 / 0275 / 0276 / 0277 / 0278 / 0279 / 0280 / 0281 / 0282 / 0283 / 0284 / 0285 / 0286 / 0287 / 0288 / 0289 / 0290 / 0291 / 0292 / 0293), occupational construct catalog search (ADR 0257), the text-channel embedding swap and cosine clamp (ADR 0190), per-edge channel-score persistence (ADR 0195), token-backed status notices (ADR 0220), diff --git a/backend/app/report_ingestion.py b/backend/app/report_ingestion.py index d675fe3ab..58c6c2dc4 100644 --- a/backend/app/report_ingestion.py +++ b/backend/app/report_ingestion.py @@ -1086,6 +1086,21 @@ async def fetch_period_comparison( leftover_coverage_by_key = { (row["grouping_kind"], row["grouping_key"]): row for row in leftover_coverage } + leftover_axes = await conn.fetch( + """ + select grouping_kind, grouping_key, axis_index, leftover_singular_value, leftover_share + from report_leftover_map_axis + where period_code = $1 and rubric_version = $2 + and grouping_kind = any($3::text[]) + order by grouping_kind, grouping_key, axis_index + """, + period_code, + RUBRIC_VERSION, + list(GROUPING_KINDS), + ) + leftover_axes_by_key: dict[tuple[str, str], list[asyncpg.Record]] = defaultdict(list) + for row in leftover_axes: + leftover_axes_by_key[(row["grouping_kind"], row["grouping_key"])].append(row) payload: list[dict[str, Any]] = [] for row in rows: label = await resolve_grouping_label(conn, row["grouping_kind"], row["grouping_key"]) @@ -1132,6 +1147,16 @@ async def fetch_period_comparison( "leftover_map_coverage": _leftover_map_coverage_payload( leftover_coverage_by_key.get((row["grouping_kind"], row["grouping_key"])) ), + "leftover_map_axes": [ + { + "axis_index": int(axis["axis_index"]), + "leftover_singular_value": float(axis["leftover_singular_value"]), + "leftover_share": float(axis["leftover_share"]), + } + for axis in leftover_axes_by_key.get( + (row["grouping_kind"], row["grouping_key"]), [] + ) + ], } ) return payload diff --git a/backend/tests/test_api.py b/backend/tests/test_api.py index 273a7ff94..95431c425 100644 --- a/backend/tests/test_api.py +++ b/backend/tests/test_api.py @@ -5836,6 +5836,15 @@ def test_seed_period_report_surfaces_on_get_reports(client, demo_analyst_token, assert leftover_compare_coverage["incomplete_post_count"] == ( leftover_compare_coverage["scored_post_count"] - leftover_compare_coverage["map_post_count"] ) + leftover_compare_axes = leftover_thread.get("leftover_map_axes", []) + assert [axis["axis_index"] for axis in leftover_compare_axes] == [1, 2] + assert all(isinstance(axis["leftover_share"], (int, float)) for axis in leftover_compare_axes) + assert all( + axis["leftover_share"] == axis["leftover_share"] for axis in leftover_compare_axes + ) + assert leftover_compare_axes[0]["leftover_share"] != leftover_compare_axes[0][ + "leftover_singular_value" + ] or leftover_compare_axes[0]["leftover_share"] in {0, 1} assert leftover_compare_coverage["map_item_count"] <= leftover_compare_coverage["scored_item_count"] assert leftover_compare_coverage["map_post_count"] != len( leftover_thread.get("leftover_pairs", []) diff --git a/docs/adr/0293-leftover-map-compare-axis-share.md b/docs/adr/0293-leftover-map-compare-axis-share.md new file mode 100644 index 000000000..f7fd01b5a --- /dev/null +++ b/docs/adr/0293-leftover-map-compare-axis-share.md @@ -0,0 +1,180 @@ +# ADR 0293 — Name leftover-map axis share on the grouping comparison strip + +**Decision status:** Accepted +**Date:** 2026-08-30 + +Amends leftover pairs on the grouping comparison strip +([ADR 0149](0149-leftover-pairs-on-comparison-strip.md)) and leftover-map +axis share persistence ([ADR 0148](0148-leftover-map-axis-share.md)). +Independent of leftover-map incomplete item coverage on the grouping +comparison strip ([ADR 0292](0292-leftover-map-compare-incomplete-item.md)), +leftover-map incomplete post coverage on the grouping comparison strip +([ADR 0291](0291-leftover-map-compare-incomplete-post.md)), leftover-map item +complete-case coverage on the grouping comparison strip +([ADR 0290](0290-leftover-map-compare-item-coverage.md)), leftover-map +complete-case coverage on the grouping comparison strip +([ADR 0289](0289-leftover-map-compare-coverage.md)), leftover-map post +complete-case coverage fail-closed on the pair list +([ADR 0288](0288-leftover-map-list-post-coverage-helper.md)), leftover-map +incomplete item coverage on the pair list +([ADR 0287](0287-leftover-map-list-incomplete-item.md)), leftover-map incomplete +post coverage on the pair list +([ADR 0286](0286-leftover-map-list-incomplete-post.md)), leftover-map item +complete-case coverage on the pair list +([ADR 0285](0285-leftover-map-list-item-coverage.md)), leftover-map incomplete +item coverage on the graphic display +([ADR 0284](0284-leftover-map-plot-incomplete-item.md)), leftover-map incomplete +post coverage on the graphic display +([ADR 0283](0283-leftover-map-plot-incomplete.md)), leftover-map item +complete-case coverage on the graphic display +([ADR 0282](0282-leftover-map-plot-item-coverage.md)), leftover-map complete-case +coverage on the graphic display +([ADR 0281](0281-leftover-map-plot-coverage.md)), leftover-map rank on pair +segments ([ADR 0280](0280-leftover-map-segment-rank.md)), leftover expected on pair +segments ([ADR 0279](0279-leftover-map-segment-expected.md)), leftover observed on +pair segments ([ADR 0278](0278-leftover-map-segment-observed.md)), leftover +residual on pair segments ([ADR 0277](0277-leftover-map-segment-residual.md)), +leftover-map unexplained leftover on pair segments +([ADR 0276](0276-leftover-map-segment-unexplained-leftover.md)), leftover-map +cross share on pair segments ([ADR 0275](0275-leftover-map-segment-cross-share.md)), +leftover-map unexplained leftover share on pair segments +([ADR 0274](0274-leftover-map-segment-unexplained-share.md)), leftover-map +explained leftover share on pair segments +([ADR 0273](0273-leftover-map-segment-explained-share.md)), leftover-map +reconstruction on pair segments +([ADR 0272](0272-leftover-map-segment-reconstruction.md)), leftover-map +distance on pair segments ([ADR 0271](0271-leftover-map-segment-distance.md)), +leftover-map coordinate ticks ([ADR 0270](0270-leftover-map-coordinate-ticks.md)), +leftover-map axis share on the graphic display +([ADR 0269](0269-leftover-map-axis-share-plot.md)), leftover residual +disclosure ([ADR 0162](0162-leftover-residual-disclosure.md)), leftover +observed `Y` / expected `E` ([ADR 0163](0163-leftover-observed-expected.md)), +leftover-map explained leftover share persistence +([ADR 0266](0266-leftover-map-explained-share.md)), leftover-map +unexplained leftover share persistence +([ADR 0233](0233-leftover-map-unexplained-share.md)), leftover-map +reconstruction persistence ([ADR 0201](0201-leftover-map-reconstruction.md)), +leftover-map cross share persistence +([ADR 0185](0185-leftover-map-cross-share.md)), leftover-map unexplained leftover +persistence ([ADR 0182](0182-leftover-map-unexplained.md)), leftover-map rank +persistence ([ADR 0164](0164-leftover-map-rank.md)), leftover-map complete-case +coverage persistence ([ADR 0168](0168-leftover-map-complete-case-coverage.md)), +and leftover-map graphic display ([ADR 0268](0268-leftover-map-graphic-display.md)). + +## Context + +ADR 0148 already persists leftover-map singular values `σ_k` and leftover-map +axis share `σ_k² / Σ_j σ_j²` on `report_leftover_map_axis` and captions +leftover-axis report badges with share. ADR 0269 already captions leftover-map +graphic axes with that same persisted share. ADR 0149 already carries +ABAC-filtered leftover pairs on `GET /api/reports/compare/{period}`. ADR 0289 +already includes leftover-map complete-case coverage on that comparison +payload. The grouping comparison strip still names leftover pairs, `d`, and +leftover-map coverage without naming leftover-map axis share for that grouping, +so a buyer who compares PU / corp / thread leftover pairs can treat a +rank-0 unused axis as if it had the same Gabriel inertia as an 82% first axis. + +This increment includes persisted leftover-map axes on the comparison payload +and captions each grouping row through leftoverMapCompareAxisShare. It does +not add columns. It does not invent leftover-map axis share from leftover-map +singular value, leftover pair count, plotted marker count, leftover-map +distance, leftover-map rank, leftover-map post coverage, leftover-map item +coverage, leftover-map incomplete post coverage, leftover-map incomplete item +coverage, or the count of unused axes. It does not persist leftover-map inner +product, cosine, or length as separate columns. Do not invent a leftover +score. Do not invent a theta. + +The dashboard stack already used neighbouring leftover facts under other +numbers. This protected increment uses **0293** so it does not collide with +leftover-map incomplete item coverage on the grouping comparison strip (0292), +leftover-map incomplete post coverage on the grouping comparison strip (0291), +leftover-map item complete-case coverage on the grouping comparison strip +(0290), leftover-map complete-case coverage on the grouping comparison strip +(0289), leftover-map post complete-case coverage fail-closed on the pair list +(0288), leftover-map incomplete item coverage on the pair list (0287), +leftover-map incomplete post coverage on the pair list (0286), leftover-map +item complete-case coverage on the pair list (0285), leftover-map incomplete +item coverage on the graphic display (0284), leftover-map incomplete post +coverage on the graphic display (0283), leftover-map item complete-case +coverage on the graphic display (0282), leftover-map complete-case coverage +on the graphic display (0281), leftover-map rank on pair segments (0280), +or the dashboard stacks. + +## Decision + +On the grouping comparison strip, include persisted `leftover_map_axes` on +each comparison row and caption leftover-map axis `k` as +`leftover map comparison axis {k} {share}%` only when leftoverMapCompareAxisShare +returns a usable share from persisted `leftover_share`. Use the distinct +accessible name `Leftover map comparison axis share` so the strip caption is +not the leftover-axis report badge (`leftover axis {k} {share}%`) and is not +the graphic caption (`leftover-map axis {k} ({share}%)`). A missing axis row +or a missing or non-finite share omits that leftover-map comparison axis +share badge and keeps the strip leftover-map post coverage note, leftover-map +item coverage note, leftover-map incomplete post note, leftover-map +incomplete item note, leftover pairs, leftover-map distance `d`, and any +leftover-map captions on the pair list and graphic. Share `0` is shown when +that persisted share is a finite number, including rank-0 unused axes. A +finite negative share is shown; do not clamp to nonnegative. Axis 1 and +axis 2 stay independently named. Do not invent leftover-map axis share from +leftover-map singular value, leftover pair count, plotted marker count, +leftover-map distance, leftover-map rank, leftover-map post coverage, +leftover-map item coverage, leftover-map incomplete post coverage, +leftover-map incomplete item coverage, or the count of unused axes. Do not +caption leftover-map singular values or the leftover-map graphic on the strip +in this increment. Click a leftover pair on the strip to open that post. + +Do not add SQL migrations. Do not edit shipped migrations. Do not persist inner +product, cosine, or length as separate columns. Do not invent a leftover +score. Do not invent a theta. + +## Consequences + +After `make seed`, the grouping comparison strip names persisted leftover-map +post complete-case coverage, persisted leftover-map item complete-case +coverage, persisted leftover-map incomplete post coverage, persisted +leftover-map incomplete item coverage, and persisted leftover-map axis share +on each grouping row when leftoverMapCoverageCounts / +leftoverMapItemCoverageCounts / leftoverMapIncompletePostCount / +leftoverMapIncompleteItemCount / leftoverMapCompareAxisShare return usable +values, then names leftover pairs with leftover-map distance `d`. Closest +and farthest leftover pairs still sit above the member list with the +leftover-map graphic display; click a post marker or a pair button opens that +post. +Hidden posts stay hidden. + +## Related + +Independent of leftover interaction-map persistence, leftover-criterion +evaluation landing, leftover residual disclosure, leftover-map +complete-case coverage persistence, leftover-map axis share persistence, +leftover pairs on the grouping comparison strip, leftover-map complete-case +coverage on the grouping comparison strip, leftover-map item complete-case +coverage on the grouping comparison strip, leftover-map incomplete post +coverage on the grouping comparison strip, leftover-map incomplete item +coverage on the grouping comparison strip, leftover-map inner product, +leftover-map cosine, leftover-map length, leftover-map graphic display, +leftover-map item complete-case coverage on the graphic display, leftover-map +item complete-case coverage on the pair list, leftover-map incomplete post +coverage on the graphic display, leftover-map incomplete post coverage on the +pair list, leftover-map incomplete item coverage on the graphic display, +leftover-map incomplete item coverage on the pair list, leftover-map post +complete-case coverage fail-closed on the pair list, leftover-map axis share +on the graphic display, and leftover-map singular values. + +## References + +Gabriel, K. R. (1971). The biplot graphic display of matrices with +application to principal component analysis. *Biometrika, 58*(3), +453–467. https://doi.org/10.1093/biomet/58.3.453 + +Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping +unobserved item–respondent interactions: A latent space item response +model with interaction map. *Psychometrika, 86*(2), 378–403. +https://doi.org/10.1007/s11336-021-09762-5 +(LSIRM interaction `−γ‖ξ_j − ζ_i‖` after main effects +`α_j − β_i`; typically `p = 2` for the interaction map. Leftover-map +axis share is Gabriel inertia `σ_k² / Σ_j σ_j²` of residual SVD axes; +grouping comparison leftover-map axis share names that persisted share +for that grouping only when leftoverMapCompareAxisShare returns a usable +share.) diff --git a/docs/product-technical-gap-baseline.md b/docs/product-technical-gap-baseline.md index f0befa176..6958ec3d1 100644 --- a/docs/product-technical-gap-baseline.md +++ b/docs/product-technical-gap-baseline.md @@ -1,5 +1,76 @@ # Product & Technical Gap Baseline +> Exact-head loop overlay: 2026-08-30 23:45 KST. Protected `main` is +> `cb187cadee5fb6c46d8a944815ccc154a1e028d1` after unauthorized squash +> of leftover-map coordinates (v2.24.0 / #782). Revert #808 +> (`revert-pr782-unauthorized` @ `1af3e53e`) restores `main` toward +> `fc13acaa` (v2.23.0) and still needs independent APPROVE. GitHub +> writes work (comment/close/create-PR/push). Token still has empty +> `X-OAuth-Scopes`; repo permission is ADMIN. Open leftover stack +> still lacks independent APPROVE. Do not self-approve. +> #782 leftover-map coordinates through pair-segment distance +> (v2.24.0–v2.28.0 / ADR 0267–0271) is `9bdd3e4d`. #802 explained +> leftover share on pair segments (v2.30.0 / ADR 0273, includes v2.29 +> reconstruction) is `79ec22f0`. #803 unexplained leftover share on pair +> segments (v2.31.0 / ADR 0274) is `089a1571`. #804 leftover-map cross +> share on pair segments (v2.32.0 / ADR 0275) is `c513002b`. #805 leftover-map +> unexplained leftover `U` on pair segments (v2.33.0 / ADR 0276) is +> `e3fdfd74`. #806 leftover residual `R` on pair segments (v2.34.0 / +> ADR 0277) is `33f6c3dd`. #809 leftover observed `Y` on pair segments +> (v2.35.0 / ADR 0278) is `b334b00e`. #810 leftover expected `E` on pair +> segments (v2.36.0 / ADR 0279) is `6e37757a`. #811 leftover-map rank on +> pair segments (v2.37.0 / ADR 0280) is `e626a1d0`. #812 leftover-map +> complete-case coverage on the graphic (v2.38.0 / ADR 0281) is `64964cb6`. +> #813 leftover-map item complete-case coverage on the graphic (v2.39.0 / +> ADR 0282) is `de2a8a8b`. #814 leftover-map incomplete post coverage on +> the graphic (v2.40.0 / ADR 0283) is `77292872`. #815 leftover-map +> incomplete item coverage on the graphic (v2.41.0 / ADR 0284) is +> `63092de`. #816 leftover-map item complete-case coverage on the pair +> list (v2.42.0 / ADR 0285) is `1e3d13e`. #817 leftover-map incomplete +> post coverage on the pair list (v2.43.0 / ADR 0286) is `ef30930`. +> #818 leftover-map incomplete item coverage on the pair list +> (v2.44.0 / ADR 0287) is `aa32089`. #819 leftover-map post complete-case +> coverage fail-closed on the pair list (v2.45.0 / ADR 0288) is `a2c96551`. +> #821 leftover-map complete-case coverage on the grouping comparison +> strip (v2.46.0 / ADR 0289) is `11a78553`. #822 leftover-map item +> complete-case coverage on the grouping comparison strip (v2.47.0 / +> ADR 0290) is `6726353a`. #823 leftover-map singular values on leftover-axis +> badges (v2.47.0 / ADR 0290, plot stack) is `eb172c40`. #824 leftover-map +> incomplete post coverage on the grouping comparison strip (v2.48.0 / +> ADR 0291) is `8b2ed95`. #825 leftover-map incomplete item coverage on +> the grouping comparison strip (v2.49.0 / ADR 0292) is `bca6baa`. Leave +> #782/#802/#803/#804/#805/#806/#808/#809/#810/#811/#812/#813/#814/#815/#816/#817/#818/#819/#821/#822/#823/#824/#825 open for +> independent review. Do not squash-merge stacked leftover PRs onto an +> unprotected leftover base. Do not merge #808 without independent APPROVE. +> Strix on #782 failed closed at `Run Strix (quick)`; do not weaken +> fail-closed on `Vulnerabilities [1-9]`. Org Strix `ModelBehaviorError` +> classifier is already on ContextualWisdomLab/.github. Copilot review is +> not independent APPROVE. Issues #79 and #87 stay open. #96 is already +> closed. Only collaborator is `seonghobae`; no independent reviewer can +> be requested from this token. +> +> Next buyer increment on this cycle: leftover-map axis share on the +> grouping comparison strip (ADR 0293 / v2.50.0) delivered locally on +> `feat/leftover-map-compare-axis-share-v2500`. Include persisted +> leftover_map_axes on GET /api/reports/compare/{period} and caption each +> grouping row through leftoverMapCompareAxisShare with distinct +> aria-label `Leftover map comparison axis share` and copy +> `leftover map comparison axis {axis} {share}%`. UI + compare payload; +> no new columns. Missing or non-finite share omits that leftover-map +> comparison axis share badge independently of coverage notes. Share `0` +> is shown when persisted, including rank-0 unused axes. Do not invent +> leftover-map axis share from leftover-map singular value, leftover pair +> count, plotted marker count, leftover-map distance, leftover-map rank, +> leftover-map post coverage, leftover-map item coverage, leftover-map +> incomplete post coverage, leftover-map incomplete item coverage, or the +> count of unused axes. Do not caption leftover-map singular values or the +> leftover-map graphic on the strip. Do not invent leftover scores. Stack +> onto leftover branch `feat/leftover-map-compare-incomplete-item-v2490` / +> #825; leave the PR open for independent review. Do not squash-merge onto +> the leftover base. Do not persist leftover-map inner product, cosine, or +> length as separate columns. + + > Exact-head loop overlay: 2026-08-30 23:28 KST. Protected `main` is > `cb187cadee5fb6c46d8a944815ccc154a1e028d1` after unauthorized squash > of leftover-map coordinates (v2.24.0 / #782). Revert #808 diff --git a/docs/storybook-inventory.md b/docs/storybook-inventory.md index 485085734..6852fca40 100644 --- a/docs/storybook-inventory.md +++ b/docs/storybook-inventory.md @@ -6,7 +6,7 @@ operator-facing control you can click before changing product CSS. | Story | Operator next action | Token / module | |---|---|---| | `Reports/LeftoverMapPlot` | Read the leftover-map graphic display of persisted `ξ` (posts) and `ζ` (criteria), match axis ticks to those coordinates, pair-segment `d` to leftover-map distance, pair-segment `R̂` to leftover-map reconstruction, pair-segment `R̂²/R²` to leftover-map explained leftover share, pair-segment `U²/R²` to leftover-map unexplained leftover share, pair-segment `2R̂U/R²` to leftover-map cross share, pair-segment `U` to leftover-map unexplained leftover, pair-segment `R` to leftover residual, pair-segment `Y` to leftover observed, pair-segment `E` to leftover expected, and pair-segment leftover-map rank, then click a post marker to open that post. Leftover-map axes name persisted leftover-map axis share when finite. The plot names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. `ClosestAndFarthest`, `RankZeroOrigin`, `MissingCoordinates`, and `MissingAxisShare` cover two-pair maps, rank-0 origin with 0% share, a `0` tick, `d 0.00`, `R̂ 0.00`, `R̂²/R² 0.00`, `U²/R² 0.00`, `2R̂U/R² 0.00`, `U 0.00`, `R 0.00`, `Y 0.00`, `E 0.00`, and `rank 0`, omitted plots, and missing share that keeps existing leftover-map axis text. The plot does not invent a leftover score. | `LeftoverMapPlot`, `leftoverMapPlotLayout`, `leftoverMapPlotAxisShare`, `--color-primary`, `--color-palette-blue-mid` | -| `Reports/LeftoverPairList` | Read closest/farthest leftover pairs with named `R`, `Y`/`E`, rank, `U`, `s`, `e`, `x`, `R̂`, `ξ`/`ζ`, and `d`, then open that post. The leftover-map graphic display sits above the pair buttons when coordinates are finite, leftover-map axes name persisted leftover-map axis share, leftover-map axis ticks name persisted coordinates, pair segments name persisted leftover-map distance, pair segments name persisted leftover-map reconstruction, pair segments name persisted leftover-map explained leftover share, pair segments name persisted leftover-map unexplained leftover share, pair segments name persisted leftover-map cross share, pair segments name persisted leftover-map unexplained leftover, pair segments name persisted leftover residual, pair segments name persisted leftover observed, pair segments name persisted leftover expected, and pair segments name persisted leftover-map rank. The pair-list note names leftover-map complete-case coverage only when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. The grouping comparison strip names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage with distinct comparison labels when leftoverMapCoverageCounts / leftoverMapItemCoverageCounts / leftoverMapIncompletePostCount / leftoverMapIncompleteItemCount return usable integers. | `LeftoverPairList`, `LeftoverMapPlot`, `ticket-list`, `post-badge` | +| `Reports/LeftoverPairList` | Read closest/farthest leftover pairs with named `R`, `Y`/`E`, rank, `U`, `s`, `e`, `x`, `R̂`, `ξ`/`ζ`, and `d`, then open that post. The leftover-map graphic display sits above the pair buttons when coordinates are finite, leftover-map axes name persisted leftover-map axis share, leftover-map axis ticks name persisted coordinates, pair segments name persisted leftover-map distance, pair segments name persisted leftover-map reconstruction, pair segments name persisted leftover-map explained leftover share, pair segments name persisted leftover-map unexplained leftover share, pair segments name persisted leftover-map cross share, pair segments name persisted leftover-map unexplained leftover, pair segments name persisted leftover residual, pair segments name persisted leftover observed, pair segments name persisted leftover expected, and pair segments name persisted leftover-map rank. The pair-list note names leftover-map complete-case coverage only when leftoverMapCoverageCounts returns usable complete-case integers, leftover-map item complete-case coverage, leftover-map incomplete post coverage, and leftover-map incomplete item coverage when persisted. The grouping comparison strip names leftover-map complete-case coverage, leftover-map item complete-case coverage, leftover-map incomplete post coverage, leftover-map incomplete item coverage, and leftover-map axis share with distinct comparison labels when leftoverMapCoverageCounts / leftoverMapItemCoverageCounts / leftoverMapIncompletePostCount / leftoverMapIncompleteItemCount / leftoverMapCompareAxisShare return usable values. | `LeftoverPairList`, `LeftoverMapPlot`, `ticket-list`, `post-badge` | | `Workspace/OperationsDashboard` | Compare Event and post counts, inspect external-information coverage, then open the cited source behind a claim, handover, or repeat-issue fact. `EvidenceReady`, `NarrowViewport`, `AnalysisPendingAndMissingEvidence`, `AnalysisFailed`, and `LoadError` cover populated, mobile, unavailable-evidence, analysis-pending, retryable failure, and transport-error states. | `--color-dashboard-*`, `OperationsDashboard` | | `Post/SimilarVocPanel` | Compare ontology/semantic similar VOC and prior action evidence, then open the source; unavailable states show no fabricated TEPP theta or weight. | `SimilarVocPanel.css`, `SimilarVocPanel` | | `Post/Recorded perspectives` | Read the imported primary and every evidence-connected additional Voice with its recorded truth state instead of flattening them into one compound category. `CombinedEvidence`, `RejectedEvidence`, and `NarrowViewport` cover desktop, rejected-evidence, and narrow layouts. | `VoicePerspectiveList`, `ticket-list`, `post-meta` | diff --git a/frontend/package.json b/frontend/package.json index 8fa819fcf..497940a94 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,7 +1,7 @@ { "name": "frontend", "private": true, - "version": "2.49.0", + "version": "2.50.0", "type": "module", "scripts": { "dev": "vite", diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx index 283e671ac..129526d0f 100644 --- a/frontend/src/App.test.tsx +++ b/frontend/src/App.test.tsx @@ -898,6 +898,10 @@ describe("App, authenticated", () => { incomplete_post_count: 0, incomplete_item_count: 0, }, + leftover_map_axes: [ + { axis_index: 1, leftover_singular_value: 0, leftover_share: 0 }, + { axis_index: 2, leftover_singular_value: 0, leftover_share: 0 }, + ], }, { grouping_kind: "corporate_entity", @@ -932,6 +936,10 @@ describe("App, authenticated", () => { incomplete_post_count: 1, incomplete_item_count: 0, }, + leftover_map_axes: [ + { axis_index: 1, leftover_singular_value: 1.84, leftover_share: 0.82 }, + { axis_index: 2, leftover_singular_value: 0.86, leftover_share: 0.18 }, + ], }, ], }), @@ -4323,6 +4331,34 @@ describe("App, authenticated", () => { "Leftover-map graphic incomplete items", ), ).not.toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).queryByLabelText("Leftover-map axis share"), + ).not.toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).getAllByLabelText( + "Leftover map comparison axis share", + ), + ).toHaveLength(4); + expect( + within(screen.getByLabelText("Grouping comparison")).getAllByLabelText( + "Leftover map comparison axis share", + )[0], + ).toHaveTextContent("leftover map comparison axis 1 0%"); + expect( + within(screen.getByLabelText("Grouping comparison")).getByText("leftover map comparison axis 1 82%"), + ).toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).getByText("leftover map comparison axis 2 18%"), + ).toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).queryByText("leftover axis 1 82%"), + ).not.toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).queryByText(/leftover-map axis 1/), + ).not.toBeInTheDocument(); + expect( + within(screen.getByLabelText("Grouping comparison")).queryByText(/σ 1\.84/), + ).not.toBeInTheDocument(); expect( screen.getByRole("button", { name: "Compare Business unit (PU): Demo Report High, mean θ 0.81" }), ).toHaveTextContent("mean θ 0.81"); diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx index 1255ff43c..7d77c77eb 100644 --- a/frontend/src/App.tsx +++ b/frontend/src/App.tsx @@ -137,6 +137,11 @@ import { LEFTOVER_MAP_PLOT_INCOMPLETE_POST, LEFTOVER_MAP_PLOT_ITEM_COVERAGE, } from "./leftoverMapCoverage"; +import { + leftoverMapCompareAxisShare, + LEFTOVER_MAP_COMPARE_AXIS_SHARE, + LEFTOVER_MAP_COMPARE_AXIS_SHARE_LABEL, +} from "./leftoverMapCompareAxis"; import "./App.css"; const AdminPanel = lazy(() => import("./components/AdminPanel").then((module) => ({ default: module.AdminPanel }))); @@ -4049,6 +4054,21 @@ function ReportsPanel({ {tf(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM, comparisonIncompleteItemCount)}

) : null} + {row.leftover_map_axes?.map((axis) => { + const comparisonAxisShare = leftoverMapCompareAxisShare(axis); + if (comparisonAxisShare === null) { + return null; + } + return ( + + {tf(LEFTOVER_MAP_COMPARE_AXIS_SHARE, comparisonAxisShare)} + + ); + })} {row.leftover_pairs && row.leftover_pairs.length > 0 && (