From 02c4396d646fcff6912951313d1dc4a1f56d833d Mon Sep 17 00:00:00 2001 From: Seongho Bae Date: Sun, 23 Aug 2026 21:52:40 +0000 Subject: [PATCH 1/2] feat: name leftover-map reconstruction on leftover pairs (v2.12.25) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Persist two-axis Gabriel reconstruction R̂ = ξ_{1:2} · ζ_{1:2} on leftover post–criterion pairs so leftover residual R and leftover-map distance d are not read as the reconstructed leftover cell. After make seed, closest/farthest pairs sit above the member list with R̂ next to leftover-map distance d; click opens that post. --- AGENTS.md | 7 +- ARCHITECTURE.md | 4 +- .../2.12.25-leftover-map-reconstruction.md | 8 ++ CHANGELOG.md | 9 ++ CLAUDE.md | 4 +- backend/app/report_ingestion.py | 14 ++- backend/tests/test_api.py | 9 ++ docker/postgres-init/migrate.sh | 2 +- .../0003-fast-mlsirm-report-integration.md | 7 +- docs/adr/0048-persist-lsirm-leftover-pairs.md | 6 +- docs/adr/0049-leftover-pair-report-ui.md | 8 +- docs/adr/0181-leftover-map-reconstruction.md | 85 +++++++++++++ frontend/package.json | 2 +- frontend/src/App.test.tsx | 8 +- frontend/src/App.tsx | 37 ++++-- frontend/src/api.ts | 1 + frontend/src/i18n.test.ts | 34 +++++ frontend/src/i18n.ts | 44 +++++++ .../src/leftoverMapReconstruction.test.ts | 22 ++++ frontend/src/leftoverMapReconstruction.ts | 26 ++++ lineageweave/leftover_pairs.py | 118 +++++++++++++----- ...181_report_leftover_map_reconstruction.sql | 8 ++ ...181_report_leftover_map_reconstruction.sql | 4 + pyproject.toml | 2 +- scripts/seed_demo_data.py | 7 +- tests/test_leftover_pairs.py | 79 +++++++++++- tests/test_migration_replay.py | 1 + tests/test_period_report.py | 2 + tests/test_schema.py | 21 ++++ uv.lock | 2 +- 30 files changed, 520 insertions(+), 61 deletions(-) create mode 100644 CHANGELOG.d/2.12.25-leftover-map-reconstruction.md create mode 100644 docs/adr/0181-leftover-map-reconstruction.md create mode 100644 frontend/src/leftoverMapReconstruction.test.ts create mode 100644 frontend/src/leftoverMapReconstruction.ts create mode 100644 migrations/0181_report_leftover_map_reconstruction.sql create mode 100644 migrations/rollback/0181_report_leftover_map_reconstruction.sql diff --git a/AGENTS.md b/AGENTS.md index 1728f9e61..9e6d8e7cb 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -186,12 +186,13 @@ in the same spirit) -- never against real data, per the hard rule above. against a live local stack (`make up`) and self-skip without one -- see [README.md](README.md#local-product-stack-docker-compose). -Period leftover pairs (ADR 0017 / 0018) are computed in +Period leftover pairs (ADR 0048 / 0049 / 0181) are computed in `lineageweave/leftover_pairs.py` from the residual after a real GRM/GPCM score, never invented. Missing cells stay out of the Gabriel factorization. Closest and farthest post–criterion pairs -persist to `report_leftover_pair` and sit above the member list so -a click opens that post. +persist to `report_leftover_pair` and sit above the member list with +two-axis leftover-map reconstruction `R̂` next to leftover-map +distance `d` so a click opens that post. `frontend/` has its own toolchain (Node pinned via `frontend/mise.toml`, pnpm via Corepack -- do not add a second Node package manager or a diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md index d0280ff97..2977500eb 100644 --- a/ARCHITECTURE.md +++ b/ARCHITECTURE.md @@ -588,8 +588,8 @@ on those same fixed parameters (Kim, 2006 FIPC). After scoring, `information_polytomous` ranks the shared-bank items by Fisher information at the group's mean θ (Lord, 1980 max-info CAT). Rankings persist to `report_item_information`. After those IRT main effects, -residual SVD leftover pairs (Jeon et al., 2021; ADR 0017) persist to -`report_leftover_pair`. Results persist to +residual SVD leftover pairs (Jeon et al., 2021; ADR 0048 / 0181) persist to +`report_leftover_pair` with two-axis leftover-map reconstruction named on the pair row. Results persist to `report_period_score` / `report_member_score`. `GET /api/reports/{grouping}` lists the trend; `GET /api/reports/{grouping}/{period}` is ABAC-filtered; diff --git a/CHANGELOG.d/2.12.25-leftover-map-reconstruction.md b/CHANGELOG.d/2.12.25-leftover-map-reconstruction.md new file mode 100644 index 000000000..44bbb3b43 --- /dev/null +++ b/CHANGELOG.d/2.12.25-leftover-map-reconstruction.md @@ -0,0 +1,8 @@ +## 2.12.25 — Leftover-map reconstruction + +- Persist two-axis leftover-map reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}` + on leftover post–criterion pairs (ADR 0181). After `make seed`, + closest and farthest leftover pairs sit above the member list with + `R̂` next to leftover-map distance `d`; click opens that post. Omit + the badge when reconstruction is missing. Never invent a leftover + score. diff --git a/CHANGELOG.md b/CHANGELOG.md index c8ed1a099..7b723f592 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,15 @@ All notable changes to this project are documented here. Format follows environment, so local OIDC and synthetic-data workflows resolve the same pinned dependencies as CI. +## [2.12.25] - 2026-08-24 + +### Added + +- Period leftover pair rows now name two-axis leftover-map reconstruction + `R̂ = ξ_{1:2} · ζ_{1:2}` next to leftover-map distance `d`, then open + that post (Gabriel, 1971; Jeon et al., 2021, eq. 3; ADR 0181). A missing + reconstruction omits the badge rather than inventing a leftover score. + ## [2.12.6] - 2026-08-20 ### Added diff --git a/CLAUDE.md b/CLAUDE.md index 1bcf50763..2becfcc42 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -54,7 +54,9 @@ chip name contains `Corporate entity: Demo Corp` and the persisted mean θ. The period-report panel says Demo Corp is the opened grouping and to read its mean θ and member posts, then open a post. Those members land immediately under that next action, ahead of Other Corp -and the week strip. Opening Public post names the next action: read +and the week strip. After `make seed`, leftover closest/farthest pairs +sit above the member list with two-axis leftover-map reconstruction +`R̂` next to leftover-map distance `d`. Opening Public post names the next action: read Event Lineage, Keyman, and evaluation on that post. The popup Event Lineage DAG marks that post current. After that current node, the popup names Keyman and evaluation as the next read. After landed diff --git a/backend/app/report_ingestion.py b/backend/app/report_ingestion.py index 50614b0ad..6f40f75f7 100644 --- a/backend/app/report_ingestion.py +++ b/backend/app/report_ingestion.py @@ -443,8 +443,9 @@ async def persist_period_report( """ insert into report_leftover_pair ( grouping_kind, grouping_key, period_code, rubric_version, - pair_kind, post_id, criterion_code, leftover_distance, leftover_residual - ) values ($1,$2,$3,$4,$5,$6,$7,$8,$9) + pair_kind, post_id, criterion_code, leftover_distance, leftover_residual, + leftover_map_reconstruction + ) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10) """, grouping_kind, grouping_key, @@ -455,6 +456,7 @@ async def persist_period_report( pair.criterion_code, pair.leftover_distance, pair.leftover_residual, + pair.leftover_map_reconstruction, ) @@ -601,7 +603,8 @@ async def fetch_period_reports( leftover = await conn.fetch( # nosemgrep: python.lang.security.audit.sqli.asyncpg-sqli.asyncpg-sqli f""" select lp.grouping_key, lp.pair_kind, lp.post_id, lp.criterion_code, - lp.leftover_distance, lp.leftover_residual, p.post_title, + lp.leftover_distance, lp.leftover_residual, lp.leftover_map_reconstruction, + p.post_title, p.visibility_code, p.corporate_entity_id, ({_SOURCE_CONTEXT_PRESENT_SQL}) as has_real_source_context from report_leftover_pair lp @@ -698,6 +701,11 @@ async def fetch_period_reports( "criterion_code": str(row["criterion_code"]), "leftover_distance": float(row["leftover_distance"]), "leftover_residual": float(row["leftover_residual"]), + "leftover_map_reconstruction": ( + None + if row["leftover_map_reconstruction"] is None + else float(row["leftover_map_reconstruction"]) + ), "visibility_code": row["visibility_code"], "corporate_entity_id": str(row["corporate_entity_id"]), "has_real_source_context": bool(row["has_real_source_context"]), diff --git a/backend/tests/test_api.py b/backend/tests/test_api.py index 438b4786a..da7a2a2b1 100644 --- a/backend/tests/test_api.py +++ b/backend/tests/test_api.py @@ -113,6 +113,11 @@ / "migrations" / "0102_project_bound_summary_event.sql" ) +_LEFTOVER_MAP_RECONSTRUCTION_MIGRATION = ( + Path(__file__).resolve().parents[2] + / "migrations" + / "0181_report_leftover_map_reconstruction.sql" +) def _postgres_available() -> bool: @@ -226,6 +231,7 @@ def seeded_db(demo_analyst_token): cur.execute(_MAJOR_EVENT_ACTION_MIGRATION.read_text()) cur.execute(_PROJECT_BOUND_ACTION_MIGRATION.read_text()) cur.execute(_PROJECT_BOUND_EVENT_MIGRATION.read_text()) + cur.execute(_LEFTOVER_MAP_RECONSTRUCTION_MIGRATION.read_text()) cur.execute( "insert into common_lookup_value (lookup_category, lookup_code, lookup_label) values " "('corporate_entity_level', 'group', 'Group'), " @@ -4518,6 +4524,9 @@ def test_seed_period_report_surfaces_on_get_reports(client, demo_analyst_token, assert leftover_kinds <= {"closest", "farthest"} assert all(pair["post_title"] for pair in high_report.get("leftover_pairs", [])) assert all(pair["leftover_distance"] >= 0 for pair in high_report.get("leftover_pairs", [])) + for pair in high_report.get("leftover_pairs", []): + reconstruction = pair.get("leftover_map_reconstruction") + assert reconstruction is None or isinstance(reconstruction, (int, float)) week3 = client.get( "/api/reports/process_unit/2026-W03", diff --git a/docker/postgres-init/migrate.sh b/docker/postgres-init/migrate.sh index f329117d6..9513fae22 100644 --- a/docker/postgres-init/migrate.sh +++ b/docker/postgres-init/migrate.sh @@ -18,7 +18,7 @@ for migration in /opt/lineageweave/migrations/*.sql; do migration_name=${migration##*/} case "$migration_name" in 0012_*|0013_*|0014_*|0015_*|0016_*|0017_*|0018_*|0019_*|0020_*|0021_*|0022_*|0023_*|0024_*|0025_*|0026_*|0027_*|0028_*|0029_*|0030_*|0031_*|0032_*|0033_*|0034_*|0035_*|0036_*|0037_*|0038_*|0039_*|0040_*|0041_*|0042_*|0043_*|0044_*|0045_*|0046_*|0047_*|0048_*|0049_*|0050_*) ;; - 0060_*|0100_*|0101_*|0102_*) ;; + 0060_*|0100_*|0101_*|0102_*|0181_*) ;; *) continue ;; esac printf 'Applying %s\n' "$migration_name" diff --git a/docs/adr/0003-fast-mlsirm-report-integration.md b/docs/adr/0003-fast-mlsirm-report-integration.md index bdf234b65..525e630b1 100644 --- a/docs/adr/0003-fast-mlsirm-report-integration.md +++ b/docs/adr/0003-fast-mlsirm-report-integration.md @@ -100,9 +100,12 @@ than one large PR: `information_polytomous` (Lord, 1980 max-info). Persist the ranking (`report_item_information`) and show the rank-1 item on the Period reports panel. Do not reimplement an information function here. -7. **Leftover-pair slice** (shipped in 0.71.2; ADR 0017 / 0018): after +7. **Leftover-pair slice** (shipped in 0.71.2; ADR 0048 / 0049 / 0181): after IRT main effects, persist closest and farthest post–criterion pairs - from the residual leftover map. Do not fork LSIRM; do not invent a + from the residual leftover map, and name two-axis leftover-map + reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}` when Gabriel coordinates + exist so the reconstructed leftover cell is not read as leftover + residual or leftover-map distance. Do not fork LSIRM; do not invent a leftover-pair API inside `fast-mlsirm` in this slice. **TEPP boundary.** [ARCHITECTURE.md](../../ARCHITECTURE.md) already diff --git a/docs/adr/0048-persist-lsirm-leftover-pairs.md b/docs/adr/0048-persist-lsirm-leftover-pairs.md index 8e87383f0..c22cbcbb3 100644 --- a/docs/adr/0048-persist-lsirm-leftover-pairs.md +++ b/docs/adr/0048-persist-lsirm-leftover-pairs.md @@ -30,7 +30,11 @@ and one `farthest` observed cell per period report in `report_leftover_pair` (3NF, two-or-more-word `snake_case`). The biplot lives in `lineageweave/leftover_pairs.py` so leftover -tests do not import `period_report` or `fast_mlsirm`. +tests do not import `period_report` or `fast_mlsirm`. Each leftover +row also names two-axis leftover-map reconstruction +`R̂ = ξ_{1:2} · ζ_{1:2}` when Gabriel coordinates exist so the +reconstructed leftover cell is not read as leftover residual `R` or +leftover-map distance `d` (ADR 0181). Cascade the rows with `report_period_score`. A leftover post must also be a `report_member_score` row, and the leftover criterion diff --git a/docs/adr/0049-leftover-pair-report-ui.md b/docs/adr/0049-leftover-pair-report-ui.md index a93985b40..a2e94ecd1 100644 --- a/docs/adr/0049-leftover-pair-report-ui.md +++ b/docs/adr/0049-leftover-pair-report-ui.md @@ -19,8 +19,12 @@ On each period-report group, render leftover pairs **above** the member list. Each pair is a button: closest or farthest label, post title, criterion short label, leftover-map distance, and the next action (“Open this post to read the criterion it sat closest to / -farthest from after main effects.”). Clicking the button opens that -post with the same handler as a member row. +farthest from after main effects.”). Reconstruction next action: +leftover map reconstructs `R̂` after IRT main effects; open this +post to read the named criterion. A missing reconstruction keeps the +existing closest/farthest next action. Clicking the button opens that +post with the same handler as a member row. Reconstruction naming is +[ADR 0181](0181-leftover-map-reconstruction.md). After `make seed`, closest and farthest leftover pairs sit above the member list. Click a pair to open that post. diff --git a/docs/adr/0181-leftover-map-reconstruction.md b/docs/adr/0181-leftover-map-reconstruction.md new file mode 100644 index 000000000..8bb479a3f --- /dev/null +++ b/docs/adr/0181-leftover-map-reconstruction.md @@ -0,0 +1,85 @@ +# ADR 0181 — Name two-axis leftover-map reconstruction on period-report pair rows + +**Decision status:** Accepted +**Date:** 2026-08-24 + +Amends [ADR 0048](0048-persist-lsirm-leftover-pairs.md) and +[ADR 0049](0049-leftover-pair-report-ui.md). + +## Context + +ADR 0048 already persists leftover-map distance `d = ‖ξ_p − ζ_i‖` and +leftover residual `R = Y − E[Y|θ, item]` on `report_leftover_pair`. +ADR 0049 already renders closest and farthest pairs above the member +list and opens the named post. Distance is the Jeon et al. (2021, +eq. 3) map gap. Gabriel (1971) reconstructs a matrix from the biplot +as the inner product of person and item coordinates. The leftover map +buyers read is two-axis: unused axes pad with zero, and hidden SVD +axes after the second are dropped. Full-rank inner product `ξ·ζ` +therefore reconstructs the centered residual, not the cell the +two-axis map shows. Hiding two-axis reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}` +lets a buyer read leftover residual `R` or leftover-map distance `d` +as the reconstructed leftover cell. + +This increment does not persist leftover-map coordinates, does not +name leftover-map inner product as a separate full-rank column, does +not name leftover-map cosine, does not name observed `Y` / expected +`E`, does not name leftover-map rank, does not split leftover-map +distance onto two axes, and does not land Post quality on the leftover +criterion. Leftover-map distance stays full-rank Euclidean. + +The unprotected-stack reconstructions for neighbouring leftover facts +use 0162–0180. This protected-main increment uses **0181** so it does +not collide with leftover-map cosine (0180), leftover-map inner product +(0179), leftover residual disclosure (0178), leftover observed `Y` / +expected `E` (0177), leftover-map rank (0172), two-axis leftover-map +distance (0166), leftover coverage (0168), leftover-map axis share +(0148), or leftover interaction-map persistence (0121). + +## Decision + +Each leftover pair names `leftover_map_reconstruction` — the two-axis +Gabriel reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}` of the leftover-map +person and item coordinates. Migration `0181` is the single source of +the column on every install path, fresh or existing -- shipped +migrations (`0001` / `0012`) are never edited after the fact. The +column is nullable so older leftover rows keep distance and residual +without fabricating a reconstruction. Fallback pairs that have no +complete-case leftover map omit the value rather than inventing one. +A rank-0 origin map stores `0.0` (zeros · zeros), not a missing value. +A non-finite reconstruction stores null rather than inventing a +leftover score. + +The pair button shows `R̂ {signed}` next to leftover-map distance `d` +when the value is finite. Next action: leftover map reconstructs `R̂` +after IRT main effects; open this post to read the named criterion. +A missing or non-finite reconstruction omits the badge and keeps the +existing closest/farthest next action. Do not invent a leftover score. +Do not invent a theta. + +## Consequences + +`GET /api/reports/{grouping}/{period}` returns +`leftover_map_reconstruction`. After `make seed`, closest and farthest +leftover pairs sit above the member list with named `R̂` next to `d`; +click opens that post. Hidden posts stay hidden. + +## Related + +Independent of leftover interaction-map persistence, leftover-criterion +evaluation landing, leftover residual disclosure, leftover observed +`Y` / expected `E`, leftover-map complete-case coverage, leftover-map +axis share, leftover pairs on the grouping comparison strip, two-axis +leftover-map distance, leftover-map rank, leftover-map inner product, +and leftover-map cosine. + +## References + +Gabriel, K. R. (1971). The biplot graphic display of matrices with +application to principal component analysis. *Biometrika, 58*(3), +453–467. https://doi.org/10.1093/biomet/58.3.453 + +Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping +unobserved item–respondent interactions: A latent space item response +model with interaction map. *Psychometrika, 86*(2), 378–403. +https://doi.org/10.1007/s11336-021-09762-5 diff --git a/frontend/package.json b/frontend/package.json index e2e996bbe..638f400be 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -1,7 +1,7 @@ { "name": "frontend", "private": true, - "version": "2.12.6", + "version": "2.12.25", "type": "module", "scripts": { "dev": "vite", diff --git a/frontend/src/App.test.tsx b/frontend/src/App.test.tsx index 7462abd2c..ca46beacb 100644 --- a/frontend/src/App.test.tsx +++ b/frontend/src/App.test.tsx @@ -932,6 +932,7 @@ describe("App, authenticated", () => { criterion_code: "sales_lead_specificity", leftover_distance: 0.12, leftover_residual: 0.4, + leftover_map_reconstruction: 0.4, }, { pair_kind: "farthest", @@ -940,6 +941,7 @@ describe("App, authenticated", () => { criterion_code: "general_sentiment_negative", leftover_distance: 1.84, leftover_residual: -1.1, + leftover_map_reconstruction: -1.1, }, ], members: [ @@ -3357,13 +3359,15 @@ describe("App, authenticated", () => { }); expect(closestPair).toHaveTextContent("Closest leftover: Public post · sales-lead"); expect(closestPair).toHaveTextContent( - "Open this post to read the criterion it sat closest to after main effects.", + "Leftover map reconstructs R̂ +0.40 after IRT main effects. Open this post to read sales-lead.", ); + expect(closestPair).toHaveTextContent("R̂ +0.40"); expect(closestPair).toHaveTextContent("d 0.12"); expect(farthestPair).toHaveTextContent("Farthest leftover: Specification revision requested · negative"); expect(farthestPair).toHaveTextContent( - "Open this post to read the criterion it sat farthest from after main effects.", + "Leftover map reconstructs R̂ −1.10 after IRT main effects. Open this post to read negative.", ); + expect(farthestPair).toHaveTextContent("R̂ −1.10"); expect(farthestPair).toHaveTextContent("d 1.84"); const memberButton = screen.getByRole("button", { name: /open report post: public post/i }); expect(closestPair.compareDocumentPosition(memberButton) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy(); diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx index 6fba0dd41..c420c3346 100644 --- a/frontend/src/App.tsx +++ b/frontend/src/App.tsx @@ -102,6 +102,11 @@ import { useLocale, } from "./i18n"; import { rememberOidcReturnUrl, returnUrlFromLocation } from "./oidcReturnUrl"; +import { + formatLeftoverMapReconstruction, + formatSignedLeftoverValue, + LEFTOVER_MAP_RECONSTRUCTION_ACTION, +} from "./leftoverMapReconstruction"; import "./App.css"; function orchestratorUnavailableMessage(err: unknown, action: string): string { @@ -3390,15 +3395,26 @@ function ReportsPanel({ )} {report.leftover_pairs && report.leftover_pairs.length > 0 && ( -