You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: skills/pr-review.md
+13-18Lines changed: 13 additions & 18 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -220,10 +220,10 @@ Procedure:
220
220
- D3: Credential requirements — Required API scopes or permissions changed (new OAuth scopes, different permission levels, new authentication methods).
221
221
- D4: Configuration fields — Config fields added, removed, or renamed in pkg/config/config.go.
222
222
223
-
If any of D1-D4 apply, read docs/connector.mdx to confirm the specific section that would need updating.
223
+
If any of D1-D4 apply, read docs/connector.mdx to confirm the specific section that would need updating. Documentation staleness is a critical blocker — the docs must be updated before merge.
224
224
225
225
Return a JSON object:
226
-
{"status": "stale", "findings": [{"id": "D1", "section": "<section name in docs>", "reason": "<why it's stale>"}]}
226
+
{"status": "stale", "findings": [{"id": "D1", "severity": "critical", "section": "<section name in docs>", "reason": "<why it's stale>"}]}
227
227
228
228
Or if none apply:
229
229
{"status": "up_to_date"}
@@ -246,7 +246,7 @@ DIFFS:
246
246
3.**Cross-validate entity sources** (if provisioning changed): Read the Grant/Revoke code yourself to verify P1/P2 findings. This is the #1 bug.
247
247
4.**Cross-validate PR feedback**: Check PR review comments against findings. Add missing unaddressed items as warnings.
6. Parse the docs-reviewer (Agent 4) result. If status is "stale", convert each finding to a warning.
249
+
6. Parse the docs-reviewer (Agent 4) result. If status is "stale", convert each finding to **critical** severity — stale docs are a release blocker.
250
250
251
251
**Deliverable:** A merged list of findings (code + docs) with duplicates removed. Print the count of findings by severity.
252
252
@@ -256,28 +256,23 @@ DIFFS:
256
256
257
257
Post findings directly as PR comments:
258
258
259
-
1.**Inline comments** on specific lines where issues are found, with the finding ID, severity, description, and recommendation.
259
+
1.**Inline comments** on specific lines where issues are found. Keep each comment to 2-3 sentences: what's wrong, why it matters, and how to fix it.
260
260
261
-
2.**Summary comment**with ALL of the following sections (do not omit any):
261
+
2.**Summary comment**— be concise. No more than a few sentences per finding. Use the following template (do not omit any section):
262
262
263
263
```
264
264
### PR Review: <PR title>
265
265
266
-
### Findings
267
-
| Severity | Count |
268
-
|----------|-------|
269
-
| Critical | N |
270
-
| Warning | N |
271
-
| Suggestion | N |
266
+
**Critical: N | Warning: N | Suggestion: N**
272
267
273
-
### Breaking Changes
274
-
<findings or "None detected.">
268
+
### Critical Issues
269
+
<one-liner per issue with file:line, or "None.">
275
270
276
271
### Documentation
277
-
<output from docs-reviewer agent — docs staleness assessment>
272
+
<one-liner: "Up to date", "No docs file", or which sections need updating and why>
278
273
279
-
### Files Reviewed
280
-
| File | Category |
281
-
|------|----------|
282
-
| ... | ... |
274
+
### Other Findings
275
+
<brief list of warnings/suggestions, or "None.">
283
276
```
277
+
278
+
Do NOT include a "Files Reviewed" section, a "Verdict" section, or a "Breaking Changes" section. Do NOT repeat findings that were already posted as inline comments — just reference them briefly in the summary. Keep the entire summary comment short.
0 commit comments