You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 34708ff
Browse filesBrowse the repository at this point in the historyBrowse files
Retention: extend instead of keeping forever; grace after release; clock skew; shared budget
Review fixes for the retention mechanics (data deletion; every change keeps data
longer, never shorter):
- A stored retain_until earlier than the date required today (the period derived
under the current configuration, never less than three years after creation)
is extended to that date under the queue lock (compare-and-set) instead of
making the job undeletable forever; the job is deleted when the later date
arrives. Raising evidence/legacy retention after closure is honoured; lowering
it never shortens a stored date.
- A legacy acceptance dated more than a day before its record was created gets
three full years from creation: later than the promise, and finite.
- Releasing a hold ends it now (purpose kept, releaser recorded) so the
documented three-day grace applies; releasing an expired hold never lengthens it.
- Deletions stop while the PHP and database clocks disagree by more than five
minutes; the clock problem is logged once per occurrence, not every run.
- One budget of 50 deletion attempts per run, shared by the evidence step and
both tombstone loops; a refused restored-post deletion is counted and skipped.
- A restored job row's post is deleted only if it carries the tombstone's
identity (recycled post ids); a due job whose post carries another identity
is kept whole.
- Retention on the admin path catches exceptions like the claim path; on the
claim path it runs only on polls that hand out no job.
- Tests: config raised after closure (extended, then deleted at the new date,
not shortened when lowered), legacy accepted-before-created deadline, release
grace, clock skew (both directions) and log-once, shared budget, recycled post
ids, foreign identity, leap-day bases, claim latency. Docs updated.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
0 commit comments