fix: show Request Data Access button for Admin users (open-metadata#28790)

* fix: show Request Data Access button for Admin users

* fix lint checks

* fix unit test failure

Author: anuj-kumary

openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.component.tsx

@@ -611,8 +611,7 @@ export const DataAssetsHeader = ({
       entityType !== EntityType.TABLE ||
       deleted ||
       isOwner ||
-      currentUser?.isAdmin ||
-      !canCreateTask
+      (!canCreateTask && !currentUser?.isAdmin)
     ) {
       return null;
     }
@@ -643,6 +642,7 @@ export const DataAssetsHeader = ({
     isDarAwaitingGrant,
     isDarGranted,
     canCreateTask,
+    currentUser,
     t,
   ]);
 

openmetadata-ui/src/main/resources/ui/src/components/DataAssets/DataAssetsHeader/DataAssetsHeader.test.tsx

@@ -972,7 +972,7 @@ describe('DataAssetsHeader component', () => {
       ).not.toBeInTheDocument();
     });
 
-    it('should not render when user is admin but has no canCreateTask permission', async () => {
+    it('should render when user is admin even without canCreateTask permission', async () => {
       const { useApplicationStore } = jest.requireMock(
         '../../../hooks/useApplicationStore'
       );
@@ -983,16 +983,18 @@ describe('DataAssetsHeader component', () => {
 
       render(<DataAssetsHeader {...tableProps} canCreateTask={false} />);
 
-      expect(
-        screen.queryByTestId('request-data-access-button')
-      ).not.toBeInTheDocument();
+      await waitFor(() => {
+        expect(
+          screen.getByTestId('request-data-access-button')
+        ).toBeInTheDocument();
+      });
 
       (useApplicationStore as jest.Mock).mockReturnValue({
         currentUser: { id: 'user-1', name: 'test.user' },
       });
     });
 
-    it('should not render when user is admin even with canCreateTask permission', async () => {
+    it('should render when user is admin with canCreateTask permission', async () => {
       const { useApplicationStore } = jest.requireMock(
         '../../../hooks/useApplicationStore'
       );
@@ -1004,8 +1006,8 @@ describe('DataAssetsHeader component', () => {
 
       await waitFor(() => {
         expect(
-          screen.queryByTestId('request-data-access-button')
-        ).not.toBeInTheDocument();
+          screen.getByTestId('request-data-access-button')
+        ).toBeInTheDocument();
       });
 
       (useApplicationStore as jest.Mock).mockReturnValue({
@@ -1017,9 +1019,11 @@ describe('DataAssetsHeader component', () => {
       const { useApplicationStore } = jest.requireMock(
         '../../../hooks/useApplicationStore'
       );
+      const { hasEditAccess } = jest.requireMock('../../../utils/EntityUtils');
       (useApplicationStore as jest.Mock).mockReturnValue({
         currentUser: { id: 'user-1', name: 'test.user', isAdmin: true },
       });
+      (hasEditAccess as jest.Mock).mockReturnValue(true);
 
       render(
         <DataAssetsHeader
@@ -1038,6 +1042,7 @@ describe('DataAssetsHeader component', () => {
       (useApplicationStore as jest.Mock).mockReturnValue({
         currentUser: { id: 'user-1', name: 'test.user' },
       });
+      (hasEditAccess as jest.Mock).mockReturnValue(false);
     });
 
     it('should render for non-admin user with canCreateTask permission who is not owner', async () => {

openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.test.tsx

@@ -97,12 +97,10 @@ jest.mock('../../../hooks/useCustomPages', () => ({
     .mockReturnValue({ customizedPage: null, isLoading: false }),
 }));
 jest.mock('../../../hooks/useMarketplaceStore', () => ({
-  useMarketplaceStore: jest
-    .fn()
-    .mockReturnValue({
-      isMarketplace: false,
-      dataProductBasePath: '/data-product',
-    }),
+  useMarketplaceStore: jest.fn().mockReturnValue({
+    isMarketplace: false,
+    dataProductBasePath: '/data-product',
+  }),
 }));
 jest.mock('../../../rest/dataProductAPI', () => ({
   getDataProductPortsView: jest.fn().mockResolvedValue({ data: [] }),
@@ -163,17 +161,19 @@ describe('DataProductsDetailsPage — Request Data Access button', () => {
     ).not.toBeInTheDocument();
   });
 
-  it('does not render for an admin even when the feature flag is on', () => {
+  it('renders and is enabled for an admin when the feature flag is on', () => {
     enableRequestDataAccess();
     (useApplicationStore as unknown as jest.Mock).mockReturnValue({
       currentUser: { id: 'admin-1', name: 'admin', isAdmin: true },
     });
+    (usePermissionProvider as jest.Mock).mockReturnValue({
+      getEntityPermission: jest.fn().mockResolvedValue({}),
+      permissions: { task: { Create: false } },
+    });
 
     render(<DataProductsDetailsPage {...defaultProps} />);
 
-    expect(
-      screen.queryByTestId('request-data-access-button')
-    ).not.toBeInTheDocument();
+    expect(screen.getByTestId('request-data-access-button')).toBeEnabled();
   });
 
   it('does not render for the entity owner', () => {

openmetadata-ui/src/main/resources/ui/src/components/DataProducts/DataProductsDetailsPage/DataProductsDetailsPage.component.tsx

@@ -896,8 +896,7 @@ const DataProductsDetailsPage = ({
             <div className="tw:flex tw:gap-3 tw:justify-end tw:items-center tw:pb-1">
               {!isVersionsView &&
                 !isOwner &&
-                !currentUser?.isAdmin &&
-                canCreateTask &&
+                (canCreateTask || currentUser?.isAdmin) &&
                 dataProductClassBase.getShowRequestDataAccess() && (
                   <CoreTooltip
                     isDisabled={!isDarDisabled}