diff --git a/.changeset/mcp-saved-search-where-language.md b/.changeset/mcp-saved-search-where-language.md new file mode 100644 index 0000000000..5e13e20238 --- /dev/null +++ b/.changeset/mcp-saved-search-where-language.md @@ -0,0 +1,5 @@ +--- +'@hyperdx/api': patch +--- + +fix(mcp): store whereLanguage as lucene when clickstack_save_saved_search creates a search without one, so its alerts no longer parse a Lucene filter as SQL diff --git a/packages/api/src/mcp/__tests__/savedSearches.int.test.ts b/packages/api/src/mcp/__tests__/savedSearches.int.test.ts index ab26fbfb39..89190c4392 100644 --- a/packages/api/src/mcp/__tests__/savedSearches.int.test.ts +++ b/packages/api/src/mcp/__tests__/savedSearches.int.test.ts @@ -239,6 +239,7 @@ describe('MCP Saved Search Tools', () => { expect(output.where).toBe(''); expect(output.select).toBe(''); expect(output.tags).toEqual([]); + expect(output.whereLanguage).toBe('lucene'); }); it('should create a saved search with SQL where language', async () => { @@ -378,6 +379,24 @@ describe('MCP Saved Search Tools', () => { expect(updated?.where).toBe('StatusCode:Ok'); }); + it('should keep the stored whereLanguage when an update omits it', async () => { + const savedSearch = await createTestSavedSearch({ + where: "StatusCode = 'Error'", + whereLanguage: 'sql', + }); + + const result = await callTool(client, 'clickstack_save_saved_search', { + id: savedSearch._id.toString(), + name: 'Renamed', + sourceId: traceSource._id.toString(), + where: "StatusCode = 'Ok'", + }); + + expect(result.isError).toBeFalsy(); + const updated = await SavedSearch.findById(savedSearch._id); + expect(updated?.whereLanguage).toBe('sql'); + }); + it('should return error for non-existent saved search on update', async () => { const fakeId = '000000000000000000000000'; const result = await callTool(client, 'clickstack_save_saved_search', { diff --git a/packages/api/src/mcp/tools/savedSearches/saveSavedSearch.ts b/packages/api/src/mcp/tools/savedSearches/saveSavedSearch.ts index 3ed1421c81..a507b007c1 100644 --- a/packages/api/src/mcp/tools/savedSearches/saveSavedSearch.ts +++ b/packages/api/src/mcp/tools/savedSearches/saveSavedSearch.ts @@ -60,7 +60,9 @@ export function registerSaveSavedSearch({ name: input.name, select: input.select ?? '', where: input.where ?? '', - whereLanguage: input.whereLanguage, + // Alerts read a missing whereLanguage as sql while the app reads it as + // lucene, so a new search must store it explicitly. + whereLanguage: input.whereLanguage ?? (isUpdate ? undefined : 'lucene'), orderBy: input.orderBy, source: input.sourceId, tags: input.tags ?? [],