Repository navigation
Commit e268f6a
authored
fix(theme): red Menu.Item label contrast in portaled menus (#2289)
## Summary
- Add a global CSS override in `_base-tokens.scss` so `Menu.Item` with `color="red"` uses `--mantine-color-red-light-color` for `--menu-item-color`, matching danger controls and fixing low contrast from Mantine default `red-6`.
- `Menu.extend` item styles cannot target these rows because Popover defaults to `withinPortal`, so the dropdown DOM is outside the `Menu` root.
<img width="832" height="612" alt="image" src="https://github.com/user-attachments/assets/436e143b-813c-4460-98e0-263c3a16e346" />
## Test plan
- [ ] Open user menu, confirm Logout (red row) label reads clearly in light and dark mode.
- [ ] Smoke another menu with a red item if applicable.
Made with [Cursor](https://cursor.com)1 parent e2db2ef commit e268f6a
2 files changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
0 commit comments