Skip to content

Commit 7dad83d

Browse files
feat: elevate EventName in top level attributes
1 parent 1a3bbe9 commit 7dad83d

2 files changed

Lines changed: 30 additions & 1 deletion

File tree

‎packages/app/src/components/DBRowOverviewPanel.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export function RowOverviewPanel({
100100
// assume OTel column names for now
101101
const topLevelAttributeKeys = [
102102
'ServiceName',
103+
'EventName',
103104
'SpanName',
104105
'Duration',
105106
'SeverityText',

‎packages/app/src/components/__tests__/DBRowOverviewPanel.browserEvent.test.tsx‎

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ jest.mock('../NetworkPropertyPanel', () => ({
1717

1818
jest.mock('../ExceptionSubpanel', () => ({ ExceptionSubpanel: () => null }));
1919

20-
jest.mock('../DBRowJsonViewer', () => ({ DBRowJsonViewer: () => null }));
20+
const mockJsonViewer = jest.fn((_props: { data: unknown }) => null);
21+
jest.mock('../DBRowJsonViewer', () => ({
22+
DBRowJsonViewer: (props: { data: unknown }) => mockJsonViewer(props),
23+
}));
2124

2225
jest.mock('../linkedSpans', () => ({
2326
useReverseSpanLinks: () => ({ links: [] }),
@@ -162,3 +165,28 @@ describe('RowOverviewPanel browser event section', () => {
162165
).not.toBeInTheDocument();
163166
});
164167
});
168+
169+
describe('RowOverviewPanel top level attributes', () => {
170+
const topLevelData = () =>
171+
mockJsonViewer.mock.calls.map(([props]) => props.data);
172+
173+
beforeEach(() => mockJsonViewer.mockClear());
174+
175+
it('lists the EventName column', () => {
176+
renderRow(CLICK_ATTRIBUTES, {
177+
ServiceName: 'web',
178+
EventName: 'browser.user_action.click',
179+
});
180+
181+
expect(topLevelData()).toContainEqual({
182+
ServiceName: 'web',
183+
EventName: 'browser.user_action.click',
184+
});
185+
});
186+
187+
it('leaves out an empty EventName', () => {
188+
renderRow({}, { ServiceName: 'api', EventName: '' });
189+
190+
expect(topLevelData()).toContainEqual({ ServiceName: 'api' });
191+
});
192+
});

0 commit comments

Comments
 (0)