Skip to content

Commit 0d01864

Browse files
UI/UX: Loading overlay dots announced by screen readers (#2532)
## 🎨 UI/UX Improvement ### Problem The animated dot animation (`'.'.repeat(periods)`) is inside a full-screen loading blocker with no `aria-hidden` attribute. Screen readers will announce each period change as the animation progresses, creating a noisy experience. Additionally, the loading indicator lacks `role="status"` or `aria-live="polite"` so assistive technology never announces the loading state at all. **Severity**: `medium` **File**: `packages/app/src/AuthLoadingBlocker.tsx` ### Solution The animated dot animation (`'.'.repeat(periods)`) is inside a full-screen loading blocker with no `aria-hidden` attribute. Screen readers will announce each period change as the animation progresses, creating a noisy experience. Additionally, the loading indicator lacks `role="status"` or `aria-live="polite"` so assistive technology never announces the loading state at all. ### Changes - `packages/app/src/AuthLoadingBlocker.tsx` (modified) ## Summary ### Screenshots or video | Before | After | | :----- | :---- | | | | ### How to test on Vercel preview **Preview routes:** **Steps:** 1. 2. 3. ### References - Linear Issue: - Related PRs: --- <details> <summary>🤖 About this PR</summary> This pull request was generated by [ContribAI](https://github.com/tang-vu/ContribAI), an AI agent that helps improve open source projects. The change was: 1. **Discovered** by automated code analysis 2. **Generated** by AI with context-aware code generation 3. **Self-reviewed** by AI quality checks If you have questions or feedback about this PR, please comment below. We appreciate your time reviewing this contribution! </details> Closes #2531 Co-authored-by: Drew Davis <6097246+pulpdrew@users.noreply.github.com>
1 parent 0632598 commit 0d01864

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/app/src/AuthLoadingBlocker.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,13 @@ export default function AuthLoadingBlocker() {
2424
style={{
2525
zIndex: 2147483647,
2626
}}
27+
role="status"
28+
aria-live="polite"
2729
>
2830
Loading {brandName}
29-
<span style={{ width: 0 }}>{'.'.repeat(periods)}</span>
31+
<span style={{ width: 0 }} aria-hidden="true">
32+
{'.'.repeat(periods)}
33+
</span>
3034
</div>
3135
)}
3236
</>

0 commit comments

Comments
 (0)