Summary
The rolling per-run progress comment on the goal issue never posts: the journal record's issue_number is initialized to None and is never set to a real goal-issue number in any production path, so the activity-comment upsert always early-returns — the goal issue shows only lifecycle labels, never progress.
Scope Check
Affected Area
Environment
- Branch / commit:
develop (verified on feat/144-config-observ-deploy)
- Deployment: any
Steps to Reproduce
- Set
FKST_JOURNAL_ACTIVITY_COMMENT_ENABLED=true (the default) with journaling configured.
- Trigger a goal and watch the goal issue during the run.
Expected Behavior
A rolling activity comment on the goal issue reflects RAISED-event progress as the run proceeds (the behavior #139 set out to provide).
Actual Behavior
upsert_activity_comment early-returns "no issue_number; skipping activity comment" on every flush because issue_number is never populated:
issue_number is initialized None (fkst-journal lib.rs:208).
- It is only ever re-hydrated from the already-committed journal file (
flush.rs:124-125) and propagated if already set (merge.rs:98-99).
- No production code path sets it to the real goal-issue number (grep: the only setters are the self-hydration + tests).
Net: the goal issue receives lifecycle labels only (fkst-running / fkst-completed / …); the durable progress lives solely in the separate journal repo's .fkst-hosted/journal/<run_key>.json. The advertised "rolling issue comment" surface does not exist.
Affected Files
- fkst-journal crate:
lib.rs (~208), flush.rs (~124-125, ~370-376), merge.rs (~98-99).
- The session driver that constructs the journal context (
fkst-control-plane/src/sessions/service.rs start_journaler; worker engine/journal.rs) — where the real goal-issue number would be threaded in.
Proposed Resolution
Thread the goal issue's number into the journal SessionCtx/record at run start so upsert_activity_comment can post/maintain the rolling comment — OR, if the comment surface is intentionally dropped, default FKST_JOURNAL_ACTIVITY_COMMENT_ENABLED=false and remove the dead seam + docs claiming an issue comment.
Verification Checklist
Definition of Done
Either the rolling goal-issue progress comment works end to end, or the dead seam is removed and documentation/config defaults corrected. Relates to #139.
Summary
The rolling per-run progress comment on the goal issue never posts: the journal record's
issue_numberis initialized toNoneand is never set to a real goal-issue number in any production path, so the activity-comment upsert always early-returns — the goal issue shows only lifecycle labels, never progress.Scope Check
Affected Area
Environment
develop(verified onfeat/144-config-observ-deploy)Steps to Reproduce
FKST_JOURNAL_ACTIVITY_COMMENT_ENABLED=true(the default) with journaling configured.Expected Behavior
A rolling activity comment on the goal issue reflects RAISED-event progress as the run proceeds (the behavior #139 set out to provide).
Actual Behavior
upsert_activity_commentearly-returns "no issue_number; skipping activity comment" on every flush becauseissue_numberis never populated:issue_numberis initializedNone(fkst-journallib.rs:208).flush.rs:124-125) and propagated if already set (merge.rs:98-99).Net: the goal issue receives lifecycle labels only (
fkst-running/fkst-completed/ …); the durable progress lives solely in the separate journal repo's.fkst-hosted/journal/<run_key>.json. The advertised "rolling issue comment" surface does not exist.Affected Files
lib.rs(~208),flush.rs(~124-125, ~370-376),merge.rs(~98-99).fkst-control-plane/src/sessions/service.rsstart_journaler; workerengine/journal.rs) — where the real goal-issue number would be threaded in.Proposed Resolution
Thread the goal issue's number into the journal
SessionCtx/record at run start soupsert_activity_commentcan post/maintain the rolling comment — OR, if the comment surface is intentionally dropped, defaultFKST_JOURNAL_ACTIVITY_COMMENT_ENABLED=falseand remove the dead seam + docs claiming an issue comment.Verification Checklist
issue_numberis populated from the real goal issue (not only self-hydrated).Definition of Done
Either the rolling goal-issue progress comment works end to end, or the dead seam is removed and documentation/config defaults corrected. Relates to #139.