You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found during fine-grained code-quality review (second pass) at commit 14fbf3e (develop). Severity: low — bug. Three small state/config issues:
MySkillsPage "Clear search" keeps stale pagination (pages/skill/MySkillsPage.tsx:126-134): typing resets page (89-92) but the empty-state "Clear search" button only does setSearchInput("") — a user on page 3 of a filtered set re-fires the cleared query with page=3 and can see an empty grid for a non-empty collection. Fix: also setPage(1). (Same family as [Bug] Changing the search query doesn't reset the URL ?page= param — false empty results on /registry #1000 on ExplorePage.)
Import file input never resets (pages/admin/settings/sections/ExportImportSection.tsx:212-218): after a failed parse, re-picking the same fixed file doesn't fire onChange because the input's value is unchanged. EditSkillPage.tsx:63 does this correctly (e.target.value = ""). Fix: mirror it.
Global retry: 1 retries non-retryable 4xx (App.tsx:222-229): every failed query — including 401/403/404 ApiClientErrors — is retried once, doubling load on hard failures and delaying error states. Fix: retry: (count, err) => !(err instanceof ApiClientError && err.statusCode < 500) && count < 1.
Summary
Found during fine-grained code-quality review (second pass) at commit
14fbf3e(develop). Severity: low — bug. Three small state/config issues:pages/skill/MySkillsPage.tsx:126-134): typing resetspage(89-92) but the empty-state "Clear search" button only doessetSearchInput("")— a user on page 3 of a filtered set re-fires the cleared query withpage=3and can see an empty grid for a non-empty collection. Fix: alsosetPage(1). (Same family as [Bug] Changing the search query doesn't reset the URL ?page= param — false empty results on /registry #1000 on ExplorePage.)pages/admin/settings/sections/ExportImportSection.tsx:212-218): after a failed parse, re-picking the same fixed file doesn't fireonChangebecause the input's value is unchanged.EditSkillPage.tsx:63does this correctly (e.target.value = ""). Fix: mirror it.retry: 1retries non-retryable 4xx (App.tsx:222-229): every failed query — including 401/403/404ApiClientErrors — is retried once, doubling load on hard failures and delaying error states. Fix:retry: (count, err) => !(err instanceof ApiClientError && err.statusCode < 500) && count < 1.