Skip to content

[Frontend] Review-i18n + board-picker polish residuals (PR #1869 / #1870 reviews) #1871

Description

@Chris0Jeky

Small hardening/polish residuals from the PR #1869 and PR #1870 reviews (none merge-relevant):

Review i18n (PR #1869):

  1. StoredConfidenceBreakdown is a pure type alias - it documents but does not enforce the wire-key invariant; a branded key type (or distinct wireKey field) would make fetch-time translation a compile error.
  2. The 401/403 branch of describeErrorKey (TranscriptEvidenceViewer.vue) has no test; with missingWarn off, a catalog rename would silently render the raw key. One mockRejectedValue({response:{status:403}}) case closes it.
  3. The es locale is unasserted on the transcript error path (it is asserted for confidence labels).
  4. A11y: the error paragraph carries role="alert" and its text changes on locale switch - a screen reader may re-announce a stale failure.

Board picker (PR #1870):
5. The composer hint is not selection-bound: with a view-only board preselected via defaultBoardId, the disabled Capture button is explained only by the generic hint. Bind the hint to the selected option.
6. Pre-existing hardcoded English beside the new localized strings: 'No board · land in inbox' / 'Select a board…' - an ADR-0054 §8 all-or-nothing gap in the Inbox surface, predating #1870. Extract on the next Inbox i18n touch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.frontendPrimary implementation impact in Vue/TypeScript UI and client runtime.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.uxDiscoverability, accessibility, interaction model, and user workflow quality.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions