Skip to content

[Frontend] ADR-0053 guard maintenance residuals: badge dE spacing, dual root lists, guard escape hatch (PR #1865 review) #1868

Description

@Chris0Jeky

Residuals from the PR #1865 review (ADR-0053 token tuning, #1842):

  1. Badge tint distinctness is string-level, not perceptual — pairwise CIE76 dE between the five Paper badge fills has close pairs; if type identification matters, re-space the hues (measure, don't eyeball).
  2. Two hand-maintained root lists — paper-eyebrow-token.spec.ts EYEBROW_ROOTS (20) vs paperViewLegacySubstrate.spec.ts roots (22) have no mechanical link; a new Paper root can silently miss one list. Derive both from one source.
  3. Tightened invariant regex now rejects a future correctly-scoped body.paper .x bridge rule — intentional strictness, but record the escape hatch (rename/annotate) before someone needs it.
  4. Exempt-rule body check is an exact string match (.toBe('color-scheme: light;')) — reformatting fails the guard; loosen to a structural match when next touched.
  5. Core-loop eyebrow guard shape — it asserts no *__eyebrow* BEM rule declares color, but a core-loop surface could still override .tk-eyebrow by other selectors; note the gap.
  6. The dark:-is-dead justification rests on src/style.css:3 @config "../tailwind.config.js", named nowhere in the comment/ADR/PR — one clause in the ADR would pin the mechanism.

Source: PR #1865 review non-blocking items N1-N6.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.hardeningReliability, safety, operability, and production-readiness improvements.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.testingTest coverage, harnesses, regression prevention, and verification pipeline work.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions