Skip to content

[Agent safety] Fingerprint guard: lane-throw coverage, deletion classification, anchor precision (PR #1850 review residuals) #1860

Description

@Chris0Jeky

Residual gaps noted by the PR #1850 fresh-context review (PR closed #1832; fail-closed today, tracked for completeness):

  1. No executable coverage for the lane-throw + clean-checkout path (guard exit 0 -> throw $laneError rethrown after the finally). Pre-existing gap, more relevant now that the harness test anchors the recipe statically — add one harness case that drives it end-to-end.
  2. Lane deletion of a clean tracked file (outside the status baseline) exits 1 with "status artifact disappeared before it could be fingerprinted" rather than a classified deleted record. Fail-closed and wave-stopping (correct), but the diagnostic under-describes; classify it.
  3. Static anchor precision. The harness test "requires both batch skill wrappers to propagate lane failure after cleanup" anchors on IndexOf('throw $laneError', $cleanup) — the anchor is satisfiable by comment text as well as code; tighten to a structural match.

Source: PR #1850 review (non-blocking items 1-3).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority IIIValuable but unscheduled: residuals, tech-debt, performance, depth work.hardeningReliability, safety, operability, and production-readiness improvements.tech-debtDebt cleanup or deferred engineering quality work with limited product-surface change.testingTest coverage, harnesses, regression prevention, and verification pipeline work.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions