[Testing] Follow-ups from the PR #1845 review: failure-dump noise, sibling overlap, worker-isolation dependence

[Chris0Jeky]

Residuals from the PR #1845 review (they would otherwise die with #1822, which that PR closes):

1. Unscoped GetExpiredAsync failure-dump noise. The method returns every expired PendingReview row in the shared per-class test DB, so a failing assertion's dump includes other tests' rows (a corr-expired-target-... row from GetPendingByOperationTargetAsync_..._ExcludesExpired was observed in the [Backend] Flaky: GetExpiredAsync_WithExpiresAtExactlyNow races a 1-second wall-clock window on windows-latest #1822 failure dump). Consider correlation-prefix scoping in assertions to keep failure output attributable.
2. Test overlap. The reworked GetExpiredAsync_ExcludesFutureExpiry... test is now close to a subset of its sibling GetExpiredAsync_ShouldReturnOnlyExpiredPendingReview (~line 72 of AutomationProposalRepositoryIntegrationTests.cs), which additionally proves the status filter. PR test(api): de-flake GetExpiredAsync expiry-boundary integration test (#1822) #1845 kept it with an honest name and a PROVES / DOES-NOT-PROVE comment; "delete as redundant" remains an available answer for a future sweep.
3. Worker-dependence note. The new positive control (Contain on a past-ExpiresAt PendingReview row) is safe only because the class is pinned to HostedWorkerDisabledTestWebApplicationFactory ([Bug] Isolate hosted workers and delayed events in full-suite tests #1335). If the class ever moves to the base factory, ProposalHousekeepingWorker can consume the row and this assertion flakes in the opposite direction. Keep the pin, or make the dependence explicit in the class contract comment.

Source: PR #1845 fresh-context review (non-blocking items 1–3). All LOW; none merge-relevant.

[Chris0Jeky]

Taking bounded slice TD-1853-diagnostics: scope the existing GetExpiredAsync boundary assertions to this test's corr-boundary-* rows so unrelated shared-fixture rows do not flood failure output. I will not change the repository query or remove the worker-disabled fixture.

[Chris0Jeky]

Released the bounded diagnostics slice in PR #2645 at exact head 7501c83040d5e0fe872ac0bf571ee0200c82c0e8. It scopes only the boundary test's assertions to its corr-boundary-* rows; the GetExpiredAsync query and worker-disabled fixture are unchanged. Targeted proof passed 1/1 after the change; the full AutomationProposalRepositoryIntegrationTests class passed 30/30. Two coordinator reviews are clean; hosted automatic Codex review is unavailable at the current account limit, so this remains unmerged.

[Chris0Jeky]

Coordinator note (2026-09-05, D-12 sweep): the Codex session's PR on this issue was reviewed by one fresh-context Opus 5 reviewer (record on the PR) and merged with a merge commit. The PR body used Refs, so this issue stays open; what merged and what remains, from the review:

• PR #2645 merged as 056931325: the GetExpiredAsync boundary test scopes its assertions to its own corr-boundary-* rows without weakening either control. Other tests in the class still assert against the unscoped shared-database result set.