Fix "Risk Differerence" typo and add per-arm follow-up counts to diagnostics#159
Merged
Conversation
Report follow-up per treatment arm on every SEQuential() result as info$followup.unique and info$followup.nonunique, mirroring info$outcome.unique / info$outcome.nonunique. Both are per-subgroup lists grouped by baseline treatment over expanded-data rows with an observed (non-NA) outcome - the person-time the outcome model is fit on - so under method = "censoring" the censoring row is excluded. The non-unique table counts follow-up intervals (so the non-unique outcome counts divided by these give per-arm event rates); the unique table counts the distinct subjects contributing follow-up to each arm (a subject who appears in both arms is counted in each). Both are shown in the printed diagnostic tables.
remlapmot
changed the title
ryan-odea
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I duffed a typo in the
risk.timesoutput.And Paul had a great idea to report follow-up per treatment arm in the
@infoslot. This is done asinfo$followup.uniqueandinfo$followup.nonunique(per subgroup, mirroringinfo$outcome.unique/info$outcome.nonunique). Which is very helpful info. Looks like the following in our short course practical.