From 601912b528dadd432f56c5c2a950b49ddda5b185 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Wed, 11 Nov 2026 20:34:36 +0000 Subject: [PATCH 1/4] feature: port user profile page to React Co-Authored-By: Matthew Guerra --- react-app/package-lock.json | 74 +++++----------------- react-app/package.json | 1 + react-app/src/pages/UserPage.scss | 90 +++++++++++++++++++++++++++ react-app/src/pages/UserPage.test.tsx | 71 +++++++++++++++++++++ react-app/src/pages/UserPage.tsx | 62 ++++++++++++++++-- react-app/src/routes.test.tsx | 10 ++- react-app/src/utils/sanitize.ts | 6 ++ 7 files changed, 250 insertions(+), 64 deletions(-) create mode 100644 react-app/src/pages/UserPage.scss create mode 100644 react-app/src/pages/UserPage.test.tsx create mode 100644 react-app/src/utils/sanitize.ts diff --git a/react-app/package-lock.json b/react-app/package-lock.json index 62919bb7f..03e1ae8ef 100644 --- a/react-app/package-lock.json +++ b/react-app/package-lock.json @@ -8,6 +8,7 @@ "name": "angular2-hn-react", "version": "0.0.0", "dependencies": { + "dompurify": "^3.4.17", "react": "^19.2.0", "react-dom": "^19.2.0", "react-router-dom": "^7.9.0" @@ -1394,9 +1395,6 @@ "arm" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1418,9 +1416,6 @@ "arm" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1442,9 +1437,6 @@ "arm64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1466,9 +1458,6 @@ "arm64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1490,9 +1479,6 @@ "x64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1514,9 +1500,6 @@ "x64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1685,9 +1668,6 @@ "arm" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1702,9 +1682,6 @@ "arm" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1719,9 +1696,6 @@ "arm64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1736,9 +1710,6 @@ "arm64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1753,9 +1724,6 @@ "loong64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1770,9 +1738,6 @@ "loong64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1787,9 +1752,6 @@ "ppc64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1804,9 +1766,6 @@ "ppc64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1821,9 +1780,6 @@ "riscv64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1838,9 +1794,6 @@ "riscv64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -1855,9 +1808,6 @@ "s390x" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1872,9 +1822,6 @@ "x64" ], "dev": true, - "libc": [ - "glibc" - ], "license": "MIT", "optional": true, "os": [ @@ -1889,9 +1836,6 @@ "x64" ], "dev": true, - "libc": [ - "musl" - ], "license": "MIT", "optional": true, "os": [ @@ -2184,6 +2128,13 @@ "@types/react": "^19.3.0" } }, + "node_modules/@types/trusted-types": { + "version": "2.0.7", + "resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz", + "integrity": "sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==", + "license": "MIT", + "optional": true + }, "node_modules/@typescript-eslint/eslint-plugin": { "version": "8.72.2", "resolved": "https://registry.npmjs.org/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.72.2.tgz", @@ -3067,6 +3018,15 @@ "license": "MIT", "peer": true }, + "node_modules/dompurify": { + "version": "3.4.17", + "resolved": "https://registry.npmjs.org/dompurify/-/dompurify-3.4.17.tgz", + "integrity": "sha512-B/pSlYVHQ58kqISD/yDjuJ1yfzI34m1gF4lAod2bwSRhiN4K5Cl3H8Af7hqB2PmTL911tdEudnnXn5FnhRoz0w==", + "license": "(MPL-2.0 OR Apache-2.0)", + "optionalDependencies": { + "@types/trusted-types": "^2.0.7" + } + }, "node_modules/electron-to-chromium": { "version": "1.5.481", "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.5.481.tgz", diff --git a/react-app/package.json b/react-app/package.json index f4269a831..7eef234ff 100644 --- a/react-app/package.json +++ b/react-app/package.json @@ -13,6 +13,7 @@ "test:watch": "vitest" }, "dependencies": { + "dompurify": "^3.4.17", "react": "^19.2.0", "react-dom": "^19.2.0", "react-router-dom": "^7.9.0" diff --git a/react-app/src/pages/UserPage.scss b/react-app/src/pages/UserPage.scss new file mode 100644 index 000000000..f04aacbf1 --- /dev/null +++ b/react-app/src/pages/UserPage.scss @@ -0,0 +1,90 @@ +@use "../styles/media" as *; + +.user-page { +pre { + white-space: pre-wrap; +} + +.profile { + padding: 30px; +} + +@media #{$mobile-only} { + .profile { + padding: 110px 15px 0 15px; + } + .title-block { + font-size: 15px; + text-align: center; + text-overflow: ellipsis; + white-space: nowrap; + overflow: hidden; + margin: 0 75px; + } + .back-button { + position: absolute; + top: 52%; + width: 0.6rem; + height: 0.6rem; + background: transparent; + box-shadow: 0 0 0 lightgray; + transition: all 200ms ease; + left: 4%; + transform: translate3d(0, -50%, 0) rotate(-135deg); + } + .item-header { + padding-bottom: 10px; + background-color: #fff; + padding: 10px 0 10px 0; + position: fixed; + width: 100%; + left: 0; + top: 62px; + height: 20px; + } +} + +@media #{$laptop-only} { + .mobile { + display: none; + } +} + +.main-details { + .name { + font-weight: bold; + font-size: 32px; + letter-spacing: 2px; + } + .age { + font-weight: bold; + color: #696969; + padding-bottom: 0; + } + .right { + float: right; + font-weight: bold; + font-size: 32px; + letter-spacing: 2px; + } +} + +@media #{$mobile-only} { + .main-details { + margin-top: 20px; + .name { + font-size: 18px; + } + } +} + +@media #{$mobile-only} { + .main-details .right { + font-size: 18px; + } +} + +.other-details { + word-wrap: break-word; +} +} diff --git a/react-app/src/pages/UserPage.test.tsx b/react-app/src/pages/UserPage.test.tsx new file mode 100644 index 000000000..ef407ec00 --- /dev/null +++ b/react-app/src/pages/UserPage.test.tsx @@ -0,0 +1,71 @@ +import { render, screen } from '@testing-library/react'; +import userEvent from '@testing-library/user-event'; +import { createMemoryRouter, RouterProvider } from 'react-router-dom'; +import { afterEach, describe, expect, it, vi } from 'vitest'; +import { routes } from '../routes'; +import { SettingsProvider } from '../settings'; + +const PG = 'https://api.hnpwa.com/v0/user/pg.json'; + +function stubApi(byUrl: Record) { + const fn = vi.fn(async (url: string) => + url in byUrl ? Response.json(byUrl[url]) : new Response('nope', { status: 404 }) + ); + vi.stubGlobal('fetch', fn); + return fn; +} + +function renderAt(path: string) { + const router = createMemoryRouter(routes, { initialEntries: ['/news/1', path], initialIndex: 1 }); + render( + + + + ); + return router; +} + +afterEach(() => vi.unstubAllGlobals()); + +describe('UserPage', () => { + it('renders the profile with karma, age and sanitized about HTML', async () => { + stubApi({ + [PG]: { + id: 'pg', + karma: 157236, + created: '19 years ago', + created_time: 1160418092, + about: '

Bug fixer.

', + }, + }); + renderAt('/user/pg'); + expect(await screen.findByText('157236 ★')).toBeInTheDocument(); + expect(screen.getByText('Created 19 years ago')).toBeInTheDocument(); + expect(screen.getByText('Profile: pg')).toBeInTheDocument(); + expect(screen.getByText('Bug fixer.')).toBeInTheDocument(); + expect(screen.getByTestId('user-page').innerHTML).not.toContain('onerror'); + }); + + it('omits the about section when empty', async () => { + stubApi({ [PG]: { id: 'pg', karma: 1, created: 'today', created_time: 0 } }); + renderAt('/user/pg'); + await screen.findByText('1 ★'); + expect(document.querySelector('.other-details')).toBeNull(); + }); + + it('goes back from the mobile back button', async () => { + stubApi({ + [PG]: { id: 'pg', karma: 1, created: 'today', created_time: 0 }, + 'https://node-hnapi.herokuapp.com/news?page=1': [], + }); + const router = renderAt('/user/pg'); + await userEvent.click(await screen.findByRole('button', { name: 'Back' })); + expect(router.state.location.pathname).toBe('/news/1'); + }); + + it('shows an error for an unknown user', async () => { + stubApi({}); + renderAt('/user/nobody'); + expect(await screen.findByText(/Could not load user nobody\./)).toBeInTheDocument(); + }); +}); diff --git a/react-app/src/pages/UserPage.tsx b/react-app/src/pages/UserPage.tsx index edd5cd826..1bd36f34c 100644 --- a/react-app/src/pages/UserPage.tsx +++ b/react-app/src/pages/UserPage.tsx @@ -1,11 +1,63 @@ -import { useParams } from 'react-router-dom'; +import { useEffect, useState } from 'react'; +import { useNavigate, useParams } from 'react-router-dom'; +import { fetchUser } from '../api/hackerNewsApi'; +import { ErrorMessage } from '../components/ErrorMessage/ErrorMessage'; +import { Loader } from '../components/Loader/Loader'; +import type { User } from '../models'; +import { sanitizedHtml } from '../utils/sanitize'; +import './UserPage.scss'; + +type UserState = { id: string; user?: User; error?: string }; -// Placeholder: ported from user in the user profile PR. export default function UserPage() { - const { id } = useParams(); + const id = useParams().id ?? ''; + const navigate = useNavigate(); + const [state, setState] = useState({ id }); + + useEffect(() => { + const controller = new AbortController(); + fetchUser(id, controller.signal).then( + (user) => setState({ id, user }), + () => { + if (!controller.signal.aborted) { + setState({ id, error: `Could not load user ${id}.` }); + } + } + ); + return () => controller.abort(); + }, [id]); + + const { user, error } = state.id === id ? state : { user: undefined, error: undefined }; + return ( -
- user {id} +
+ {!user && !error && } + {!user && error && } + {user && ( +
+
+

+ navigate(-1)} + /> + Profile: {user.id} +

+
+
+ {user.id} + {user.karma} ★ +

Created {user.created}

+
+ {user.about && ( +
+

+

+ )} +
+ )}
); } diff --git a/react-app/src/routes.test.tsx b/react-app/src/routes.test.tsx index b0b057770..2f46e52f0 100644 --- a/react-app/src/routes.test.tsx +++ b/react-app/src/routes.test.tsx @@ -1,6 +1,6 @@ import { render, screen } from '@testing-library/react'; import { createMemoryRouter, RouterProvider } from 'react-router-dom'; -import { describe, expect, it } from 'vitest'; +import { afterEach, describe, expect, it, vi } from 'vitest'; import { routes } from './routes'; import { SettingsProvider } from './settings'; @@ -14,6 +14,8 @@ function renderAt(path: string) { return router; } +afterEach(() => vi.unstubAllGlobals()); + describe('routes', () => { it('redirects / to /news/1', async () => { const router = renderAt('/'); @@ -32,8 +34,12 @@ describe('routes', () => { }); it('serves the user page', async () => { + vi.stubGlobal( + 'fetch', + vi.fn(async () => Response.json({ id: 'pg', karma: 1, created: 'today', created_time: 0 })) + ); renderAt('/user/pg'); - expect(await screen.findByTestId('user-page')).toHaveTextContent('user pg'); + expect(await screen.findByText('Profile: pg')).toBeInTheDocument(); }); it('applies the theme class', async () => { diff --git a/react-app/src/utils/sanitize.ts b/react-app/src/utils/sanitize.ts new file mode 100644 index 000000000..c91f0fbd6 --- /dev/null +++ b/react-app/src/utils/sanitize.ts @@ -0,0 +1,6 @@ +import DOMPurify from 'dompurify'; + +// Angular's [innerHTML] sanitized API HTML; React's dangerouslySetInnerHTML does not. +export function sanitizedHtml(html: string | undefined): { __html: string } { + return { __html: DOMPurify.sanitize(html ?? '') }; +} From 430c041e8bac2ab8bb2843d6be29e6c14aeeaa02 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Wed, 11 Nov 2026 20:36:15 +0000 Subject: [PATCH 2/4] bug: make profile back control keyboard-operable Co-Authored-By: Matthew Guerra --- react-app/src/pages/UserPage.test.tsx | 11 +++++++++++ react-app/src/pages/UserPage.tsx | 8 ++------ react-app/src/utils/activateOnKey.ts | 16 ++++++++++++++++ 3 files changed, 29 insertions(+), 6 deletions(-) create mode 100644 react-app/src/utils/activateOnKey.ts diff --git a/react-app/src/pages/UserPage.test.tsx b/react-app/src/pages/UserPage.test.tsx index ef407ec00..8024932f2 100644 --- a/react-app/src/pages/UserPage.test.tsx +++ b/react-app/src/pages/UserPage.test.tsx @@ -63,6 +63,17 @@ describe('UserPage', () => { expect(router.state.location.pathname).toBe('/news/1'); }); + it('goes back from the keyboard', async () => { + stubApi({ + [PG]: { id: 'pg', karma: 1, created: 'today', created_time: 0 }, + 'https://node-hnapi.herokuapp.com/news?page=1': [], + }); + const router = renderAt('/user/pg'); + (await screen.findByRole('button', { name: 'Back' })).focus(); + await userEvent.keyboard('{Enter}'); + expect(router.state.location.pathname).toBe('/news/1'); + }); + it('shows an error for an unknown user', async () => { stubApi({}); renderAt('/user/nobody'); diff --git a/react-app/src/pages/UserPage.tsx b/react-app/src/pages/UserPage.tsx index 1bd36f34c..f97216cb8 100644 --- a/react-app/src/pages/UserPage.tsx +++ b/react-app/src/pages/UserPage.tsx @@ -4,6 +4,7 @@ import { fetchUser } from '../api/hackerNewsApi'; import { ErrorMessage } from '../components/ErrorMessage/ErrorMessage'; import { Loader } from '../components/Loader/Loader'; import type { User } from '../models'; +import { buttonProps } from '../utils/activateOnKey'; import { sanitizedHtml } from '../utils/sanitize'; import './UserPage.scss'; @@ -37,12 +38,7 @@ export default function UserPage() {

- navigate(-1)} - /> + navigate(-1))} /> Profile: {user.id}

diff --git a/react-app/src/utils/activateOnKey.ts b/react-app/src/utils/activateOnKey.ts new file mode 100644 index 000000000..a127c5620 --- /dev/null +++ b/react-app/src/utils/activateOnKey.ts @@ -0,0 +1,16 @@ +import type { KeyboardEvent } from 'react'; + +// Keyboard activation for span-based controls whose look comes from themed borders. +export function buttonProps(onActivate: () => void) { + return { + role: 'button', + tabIndex: 0, + onClick: onActivate, + onKeyDown: (e: KeyboardEvent) => { + if (e.key === 'Enter' || e.key === ' ') { + e.preventDefault(); + onActivate(); + } + }, + } as const; +} From e3a88deb43f83d2d78d64c3f44b551dceefea2e3 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 12 Nov 2026 09:53:09 +0000 Subject: [PATCH 3/4] bug: re-trigger GitHub Actions CI stuck in runner backlog Co-Authored-By: Matthew Guerra From f136e8ff7c9f55af7bb229c451cb6b393c89f33f Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 12 Nov 2026 09:55:48 +0000 Subject: [PATCH 4/4] bug: ignore profile responses after navigating to another user Co-Authored-By: Matthew Guerra --- react-app/src/pages/UserPage.test.tsx | 29 ++++++++++++++++++++++++++- react-app/src/pages/UserPage.tsx | 4 +++- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/react-app/src/pages/UserPage.test.tsx b/react-app/src/pages/UserPage.test.tsx index 8024932f2..cccacfd93 100644 --- a/react-app/src/pages/UserPage.test.tsx +++ b/react-app/src/pages/UserPage.test.tsx @@ -1,4 +1,4 @@ -import { render, screen } from '@testing-library/react'; +import { render, screen, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { createMemoryRouter, RouterProvider } from 'react-router-dom'; import { afterEach, describe, expect, it, vi } from 'vitest'; @@ -74,6 +74,33 @@ describe('UserPage', () => { expect(router.state.location.pathname).toBe('/news/1'); }); + it('shows the latest profile when an earlier request resolves late', async () => { + let releasePg!: () => void; + const pgHeld = new Promise((resolve) => (releasePg = resolve)); + const signals: AbortSignal[] = []; + vi.stubGlobal( + 'fetch', + vi.fn(async (url: string, init?: RequestInit) => { + if (url === PG) { + signals.push(init!.signal!); + await pgHeld; + return Response.json({ id: 'pg', karma: 1, created: 'today', created_time: 0 }); + } + return Response.json({ id: 'sama', karma: 2, created: 'today', created_time: 0 }); + }) + ); + const router = renderAt('/user/pg'); + await waitFor(() => expect(signals).toHaveLength(1)); + await router.navigate('/user/sama'); + expect(await screen.findByText('Profile: sama')).toBeInTheDocument(); + expect(signals[0].aborted).toBe(true); + releasePg(); + await pgHeld; + await new Promise((resolve) => setTimeout(resolve, 0)); + expect(screen.getByText('Profile: sama')).toBeInTheDocument(); + expect(screen.queryByText('Profile: pg')).not.toBeInTheDocument(); + }); + it('shows an error for an unknown user', async () => { stubApi({}); renderAt('/user/nobody'); diff --git a/react-app/src/pages/UserPage.tsx b/react-app/src/pages/UserPage.tsx index f97216cb8..4c1b08fb7 100644 --- a/react-app/src/pages/UserPage.tsx +++ b/react-app/src/pages/UserPage.tsx @@ -18,7 +18,9 @@ export default function UserPage() { useEffect(() => { const controller = new AbortController(); fetchUser(id, controller.signal).then( - (user) => setState({ id, user }), + (user) => { + if (!controller.signal.aborted) setState({ id, user }); + }, () => { if (!controller.signal.aborted) { setState({ id, error: `Could not load user ${id}.` });