Skip to content

chore: exclude .vscode from WordPress SVN releases#6

Merged
wzul merged 3 commits into
mainfrom
fix/exclude-vscode-from-svn
Jun 3, 2026
Merged

chore: exclude .vscode from WordPress SVN releases#6
wzul merged 3 commits into
mainfrom
fix/exclude-vscode-from-svn

Conversation

@wzul

@wzul wzul commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

What does this change?

This PR focuses on repository hygiene and long-term architectural planning for the CHIP for GiveWP plugin.

Key changes include:

  • Exclusion of IDE configurations: Added .vscode/ to .gitattributes with the export-ignore attribute and updated the GitHub Actions deployment workflow (deploy.yml) to include --exclude='.vscode' in the rsync command. This prevents local workspace settings from being included in git archive outputs or shipped to the WordPress.org SVN trunk.
  • Recurring Payments Feasibility Study: Introduced docs/recurring-feasibility.md, a comprehensive technical roadmap. This document analyzes the CHIP "Charge Token API," outlines necessary GiveWP hooks for both legacy and v3 visual forms, and provides a risk assessment for implementing subscription logic (scheduler, dunning, and token management).

How to test

  1. Verify Git Attributes: Run git archive -o latest.zip HEAD and inspect the resulting ZIP file to confirm the .vscode folder is excluded.
  2. Workflow Syntax: Review .github/workflows/deploy.yml to ensure the --exclude='.vscode' flag is correctly positioned within the rsync options.
  3. Documentation Review: Read docs/recurring-feasibility.md to verify that the technical assumptions regarding GiveWP’s Recurring Donations add-on and CHIP’s tokenization flow are accurate.

Potential Risks & Review Items

  • Workflow Syntax: Ensure the rsync exclude syntax in deploy.yml doesn't interfere with existing exclusions.
  • Documentation Accuracy: The feasibility assessment is dated "2026-06-02." Verify if this is an intentional placeholder or if it should be updated to the current date.
  • No Runtime Impact: These changes are restricted to repository configuration and documentation; they do not modify the plugin's execution logic.

Is this PR safe for automatic approval?

Yes. The changes are limited to repository configuration (ignoring IDE files) and adding a documentation-only markdown file.

Images

Related Tasks / PRs

Checklist

  • Unit tests provided?
  • All tests passing?
  • Tested in staging?
  • Task link provided?

wzul and others added 3 commits June 3, 2026 11:08
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Add .vscode/ to .gitattributes export-ignore
- Add --exclude='.vscode' to deploy.yml rsync as safety net

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Update all existing class filenames to match the actual codebase
naming convention (e.g. class-chip-givewp-api.php, not class-api.php).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@wzul wzul merged commit 5d7a9da into main Jun 3, 2026
10 checks passed
@wzul wzul deleted the fix/exclude-vscode-from-svn branch June 3, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant