Update d2l-scroll-wrapper to use semantic variables.#7011
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dbatiste
commented
May 22, 2026
| function getFocusStyleSheet() { | ||
| if (!focusStyleSheet) { | ||
| focusStyleSheet = new CSSStyleSheet(); | ||
| focusStyleSheet.replaceSync(getFocusRingStyles( |
Contributor
Author
There was a problem hiding this comment.
There's a bit of history around this. The 0 2px 12px 0 rgba(0, 0, 0, 0.15) is our "floating" shadow. I think it was unintentionally copied forward when the focus styles were moved from the scroller buttons to the scroll-wrapper container. At the time, the shadow was also being used for the focus outline. We don't really want or need this shadow.
dlockhart
approved these changes
May 22, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.253.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-9480
This PR updates
d2l-scroll-wrapperto use semantic variables.Notably, there was a floating shadow that has been copied forward from when the focus was moved from the buttons to the scroll-wrapper container several years ago. I've confirmed with Jeff that we don't need/want that, and removed it.