Compact role editing and restore tenant-scoped Team, Customers and SLA administration - #57
Merged
Merged
Conversation
7 tasks
Proxicon
marked this pull request as ready for review
September 16, 2026 15:32
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #56.
This draft implements the compact role-editing/Team portion of the issue and the role-catalog upgrade path. It deliberately does not claim completion of tenant-scoped Customers or the four tenant SLA panels; those routes remain instance-admin-only in this draft.
Included
TenantRoleAssignmentDialog, used by Organizations, scoped Team, and the eligible linked-customer access surface./admin/usersforTenant.Users.Manage/Tenant.Roles.Assign; instance administrators retain the global Team workflow. The tenant navigation links Team without duplicating the instance administration tree.Tenant.Customers.ManageandTenant.Sla.Manageto the protected Tenant Administrator catalog and idempotent seed reconciliation, while keeping both outside the delegation ceiling. The tenant lookup endpoint now has an explicit permission allowlist and supports the new permissions.Authorization matrix
Tenant.Users.ManageorTenant.Roles.Assignin the selected tenantTenant.Roles.Assignin the selected tenantTenant.Users.ManageandTenant.Roles.Assignin the same tenantHelpdeskAdminonlyHelpdeskAdminonlyUpgrade impact
The existing
RoleDefinitionSeederreconciles persisted protected Tenant Administrator definitions on startup and role-definition reads. Existing assignments inherit the two new capabilities; custom roles and the tenant delegation ceiling are unchanged. No database migration is required.Validation
dotnet build Helpdesk.sln --configuration Release --no-restore— passed (existing project warnings only).CurrentUserAccessServiceTestsandPageAuthorizationConventionsTests— passed, 17/17.Base SHA:
1f80f1b5970b8cbf18c0e1b5d286f60a2b734e8e.Implementation commit: 77b0e2a.
No private/customer screenshots or data are included.