TRP-46 Refactor GitHub Login to generate href state instead of onclick

[median-app]

Median Task: TRP-46

Median Task: TRP-46

Calculate the GitHub OAuth state on the server or via a loader and pass the generated URL directly to the anchor tag's href attribute. This ensures the link is natively navigable, supportable for 'open in new tab', and allows for previewing the destination URL.

[OpeOginni]

I want to add in another issue here, maybe I can solve both in 1 PR.

Currently when you reconfigure the github repos, connected to the tripwire app, lets say you move from "all repos", to just 5, the db still has all of them, instead of just the 5 that were put in.

I doubt this is how it should be.

Only issue I can find is that if you have some data for a repo and then on this change that repo is not part of those given access to the Github App, then you can lose all data for that repo...or it is kept.

What do you think @ripgrim

[ripgrim]

I think this should be its own pr - but are you asking if we should wipe the data from a repo removed from the github integration's state?

[OpeOginni]

Yes, also remove it from the DB, to properly show which repos are connected currently.

[ripgrim]

I like it. Ship it

[OpeOginni]

Also, i see you just fixed this one

[OpeOginni]

@ripgrim got it here #65