Follow-up nits from the dual-lens review of #72 (CLI/persona/scanner hardening). All LOW severity — none blocked the merge.
-
cli/commands/persona.py (~99-105) — the r'^persona\s*=\s*"[^"]*"' re-write regex mis-matches an already-escaped persona value on disk (e.g. persona = "evil\"name"), producing corrupt TOML. Match the full quoted value including escapes, or parse-and-rewrite structurally.
-
persona set-path vs load-path validation parity — persona_set accepts any name in available() (no slug check) and writes it TOML-safely, but PersonaLoader.load() now rejects non-slug names and silently falls back to minimal. So bonfire persona set MyPersona reports success yet the persona never loads. Validate in persona_set too (reuse _is_valid_persona_name), or filter available().
-
dispatch/sdk_backend.py traceback-redaction docstring — claims "Python tracebacks include local-frame repr data"; stdlib format_exc() does not dump locals (that needs capture_locals=True). The redaction fix is still net-positive, but correct the rationale comment so a future reader doesn't trust a false premise. Also stale: tool_policy.py:30 docstring still references permission_mode='dontAsk' as the deny-all combination.
Follow-up nits from the dual-lens review of #72 (CLI/persona/scanner hardening). All LOW severity — none blocked the merge.
cli/commands/persona.py(~99-105) — ther'^persona\s*=\s*"[^"]*"'re-write regex mis-matches an already-escaped persona value on disk (e.g.persona = "evil\"name"), producing corrupt TOML. Match the full quoted value including escapes, or parse-and-rewrite structurally.persona set-path vs load-path validation parity —
persona_setaccepts any name inavailable()(no slug check) and writes it TOML-safely, butPersonaLoader.load()now rejects non-slug names and silently falls back tominimal. Sobonfire persona set MyPersonareports success yet the persona never loads. Validate inpersona_settoo (reuse_is_valid_persona_name), or filteravailable().dispatch/sdk_backend.pytraceback-redaction docstring — claims "Python tracebacks include local-frame repr data"; stdlibformat_exc()does not dump locals (that needscapture_locals=True). The redaction fix is still net-positive, but correct the rationale comment so a future reader doesn't trust a false premise. Also stale:tool_policy.py:30docstring still referencespermission_mode='dontAsk'as the deny-all combination.