Skip to content

Commit 4ad1248

Browse files
BitHighlanderclaude
andcommitted
test(eth): gate EIP-1559 chunked-data regression on firmware 7.14.1+
Upstreaming this test as a permanent regression guard rather than a one-shot bug catcher. Bumping requires_firmware from 7.2.1 (the version where EIP-1559 support originally landed) to 7.14.1 (the first version where the access-list ordering bug is fixed) so CI on broken builds skips this test instead of flagging a known-broken state as a new regression. The header comment already documents the affected range (7.x.0 .. 7.14.0) and the fix landing in 7.14.1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c7f01aa commit 4ad1248

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

tests/test_msg_ethereum_signtx_chunked_data_eip1559.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,11 @@ def _recover_eth_address(msg_hash, v, r, s):
100100

101101
def test_eip1559_chunked_data_signature_recovers_to_device_address(self):
102102
self.requires_fullFeature()
103-
self.requires_firmware("7.2.1") # EIP-1559 support landed here
103+
# Gate on the fixed firmware. The bug this test asserts against shipped
104+
# in 7.x.0 .. 7.14.0 (see header comment); 7.14.1 is the first release
105+
# where the canonical pre-image is hashed correctly. Skip on older
106+
# firmware so CI doesn't flag a known-broken build as a new regression.
107+
self.requires_firmware("7.14.1")
104108
self.setup_mnemonic_allallall()
105109
self.client.apply_policy("AdvancedMode", 1) # blind-sign opt-in
106110

0 commit comments

Comments
 (0)