Kanban thymeleaf#1
Open
Bael wants to merge 10 commits into
Open
Conversation
add first test on mvc
add frontent - backend interaction for tasks
ydvorzhetskiy
approved these changes
Oct 11, 2018
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> No newline at end of file |
There was a problem hiding this comment.
Добавьте уже *.iml в .gitignore и удалите из репозитория)
| return boardService.update(boardDTO); | ||
| } | ||
|
|
||
| @RequestMapping(value = {"/boards/edit"}, method = RequestMethod.POST) |
| return "redirect:/error"; | ||
| } | ||
| model.addAttribute("boards", boardService.findAll()); | ||
| return "redirect:/boards"; |
There was a problem hiding this comment.
Клёво! Но я бы последни две строчки прямо в try бы и оставил.
| String taskNotFoundHandler(TaskNotFoundException ex) { | ||
| return ex.getMessage(); | ||
| } | ||
| } |
There was a problem hiding this comment.
КРуто! А для REST контроллеров, это кстати можно сделать с помощью аннотации @ResponseStatus
| } | ||
|
|
||
| @CrossOrigin(origins = "${client.url}") | ||
| @RequestMapping(method = RequestMethod.GET, value = "/stages/{id}/tasks") |
| value="Reset"/></p> | ||
| </form> | ||
| <form action="#" th:action="@{/boards/delete/(id=${board.id})}" method="post"> | ||
| <p><input class="button is-danger" type="submit" value="Delete board"/></p> |
There was a problem hiding this comment.
Использование p - это только для большого абзаца текста, прям текста, как в книжке или статье.
В формах и на страницах использовать его не надо.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homework #9
Сделал канбан на серверных страницах, в целом странные ощущения, с SPA как то чище, есть интерфейс и апи, а тут контроллеры понамешаны и на логику и на возврат шаблонов.
Смотреть папку kanban-server