Logic question

[GuySchnidrig]

@damian-oswald

Logic question on line 82 in create_products.py on 36-check-data-integrity-product---organisation

        # Case 1: Regular Product or Sale Permission
          if raw_type in ["REGULAR", "SALE_PERMISSION"]:
              if pd.notna(row.get("w_number")):
                  w_number_str = str(row.get("w_number")).strip()
                  # Apply W- prefix (W-numbers only have the prefix for parallel products...)
                  fed_adm_num = f"W-{w_number_str}"
                  graph.add((product_uri, BASE.federalAdmissionNumber, Literal(fed_adm_num, datatype=XSD.string)))

product:00260F63-207E-4675-B8C8-851AA2603AEB a :ParallelImport ;
    schema1:name "Titus 25 DF"@de ;
    :federalAdmissionNumber "D-7254"^^xsd:string ;
    :foreignAdmissionNumber "034273-00/065"^^xsd:string ;
    :packageInsertNumber "4521"^^xsd:string ;
    :producingCountry country:DEU ;
    :referenceProduct product:10645A4A-908F-40E6-BEA1-26D35A370235 .

product:007E8933-BEE8-44EF-93FC-B670703F7D5E a :SalePermission ;
    schema1:name "MIOPLANT Rasen-Unkrautvertilger"@de ;
    :exhaustionDeadline "2026-10-31"^^xsd:date ;
    :federalAdmissionNumber "W-6719-1"^^xsd:string ;
    :producingCountry country:CHE ;
    :referenceProduct product:2A7FA096-6AD4-48B0-9FE6-66F0FA6BCFFA ;
    :soldOutDeadline "2025-10-31"^^xsd:date .

Is this the right way around? the code makes the prefix for regular and sales - not parallel

[damian-oswald]

Is this the right way around? the code makes the prefix for regular and sales - not parallel

This way of processing reproduces the way the federal admission number is displayed on <psm.admin.ch>, see:

1. Standard product: https://www.psm.admin.ch/de/produkte/7137
2. Parallel import: https://www.psm.admin.ch/de/produkte/F-4807

Something like "W-..." is a regular product or sales permission; any other starting letter is a parallel import.

However, this is a question for the SMEs; as it is incoherent in the data and the frontend display.

[GuySchnidrig]

Do you have an example of incoherent data entry:

In theorie

federalAdmissionNumber = Zulassungsnummer, die bei der Bewilligung vergeben wird
REGULAR: W-Nummer des Produkts so

• add W to w_number as you implemented

SALES PERMISSION: W-Nummer der Sales Permission (= W-Nummer des Referenzproduktes & Laufnummer)

• add W to w_number as you implemented

PARALLELIMPORT: Länderkürzel & PI Nummer

• we can just use record_id

[damian-oswald]

Do you have an example of incoherent data entry

Just the fact that the W-number does not exist as such in the tables; I assume there is quite a bit of logic in the front-end.

[GuySchnidrig]

I suspect it's just for visual coherence.
see #39

[damian-oswald]

I suspect it's just for visual coherence. see #39

It's a little more than that, because commercial products also display the W-number with the W as a prefix. I'd propose we just ask the SMEs about their understanding of the matter.

[GuySchnidrig]

I'd propose we just ask the SMEs about their understanding of the matter.

For sure

In my head if I would make numbers like I-4841 where I is for italy i would apply a letter to all others hence W is added everywhere else where there no parallel import. But let us ask SMEs!