From 630f661dc82cac62cd7f9a96db7110dd49566ca7 Mon Sep 17 00:00:00 2001
From: James Le Houx <james.le-houx@gre.ac.uk>
Date: Wed, 29 Apr 2026 14:00:40 +0000
Subject: [PATCH] =?UTF-8?q?drop=20redundant=20strip+repack=20pass=20?=
 =?UTF-8?q?=E2=80=94=20auditwheel=20--strip=20already=20handles=20=5Fcore.?=
 =?UTF-8?q?so?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Confirmed from the previous build log:

    INFO:auditwheel.repair:Stripping symbols from openimpala/_core.cpython-312-x86_64-linux-gnu.so

auditwheel --strip strips the main extension module too, not just the
vendored libs. My earlier assumption was wrong, and the custom unpack /
strip / `wheel pack` post-pass was redundant — and broke at runtime
because the cibuildwheel-runtime python doesn't have the `wheel` package
installed (it's only in the build venv).

The wheel landed at 259 MiB after the arch trim + auditwheel --strip,
comfortably under PyPI's 320 MiB ceiling for openimpala-cuda. Drop the
custom pass and write directly to {dest_dir}.

https://claude.ai/code/session_011dJ5Bwq4Tnr8wxH597XJFf
---
 .github/workflows/pypi-wheels-gpu.yml | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/pypi-wheels-gpu.yml b/.github/workflows/pypi-wheels-gpu.yml
index ef79d06..153f79b 100644
--- a/.github/workflows/pypi-wheels-gpu.yml
+++ b/.github/workflows/pypi-wheels-gpu.yml
@@ -178,13 +178,11 @@ jobs:
 
           # Vendor libraries but exclude host-specific MPI, OpenMP, Fortran runtime,
           # and CUDA runtime libraries (users must have CUDA toolkit installed).
-          # auditwheel --strip only touches vendored libs, NOT the main extension
-          # _core.so where most of the bloat lives. After auditwheel, unpack the
-          # wheel, run strip --strip-all on every .so (including _core.so), then
-          # repack via `wheel pack` so RECORD hashes regenerate.
+          # auditwheel --strip strips both vendored libs AND the main _core.so —
+          # combined with the 2 SASS + 1 PTX arch trim, this brings the wheel
+          # comfortably under PyPI's 320 MiB ceiling (~260 MiB observed).
           CIBW_REPAIR_WHEEL_COMMAND_LINUX: >
-            mkdir -p /tmp/repaired &&
-            auditwheel repair --strip -w /tmp/repaired {wheel}
+            auditwheel repair --strip -w {dest_dir} {wheel}
             --exclude libmpi.so
             --exclude libmpi.so.12
             --exclude libmpi.so.40
@@ -213,16 +211,7 @@ jobs:
             --exclude libcurand.so
             --exclude libcurand.so.10
             --exclude libnvJitLink.so
-            --exclude libnvJitLink.so.12 &&
-            for whl in /tmp/repaired/*.whl; do
-              echo "Pre-strip wheel size:" && ls -lh "$whl" &&
-              d=$(mktemp -d) &&
-              python3 -m wheel unpack --dest "$d" "$whl" &&
-              find "$d" -type f \( -name '*.so' -o -name '*.so.*' \) -print -exec strip --strip-all {} + &&
-              python3 -m wheel pack --dest-dir {dest_dir} "$d"/*/ &&
-              echo "Post-strip wheel size:" && ls -lh {dest_dir}/*.whl &&
-              rm -rf "$d" "$whl";
-            done
+            --exclude libnvJitLink.so.12
 
       - name: Upload wheels as artifacts
         uses: actions/upload-artifact@v4