From edc960708c74cb7db4a5c5d7a547e4a88672d5cd Mon Sep 17 00:00:00 2001
From: Mustafacco <79732789+mustafacco7@users.noreply.github.com>
Date: Fri, 18 Oct 2024 01:51:45 +0300
Subject: [PATCH 1/2] Fix Azure file share premium v1 GRS issue

Fixes #172

Add alternative recommendations for premium storage accounts in the Reliability Workbook Advisor.

* Add a new section to provide information about using ZRS and AVD mechanisms like CloudCache for premium storage accounts.
* Include a conditional visibility parameter to display this information only when the "Help" parameter is set to "Yes".

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Azure/reliability-workbook/issues/172?shareId=XXXX-XXXX-XXXX-XXXX).
---
 workbooks/ReliabilityWorkbookAdvisor.workbook | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/workbooks/ReliabilityWorkbookAdvisor.workbook b/workbooks/ReliabilityWorkbookAdvisor.workbook
index c23d078..76bffc3 100644
--- a/workbooks/ReliabilityWorkbookAdvisor.workbook
+++ b/workbooks/ReliabilityWorkbookAdvisor.workbook
@@ -305,6 +305,19 @@
                         "sortBy": []
                       },
                       "name": "query - 0"
+                    },
+                    {
+                      "type": 1,
+                      "content": {
+                        "json": "> For premium storage accounts, GRS is not available. Instead, consider using ZRS and relying on AVD mechanisms like CloudCache for replication.",
+                        "style": "info"
+                      },
+                      "conditionalVisibility": {
+                        "parameterName": "Help",
+                        "comparison": "isEqualTo",
+                        "value": "Yes"
+                      },
+                      "name": "Premium Storage Recommendation"
                     }
               ]
             },

From 3c7a6a97a023bbef8bd772e02d04b34f9485c853 Mon Sep 17 00:00:00 2001
From: Mustafacco <79732789+mustafacco7@users.noreply.github.com>
Date: Fri, 18 Oct 2024 02:07:10 +0300
Subject: [PATCH 2/2] Add SKU/Tier information to the workbook report and
 refine logic for GRS recommendations

* Add SKU/Tier information to `workbooks/azuredeploy_export.json` to help users identify the type of storage account being used
* Update KQL queries in `workbooks/azuredeploy_export.json` to retrieve and display SKU/Tier information for each storage account
* Refine logic in `workbooks/azuredeploy.json` to detect premium storage accounts and exclude them from GRS recommendations
* Add condition in `workbooks/azuredeploy.json` queries to check for storage account kind and tier, and only recommend GRS for non-premium accounts