diff --git a/CHANGELOG.md b/CHANGELOG.md index 9365203..e20c3e6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 The remaining 71 regenerated clients carry accumulated output from generator fixes that merged after their last regeneration, rather than new behaviour introduced here. (AzureUX-BPM PR 16618864) +- **`purviewAcccountName` parameter corrected to `purviewAccountName` on SQL Server and Azure Blob Storage** — the shared Purview query parameter declares its `name` correctly but carries a triple-c typo in its `x-ms-summary`, and the generator derives the C# identifier from the summary. The misspelling therefore reached the public API surface while the wire query key was always correct, so this changes the identifier only, not request behaviour. Callers passing the parameter positionally are unaffected; callers using a named argument must rename it. Affects 12 occurrences in `SqlExtensions` and 20 in `AzureBlobExtensions`. (AzureUX-BPM PR 16639935) + - **SQL Server metadata methods now address the default dataset; the server- and database-scoped forms moved to `V2` names** — the unversioned operation owns the unversioned method name, matching the Python SDK. Existing callers must rename: | Before | After | diff --git a/src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs b/src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs index fb5cfdc..fa06cbb 100644 --- a/src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs +++ b/src/Azure.Connectors.Sdk/Generated/AzureBlobExtensions.cs @@ -1010,10 +1010,10 @@ public virtual async Task> GetAccessPolici /// Blob /// Infer content type /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get blob content (V2) response. - public virtual async Task GetFileContentAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetFileContentAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileContentAsync"); try @@ -1027,8 +1027,8 @@ public virtual async Task GetFileContentAsync([DynamicValues("GetDataSet queryParams.Add($"inferContentType={Uri.EscapeDataString(inferContentType.Value.ToString())}"); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/files/{Uri.EscapeDataString(Uri.EscapeDataString(blob.ToString()))}/content" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1050,10 +1050,10 @@ public virtual async Task GetFileContentAsync([DynamicValues("GetDataSet /// Blob path /// Infer content type /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get blob content using path (V2) response. - public virtual async Task GetFileContentByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetFileContentByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? inferContentType = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileContentByPathAsync"); try @@ -1069,8 +1069,8 @@ public virtual async Task GetFileContentByPathAsync([DynamicValues("GetD queryParams.Add($"inferContentType={Uri.EscapeDataString(inferContentType.Value.ToString())}"); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/GetFileContentByPath" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1091,10 +1091,10 @@ public virtual async Task GetFileContentByPathAsync([DynamicValues("GetD /// Storage account name or blob endpoint /// Blob /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get Blob Metadata (V2) response. - public virtual async Task GetFileMetadataAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetFileMetadataAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blob, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileMetadataAsync"); try @@ -1106,8 +1106,8 @@ public virtual async Task GetFileMetadataAsync([Dy var queryParams = new List(); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/files/{Uri.EscapeDataString(Uri.EscapeDataString(blob.ToString()))}" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1128,10 +1128,10 @@ public virtual async Task GetFileMetadataAsync([Dy /// Storage account name or blob endpoint /// Blob path /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get Blob Metadata using path (V2) response. - public virtual async Task GetFileMetadataByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetFileMetadataByPathAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string blobPath, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.GetFileMetadataByPathAsync"); try @@ -1145,8 +1145,8 @@ public virtual async Task GetFileMetadataByPathAsy queryParams.Add($"path={Uri.EscapeDataString(blobPath.ToString())}"); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/GetFileByPath" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1169,10 +1169,10 @@ public virtual async Task GetFileMetadataByPathAsy /// Paging Marker /// Flat Listing /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Lists blobs (V2) response. - public virtual async Task ListFolderAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string folder, string pagingMarker = default, bool? flatListing = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task ListFolderAsync([DynamicValues("GetDataSets")] string storageAccountNameOrBlobEndpoint, string folder, string pagingMarker = default, bool? flatListing = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = AzureBlobClient.ConnectorActivitySource.StartActivity("AzureBlobClient.ListFolderAsync"); try @@ -1188,8 +1188,8 @@ public virtual async Task ListFolderAsync([Dyn queryParams.Add($"useFlatListing={Uri.EscapeDataString(flatListing.Value.ToString())}"); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(storageAccountNameOrBlobEndpoint.ToString()))}/foldersV2/{Uri.EscapeDataString(Uri.EscapeDataString(folder.ToString()))}" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) diff --git a/src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs b/src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs index ee3530f..e923326 100644 --- a/src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs +++ b/src/Azure.Connectors.Sdk/Generated/SqlExtensions.cs @@ -1379,10 +1379,10 @@ public virtual async Task GetItemAsync([DynamicValues("GetServe /// Select Query /// Count /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get rows (V2) response. - public virtual async Task GetItemsAsync([DynamicValues("GetServers")] string serverName, [DynamicValues("GetDatabases")] string databaseName, [DynamicValues("GetTables_V2")] string tableName, string aggregationTransformation = default, string filterQuery = default, string orderBy = default, int? skipCount = default, int? topCount = default, string selectQuery = default, bool? count = default, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetItemsAsync([DynamicValues("GetServers")] string serverName, [DynamicValues("GetDatabases")] string databaseName, [DynamicValues("GetTables_V2")] string tableName, string aggregationTransformation = default, string filterQuery = default, string orderBy = default, int? skipCount = default, int? topCount = default, string selectQuery = default, bool? count = default, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = SqlClient.ConnectorActivitySource.StartActivity("SqlClient.GetItemsAsync"); try @@ -1410,8 +1410,8 @@ public virtual async Task GetItemsAsync([DynamicValues("GetSer queryParams.Add($"$count={Uri.EscapeDataString(count.Value.ToString())}"); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(serverName.ToString()))},{Uri.EscapeDataString(Uri.EscapeDataString(databaseName.ToString()))}/tables/{Uri.EscapeDataString(Uri.EscapeDataString(tableName.ToString()))}/items" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1432,10 +1432,10 @@ public virtual async Task GetItemsAsync([DynamicValues("GetSer /// Server name /// Database name /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get tables (V2) response. - public virtual async Task GetTablesAsync([DynamicValues("GetServers")] string serverName, [DynamicValues("GetDatabases")] string databaseName, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetTablesAsync([DynamicValues("GetServers")] string serverName, [DynamicValues("GetDatabases")] string databaseName, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = SqlClient.ConnectorActivitySource.StartActivity("SqlClient.GetTablesAsync"); try @@ -1447,8 +1447,8 @@ public virtual async Task GetTablesAsync([DynamicValues("GetS var queryParams = new List(); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(serverName.ToString()))},{Uri.EscapeDataString(Uri.EscapeDataString(databaseName.ToString()))}/tables" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken) @@ -1870,10 +1870,10 @@ public virtual async Task GetTablesForPostItemAsync(string serverNam /// Database name /// Table name /// Extract MIP Labels - /// Purview Acccount Name + /// Purview Account Name /// Cancellation token. /// The Get metadata of a table response. - public virtual async Task GetTableV2Async(string serverName, string databaseName, [DynamicValues("GetTablesForGetItem_V2")] string tableName, bool? extractMIPLabels = default, string purviewAcccountName = default, CancellationToken cancellationToken = default) + public virtual async Task GetTableV2Async(string serverName, string databaseName, [DynamicValues("GetTablesForGetItem_V2")] string tableName, bool? extractMIPLabels = default, string purviewAccountName = default, CancellationToken cancellationToken = default) { using var activity = SqlClient.ConnectorActivitySource.StartActivity("SqlClient.GetTableV2Async"); try @@ -1887,8 +1887,8 @@ public virtual async Task GetTableV2Async(string serverName, stri var queryParams = new List(); if (extractMIPLabels.HasValue) queryParams.Add($"extractSensitivityLabel={Uri.EscapeDataString(extractMIPLabels.Value.ToString())}"); - if (purviewAcccountName != default) - queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAcccountName.ToString())}"); + if (purviewAccountName != default) + queryParams.Add($"purviewAccountName={Uri.EscapeDataString(purviewAccountName.ToString())}"); var path = $"/v2/$metadata.json/datasets/{Uri.EscapeDataString(Uri.EscapeDataString(serverName.ToString()))},{Uri.EscapeDataString(Uri.EscapeDataString(databaseName.ToString()))}/tables/{Uri.EscapeDataString(Uri.EscapeDataString(tableName.ToString()))}" + (queryParams.Count > 0 ? "?" + string.Join("&", queryParams) : ""); return await this .CallConnectorAsync(HttpMethod.Get, path, cancellationToken: cancellationToken)