Skip to content

Peer-to-peer meeting 11/11/2021 #13

Description

@jorgevrgs

According to our last peer-to-peer meeting, I'll share some findings that could implement in your code:

  • Good job with the implemented validation of the form, as you noticed it's better to implement the client-side validations to avoid mistakes with the HTML-validations form.
  • You would try to implement additional aids for accessibility as bordered inputs or icons where the user gets an error, however, you did it great setting the error message near the input.
  • We found an error when you select the .buttons to implement the event listener due to that select all the buttons instead of the project buttons.
  • For the variable and functions according to the recommended practices it's required to use camelCase.
  • To avoid complications with text concatenation using 'text' + variable you could try using text ${variable}.

Thank you very much!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions