Skip to content

Issues from peer-to-peer review Morning session #10

Description

@joseheco

#Great job so far implementing the desktop version of your portfolio website. Your design and code look clean and match the template very well! ⭐ 🚀 🪐 According to our morning session, the team suggests the following ♻️changes ♻️:

1️⃣

  • The main HTML5 tag is used to define the main or most prominent content of the DOM, this helps the positioning of your web page.

2️⃣

  • Add this code so that it does not make any decoration when the mobile version is clicked

a,
a:hover,
a:focus,
a:active {
text-decoration: none;
}

  • Change the background image in the mobile version that is in the bottom part of the footer

3️⃣

  • the image background in the mobile version is different from figma.
    the image background is covering the nav tag

  • In the figma mobile version it does not appear to have a margin on the sides, you can fix that to dont have any margin.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions