From ea5fac21427cf8615576e32878d6a7fb91880bce Mon Sep 17 00:00:00 2001 From: dajiaohuang Date: Sat, 14 Nov 2026 14:07:54 +0800 Subject: [PATCH 1/4] Preserve workflow edits when saves fail --- .../components/workflows/WorkflowsPanel.tsx | 93 ++++++++++++++++--- 1 file changed, 80 insertions(+), 13 deletions(-) diff --git a/frontend/components/workflows/WorkflowsPanel.tsx b/frontend/components/workflows/WorkflowsPanel.tsx index ff99906c..920bc300 100644 --- a/frontend/components/workflows/WorkflowsPanel.tsx +++ b/frontend/components/workflows/WorkflowsPanel.tsx @@ -1,6 +1,6 @@ "use client"; -import { useCallback, useEffect, useState } from "react"; +import { useCallback, useEffect, useRef, useState } from "react"; import { api, type Agent, @@ -17,6 +17,19 @@ interface WorkflowsPanelProps { onClose: () => void; } +interface WorkflowSave { + draft: Workflow; + pending: Partial | null; + saving: boolean; + error: string | null; +} + +const queuedChanges = (save: WorkflowSave) => save.pending; +const applyWorkflowEdit = (save: WorkflowSave, partial: Partial) => { + save.draft = { ...save.draft, ...partial }; + save.pending = { ...save.pending, ...partial }; +}; + const DEFAULT_WORKFLOW_STEPS: WorkflowStep[] = [ { id: "trigger_1", @@ -102,6 +115,17 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel const [runs, setRuns] = useState([]); const [loading, setLoading] = useState(true); const [error, setError] = useState(null); + const [saveErrors, setSaveErrors] = useState>({}); + const saves = useRef>({}); + + useEffect(() => { + const warnBeforeLeave = (event: BeforeUnloadEvent) => { + if (Object.keys(saves.current).length === 0) return; + event.preventDefault(); + }; + window.addEventListener("beforeunload", warnBeforeLeave); + return () => window.removeEventListener("beforeunload", warnBeforeLeave); + }, []); const loadData = useCallback(async () => { try { @@ -121,7 +145,7 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel setWorkflows([initial]); setSelectedWorkflowId(initial.id); } else { - setWorkflows(wfs); + setWorkflows(wfs.map((workflow) => saves.current[workflow.id]?.draft ?? workflow)); setSelectedWorkflowId((prev) => (prev !== null ? prev : wfs[0].id)); } setRuns(rList); @@ -189,18 +213,52 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel } }; + const flushWorkflow = async (id: number) => { + const save = saves.current[id]; + if (!save || save.saving || save.error || !save.pending) return; + save.saving = true; + while (save.pending) { + const pending = save.pending; + save.pending = null; + try { + const updated = await api.updateWorkflow(id, pending); + save.draft = { ...updated, ...queuedChanges(save) }; + const draft = save.draft; + setWorkflows((prev) => prev?.map((workflow) => workflow.id === id ? draft : workflow) ?? prev); + } catch (err) { + save.pending = { ...pending, ...queuedChanges(save) }; + save.error = err instanceof Error ? err.message : String(err); + setSaveErrors((old) => ({ ...old, [id]: save.error! })); + break; + } + } + save.saving = false; + if (!save.pending && !save.error) delete saves.current[id]; + }; + const handleUpdateWorkflow = async (partial: Partial) => { if (!activeWorkflow) return; - try { - const updated = await api.updateWorkflow(activeWorkflow.id, partial); - setWorkflows((prev) => - prev ? prev.map((w) => (w.id === updated.id ? updated : w)) : [updated] - ); - } catch (err) { - console.error("Failed to update workflow:", err); - } + const id = activeWorkflow.id; + const save = saves.current[id] ?? { draft: activeWorkflow, pending: null, saving: false, error: null }; + applyWorkflowEdit(save, partial); + saves.current[id] = save; + const draft = save.draft; + setWorkflows((prev) => prev?.map((workflow) => workflow.id === id ? draft : workflow) ?? prev); + await flushWorkflow(id); }; + const retryWorkflow = (id: number) => { + const save = saves.current[id]; + if (!save) return; + save.error = null; + setSaveErrors((old) => { const next = { ...old }; delete next[id]; return next; }); + void flushWorkflow(id); + }; + + const refreshRuns = useCallback(async () => { + setRuns(await api.listAllWorkflowRuns(50)); + }, []); + const handleRunWorkflow = async () => { if (!activeWorkflow) return; try { @@ -246,6 +304,11 @@ export function WorkflowsPanel({ agents, engines = [], onClose }: WorkflowsPanel if (!activeWorkflow) return null; return ( + <> + {Object.entries(saveErrors).map(([id, message]) =>
+ Workflow changes were not saved: {message}. Your edits are still here. + +
)} { + if (Object.keys(saves.current).length && !window.confirm("Some workflow changes have not been saved. Close anyway?")) return; + onClose(); + }} + onRefreshRuns={refreshRuns} /> + ); -} \ No newline at end of file +} From 6bc86756e25a5a77912fb529400e282c916bd33a Mon Sep 17 00:00:00 2001 From: dajiaohuang Date: Sat, 14 Nov 2026 14:11:34 +0800 Subject: [PATCH 2/4] Wait for workflow edits before running --- frontend/components/workflows/WorkflowCanvas.tsx | 13 ++++++++++--- frontend/components/workflows/WorkflowsPanel.tsx | 10 +++++++++- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/frontend/components/workflows/WorkflowCanvas.tsx b/frontend/components/workflows/WorkflowCanvas.tsx index 1346a1c3..c9a5c5fa 100644 --- a/frontend/components/workflows/WorkflowCanvas.tsx +++ b/frontend/components/workflows/WorkflowCanvas.tsx @@ -73,6 +73,8 @@ export interface WorkflowCanvasProps { onCreateWorkflow: () => void; onUpdateWorkflow: (updated: Partial) => Promise; onRunWorkflow: () => Promise; + workflowUnsaved: boolean; + canRunWorkflow: () => boolean; onClose: () => void; onRefreshRuns: () => Promise; } @@ -664,6 +666,8 @@ export function WorkflowCanvas({ onCreateWorkflow, onUpdateWorkflow, onRunWorkflow, + workflowUnsaved, + canRunWorkflow, onClose, onRefreshRuns, }: WorkflowCanvasProps) { @@ -2172,6 +2176,7 @@ export function WorkflowCanvas({ // Execute workflow live across canvas const handleTriggerFullRun = async () => { + if (!canRunWorkflow()) return; try { setIsExecutingWorkflow(true); await onRunWorkflow(); @@ -2191,6 +2196,7 @@ export function WorkflowCanvas({ // Run isolated step const handleRunStep = async (stepId: string) => { + if (!canRunWorkflow()) return; try { setRunningStepId(stepId); const res = await api.runWorkflowStep(workflow.id, stepId, { @@ -2361,7 +2367,8 @@ export function WorkflowCanvas({ )} setSelectedWorkflowId(id)} onCreateWorkflow={handleCreateWorkflow} onUpdateWorkflow={handleUpdateWorkflow} - onRunWorkflow={handleRunWorkflow} workflowUnsaved={Boolean(unsavedWorkflows[activeWorkflow.id])} canRunWorkflow={() => !saves.current[activeWorkflow.id]} onClose={() => {