Running browser paves .vlab/tmp

[gilgamec]

When you run browser, the temporary directory .vlab/tmp is erased. This is a problem if you currently have objects checked out (say, from another browser). I know that you can start a new browser from browser itself (and that doesn't nuke the tmp directory), but this is not helpful if browser crashes or you close it with an object still open.

We've been bit by this a few times recently, losing work every time.

I've confirmed it happens on Linux and OSX.

[mikcieslak]

Thanks for posting about this. I've lost some work in the past as well.

I've pushed a change that prompts the user if the .vlab/tmp folder is not empty. It gives the option of keeping or discarding the folder. Browser won't prompt you again if you start a new browser from browser itself, but it will if you start another browser from the terminal (even if a browser is already open).

[gilgamec]

I guess I haven't had to open a new browser since this was fixed ... but under Linux, the prompt window to ask if I want to overwrite the tmp directory has the buttons "Show Details", "Save", "Cancel", and ... "Quit Without Saving", which as you can imagine is not especially edifying. ('Cancel' quits; so what does 'Quit Without Saving' do??) I assume under Mac the 'Discard' button has a more appropriate label?

Anyway, I fixed this by changing the button text after it's created:

  msgBox.setStandardButtons(QMessageBox::Save | QMessageBox::Discard | QMessageBox::Cancel);
  msgBox.setDefaultButton(QMessageBox::Save);
  msgBox.button(QMessageBox::Discard)->setText("Discard");

You may want to guard this to only run under Linux, if the MacOS version of the button has a better label.

[mikcieslak]

Thanks for the fix! The macOS version doesn't have a better label. It uses "Don't Save". I included your fix for both systems.