Two or more mod characters(without spine nodes) die together will cause the game unresponding.

[JerryCatJim]

My mod character .tscn has no spine nodes and use one animtree(blend) and one animplayer to play anims.
If the online game room has two or more mod characters, and two or more of them die together in combat or after architect winning die together, the game will be unresponding without any error logs in log file.
Baselib 3.1.0 to 3.1.3 are all the same of this issue, I didn't test earlier versions, my friends using baselib and spine nodes don't have this issue, and some who don't have spine nodes share the same problem with me.
So I wonder if it is baselib's problem or my code problem.

[Alchyr]

Without an error getting logged hard to say for sure, added a change to animation stuff but the thing that fixes should result in an error
leaving open for now

[Hanatoke]

Based on my analysis, it seems that this line is causing the thread deadlock.
↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓
static async Task WaitCustomAnim(NCreature __instance)
{
if (CustomAnimation.PlayCustomAnimation(__instance.Visuals, CreatureAnimator.deathTrigger, "die"))
{
if (__instance.Entity.Player?.Character is CustomCharacterModel character)
{
await Cmd.Wait(character.DeathAnimTime);
}
}
}
↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑
I don’t know how to solve this issue either; I just worked around it by manually adding my NCreatureVisual to the whitelist.

[Hanatoke]

Based on my analysis, it seems that this line is causing the thread deadlock. ↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓ static async Task WaitCustomAnim(NCreature __instance) { if (CustomAnimation.PlayCustomAnimation(__instance.Visuals, CreatureAnimator.deathTrigger, "die")) { if (__instance.Entity.Player?.Character is CustomCharacterModel character) { await Cmd.Wait(character.DeathAnimTime); } } } ↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑ I don’t know how to solve this issue either; I just worked around it by manually adding my NCreatureVisual to the whitelist.

According to the latest test, setting the duration of the death animation to 0 will not trigger this bug, so it can be confirmed that there is an issue with Cmd.Wait