Skip to content

ci: gated golden suite never runs — BURN_GOLDEN unset in every workflow #525

Description

@willwashburn

Problem

crates/relayburn-cli/tests/golden.rs short-circuits unless BURN_GOLDEN=1 (golden.rs:84). No workflow sets it: ci.yml:84 and publish.yml:317 run plain cargo test --workspace, and BURN_GOLDEN appears nowhere in .github/. The golden suite therefore never executes in CI.

Consequence: #510 merged to main with the golden summary/summary-json cases red (see #524) and no check caught it.

Fix

Run the golden suite in CI — either set BURN_GOLDEN=1 on the cargo-test job (with whatever fixture bootstrap it needs) or invert the gate to opt-out. Companion to #521, which covers the same green-while-skipping pattern for the Node SDK conformance tests.

Found during retroactive adversarial review of PR #511's merge delta.

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions