Preserve both retry and hook configuration

[grantfox-oss]

Summary

Fix client configuration so retry and hooks can be used together. This matters because production users may want retries and observability lifecycle hooks at the same time.

Current Behaviour

GuildPassClient passes this.config.retry || this.config.hooks into HttpClient. Because HttpClient accepts a single configOrHooks argument, only one of these behaviours can be configured at a time.

Expected Behaviour

The SDK should allow global retry configuration and HTTP lifecycle hooks to be enabled together without one silently overriding the other.

Suggested Implementation

Replace the overloaded configOrHooks constructor parameter with a single options object such as { retry, hooks, fetch } or separate explicit constructor parameters. Update GuildPassClient and tests accordingly.

Files or Areas Likely Affected

• src/client/GuildPassClient.ts
• src/http/httpClient.ts
• src/http/http.types.ts
• src/config/sdkConfig.ts
• tests/client.test.ts
• tests/httpClient.test.ts

Acceptance Criteria

• A client can be configured with both retry and hooks
• Retry behaviour still works when hooks are present
• Hook callbacks still run when retry config is present
• Existing client configuration remains backwards-compatible where possible
• Tests cover retry-only, hooks-only, and retry-plus-hooks configurations

Additional Notes

This is a public constructor design change. Prefer a backwards-compatible migration path if possible.

[Ajibose]

I'd like to take this on. The real bug isn't that HttpClient can't accept both, its constructor already discriminates RetryConfig from HttpHooks. It's that GuildPassClient does this.config.retry || this.config.hooks, dropping hooks before the constructor sees it.

My fix: change the 4th param to { retry?, hooks? }, keep the old signature via an overload for compatibility, and pass both from GuildPassClient. Tests covering retry-only, hooks-only, and retry+hooks. (Side note: the suggested fetch option has no injection point in the current client, so I'd leave it out unless wanted.)
Background: TypeScript and Go, with OSS contributions across NestJS/Prisma and Go HTTP services.

[naninu123]

Hi, I'd like to work on this.

I have experience across Rust/Soroban, TypeScript, and CI/CD in the Stellar ecosystem — active GrantFox contributor with merged PRs (Core-Foundry/Notify-Chain #51, Flux-DeFi/LiquidFlow #114, StellarLend/stellarlend-contracts #998).

I'll follow the repo's existing patterns and submit a focused, clean PR. I can start immediately.

Looking forward!

[gaiabio12-design]

Hi! I'd like to work on this issue. 🔐

I specialize in TypeScript/JavaScript security tooling and can deliver a PR within 96 hours.

Could you confirm this is available? I'll begin as soon as I hear back. Thanks!