mar + Katie - Ada Cooks#24
Open
camarleigh wants to merge 100 commits into
Open
Conversation
…s and associations.
added controllers and models for most of the project. Also validation…
…ks into mar+kja/master merging
User/kja
…ks into user/kja merging
carrierwave setup. initial cookbook and ingredient actions.
ing views for show, edit, new, and index.
User/kja
ingredient and recipe seeds.
…ks into recipe/kja merging
Recipe/kja
…ing route to config.
Recipe/kja
…m search query. Also inital styling in application file for search box in nav bar.
Recipe/kja
search working.
cookbook unique query. not working.
…ks into recipe/kja merging
…r search on home page
Recipe/kja
unique ingredients per cookbook finally working.
project complete - user controller specs written. over 80% coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're technically finished so doing a PR now. Will style and do more rspecs over the weekend, but we've completed all assigned parts of Ada Cooks.
Some refactoring could be done in ingredient and recipe create methods as well as add'l partial opportunities. We will revisit as time allows.
Looking forward to your feedback!
katie and marleigh