Skip to content

Final PR - Wang & Walentin#21

Open
brittinator wants to merge 171 commits into
Ada-Developers-Academy:blw+lw/masterfrom
brittinator:blw+lw/master
Open

Final PR - Wang & Walentin#21
brittinator wants to merge 171 commits into
Ada-Developers-Academy:blw+lw/masterfrom
brittinator:blw+lw/master

Conversation

@brittinator
Copy link
Copy Markdown
Contributor

@wangg131

NOT deployed to heroku.

  • We like that there's a before_filter (require_login) on certain pages so people shouldn't be able to access things that are restricted (not their own).
  • We made the decision early on to work on parts of the project where we were not as comfortable with or what was new. Because of this, our pace may have been slower than optimal but our understanding is better. Also, we didn't really get time to style much.
  • We feel like there was no time for refactoring, but it would be nice to get pointers as where to start. There may be methods in the controller that can go in the model and visa versa.
  • Seeds were particularly fickle, but we're pleased with 'em.
  • In the recipe controller, the create action could use some refactoring. The way it's written helps to render the form properly when the user gives submits bad input (left out a required field). Any guidance is helpful
  • Likely that we aren't using all of our enabled routes.
  • Go Double Dubs! ~ W&W

acmei added a commit that referenced this pull request Jan 12, 2016
sallyamoore added a commit that referenced this pull request Feb 9, 2016
catchingash pushed a commit that referenced this pull request Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants