Carly and Elsa AdaCooks#19
Open
carjug wants to merge 192 commits into
Open
Conversation
Put initial data model in readme for reference.
…and ingredient migration files to have a user_id foreign key.
Models gen/caj+edm
…ds code to test.rb in environments so coverage report is generated with each test.
Rspec models/caj
Recipe model tests/edm
Views setup/caj+edm
Rspec tests/edm
Debuggers/caj
…ks into debuggers/caj
Debuggers/caj
…ks into debuggers/caj
Debuggers/caj
Style edits.
…ks into debuggers/caj
…ks into styling/edm
Styling/edm
Debuggers/caj
acmei
added a commit
that referenced
this pull request
Jan 12, 2016
sallyamoore
pushed a commit
that referenced
this pull request
Feb 9, 2016
Added recipes to ingredients#index.
catchingash
added a commit
that referenced
this pull request
Feb 25, 2016
More Cookbook Controller Specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is our completed AdaCooks project.
We met all of the requirements in the readme. We have 99% test coverage. However, we did not spend any time refactoring (pretty much at all). We could definitely create some partials, scopes, etc. Our main focus was to get things working, then refactor. So we just did the former and ran out of time :)
We tried to be conscious of "feature creep", so we didn't try to make anything too fancy, but all the functionality is there. Yay!
Super into the styling!
<3
CAJ + EDM