From 9dbe74ffe47a80484590c917e64d58cc00692097 Mon Sep 17 00:00:00 2001 From: Shivika Date: Thu, 12 Nov 2026 13:16:14 +0530 Subject: [PATCH 1/2] fix: validate personal access token before saving in PAT modal Test token validity against GitHub rate_limit endpoint before persisting to local storage, preventing 401 request failures from invalid or expired tokens. Fixes #416 --- src/components/PATModal.jsx | 89 +++++++++++++--- src/components/PATModal.test.jsx | 131 ++++++++++++++++++++++++ src/services/github.js | 29 ++++++ src/services/github.validatePat.test.js | 74 +++++++++++++ src/test/setup.js | 8 ++ 5 files changed, 319 insertions(+), 12 deletions(-) create mode 100644 src/components/PATModal.test.jsx create mode 100644 src/services/github.validatePat.test.js diff --git a/src/components/PATModal.jsx b/src/components/PATModal.jsx index 2168bc97..293f0ad5 100644 --- a/src/components/PATModal.jsx +++ b/src/components/PATModal.jsx @@ -1,17 +1,22 @@ import React, { useState, useEffect } from "react"; -import { FiEye, FiEyeOff, FiSave, FiTrash2, FiX } from "react-icons/fi"; +import { FiEye, FiEyeOff, FiSave, FiTrash2, FiX, FiAlertTriangle, FiLoader } from "react-icons/fi"; import { useApp } from "../context/AppContext"; +import { validatePat } from "../services/github"; export default function PATModal({ open, onClose }) { const { pat, savePat } = useApp(); const [draft, setDraft] = useState(pat); const [show, setShow] = useState(false); - const isSaved = Boolean(pat && draft.trim() === pat) + const [validating, setValidating] = useState(false); + const [error, setError] = useState(""); + const isSaved = Boolean(pat && draft.trim() === pat); useEffect(() => { if (open) { setDraft(pat); + setError(""); + setValidating(false); } }, [open, pat]); @@ -42,13 +47,32 @@ export default function PATModal({ open, onClose }) { if (!open) return null; - const handleSave = () => { - savePat(draft.trim()); + // Validate token with GitHub API before persisting to storage + const handleSave = async () => { + const trimmed = draft.trim(); + if (!trimmed || validating) return; + + if (isSaved) return; + + setValidating(true); + setError(""); + + const res = await validatePat(trimmed); + + if (!res.valid) { + setError(res.error || "Invalid token"); + setValidating(false); + return; + } + + await savePat(trimmed); + setValidating(false); }; const handleDelete = () => { savePat(""); setDraft(""); + setError(""); }; return ( @@ -159,20 +183,29 @@ export default function PATModal({ open, onClose }) { style={{ display: "flex", gap: 8, - marginBottom: 16, + marginBottom: error ? 10 : 16, }} > setDraft(e.target.value)} + onChange={(e) => { + setDraft(e.target.value); + if (error) setError(""); + }} + onKeyDown={(e) => { + if (e.key === "Enter" && !validating && draft.trim()) { + handleSave(); + } + }} + disabled={validating} placeholder="ghp_xxxxxxxxxxxxxxxxx" style={{ flex: 1, padding: "10px 12px", background: "var(--surface2)", color: "var(--text)", - border: "1px solid var(--border)", + border: error ? "1px solid var(--red)" : "1px solid var(--border)", borderRadius: 8, }} /> @@ -180,19 +213,41 @@ export default function PATModal({ open, onClose }) { + {error && ( +
+ + {error} +
+ )} +
- - {isSaved ? "Saved" : "Save"} + {validating ? ( + <> + + Verifying... + + ) : ( + <> + + {isSaved ? "Saved" : "Save"} + + )}