From a8d9df23bcfccb71694e34b531d503736e3deb44 Mon Sep 17 00:00:00 2001 From: Smriti-N Date: Wed, 28 Oct 2026 03:16:26 +0530 Subject: [PATCH 1/2] fix: prioritize older items in governance audit --- src/context/AppContext.jsx | 6 ++-- src/services/github.governance.test.js | 42 ++++++++++++++++++++++++++ src/services/github.js | 19 ++++++++++++ 3 files changed, 64 insertions(+), 3 deletions(-) create mode 100644 src/services/github.governance.test.js diff --git a/src/context/AppContext.jsx b/src/context/AppContext.jsx index 9ee03908..21b7e6f1 100644 --- a/src/context/AppContext.jsx +++ b/src/context/AppContext.jsx @@ -1,5 +1,5 @@ import { createContext, useContext, useState, useCallback, useEffect, useMemo, useRef } from 'react' -import { fetchOrg, fetchRepos, fetchContributors, fetchIssues, fetchRateLimit, fetchPulls } from '../services/github' +import { fetchOrg, fetchRepos, fetchContributors, fetchIssues, fetchGovernanceIssues , fetchRateLimit, fetchPulls } from '../services/github' import { buildAnalyticalModel, getTopRepositories } from '../services/analytics' import { saveAnalysis, loadAnalysis } from '../services/cache' @@ -291,10 +291,10 @@ export function AppProvider({ children }) { for (let i = 0; i < repos.length; i += 5) { const batch = repos.slice(i, i + 5) await Promise.allSettled(batch.map(async repo => { - map[`${repo.orgLogin}/${repo.name}`] = await fetchIssues(repo.orgLogin, repo.name, pat) + map[`${repo.orgLogin}/${repo.name}`] = await fetchGovernanceIssues(repo.orgLogin, repo.name, pat) })) } - return map + return maps }, [pat, selectAnalysisRepos]) // Governance audit : used directly when repos are already complete diff --git a/src/services/github.governance.test.js b/src/services/github.governance.test.js new file mode 100644 index 00000000..ddccdc68 --- /dev/null +++ b/src/services/github.governance.test.js @@ -0,0 +1,42 @@ + +import { afterEach, describe, expect, it, vi } from 'vitest' +import { fetchGovernanceIssues } from './github' + +describe('fetchGovernanceIssues', () => { + afterEach(() => { + vi.restoreAllMocks() + }) + + it('requests open issues oldest-first', async () => { + const fetchSpy = vi.spyOn(globalThis, 'fetch').mockResolvedValue({ + ok: true, + status: 200, + headers: new Headers({ 'content-type': 'application/json' }), + json: async () => [{ number: 1, title: 'Old issue' }], + }) + + await fetchGovernanceIssues('example-org', 'example-repo', null) + + expect(fetchSpy).toHaveBeenCalledTimes(1) + + const requestedUrl = String(fetchSpy.mock.calls[0][0]) + expect(requestedUrl).toContain('state=open') + expect(requestedUrl).toContain('sort=created') + expect(requestedUrl).toContain('direction=asc') + expect(requestedUrl).toContain('per_page=100') + expect(requestedUrl).toContain('page=1') + }) + + it('stops fetching when a page has fewer than 100 items', async () => { + const fetchSpy = vi.spyOn(globalThis, 'fetch').mockResolvedValue({ + ok: true, + status: 200, + headers: new Headers({ 'content-type': 'application/json' }), + json: async () => [{ number: 1, title: 'Old issue' }], + }) + + await fetchGovernanceIssues('example-org', 'example-repo', null) + + expect(fetchSpy).toHaveBeenCalledTimes(1) + }) +}) diff --git a/src/services/github.js b/src/services/github.js index 65964b47..a4f7439f 100644 --- a/src/services/github.js +++ b/src/services/github.js @@ -180,6 +180,25 @@ export async function fetchIssues(org, repo, pat) { return all } + +export async function fetchGovernanceIssues(org, repo, pat) { + const all = [] + const maxPages = pat ? 10 : 1 + + for (let page = 1; page <= maxPages; page++) { + const url = + `https://api.github.com/repos/${org}/${repo}/issues?state=open&sort=created&direction=asc&per_page=100&page=${page}` + + const data = await fetchWithCache(url, pat) + all.push(...data) + + if (data.length < 100) break + } + + return all +} + + export async function fetchPulls(org, repo, pat) { const all = [] const maxPages = pat ? 10 : 1 From 4cbaefe38765d48554f3d3790221f025007ea50c Mon Sep 17 00:00:00 2001 From: Smriti-N Date: Wed, 28 Oct 2026 04:03:13 +0530 Subject: [PATCH 2/2] fix: separate governance issue fetching --- src/context/AppContext.explore.test.jsx | 1 + src/context/AppContext.jsx | 25 +++++++++++++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/context/AppContext.explore.test.jsx b/src/context/AppContext.explore.test.jsx index dd23cdf9..b5ed4964 100644 --- a/src/context/AppContext.explore.test.jsx +++ b/src/context/AppContext.explore.test.jsx @@ -14,6 +14,7 @@ vi.mock('../services/github', () => ({ fetchRepos: vi.fn(), fetchContributors: vi.fn(), fetchIssues: vi.fn(), + fetchGovernanceIssues: vi.fn(), fetchRateLimit: vi.fn(), fetchPulls: vi.fn(), })) diff --git a/src/context/AppContext.jsx b/src/context/AppContext.jsx index 21b7e6f1..a9e2ce2a 100644 --- a/src/context/AppContext.jsx +++ b/src/context/AppContext.jsx @@ -291,17 +291,34 @@ export function AppProvider({ children }) { for (let i = 0; i < repos.length; i += 5) { const batch = repos.slice(i, i + 5) await Promise.allSettled(batch.map(async repo => { - map[`${repo.orgLogin}/${repo.name}`] = await fetchGovernanceIssues(repo.orgLogin, repo.name, pat) + map[`${repo.orgLogin}/${repo.name}`] = await fetchIssues(repo.orgLogin, repo.name, pat) })) } - return maps + return map }, [pat, selectAnalysisRepos]) + const fetchGovernanceRepos = useCallback(async (allRepos) => { + const repos = selectAnalysisRepos(allRepos) + + const map = {} + for (let i = 0; i < repos.length; i += 5) { + const batch = repos.slice(i, i + 5) + await Promise.allSettled(batch.map(async repo => { + map[`${repo.orgLogin}/${repo.name}`] = await fetchGovernanceIssues( + repo.orgLogin, + repo.name, + pat + ) + })) + } + return map +}, [pat, selectAnalysisRepos]) + // Governance audit : used directly when repos are already complete const runAudit = useCallback(async () => { if (!model || govLoading) return setGovLoading(true) - const map = await auditRepos(model.allRepos) + const map = await fetchGovernanceRepos(model.allRepos) setIssuesData(map) setGovLoading(false) setAuditComplete(!!pat) @@ -327,7 +344,7 @@ export function AppProvider({ children }) { if (!currentModel) return setGovLoading(true) - const map = await auditRepos(currentModel.allRepos) + const map = await fetchGovernanceRepos(currentModel.allRepos) setIssuesData(map) setGovLoading(false) setAuditComplete(!!pat)