From 0c020e8a4883b46870ce923a032413d62696b3cf Mon Sep 17 00:00:00 2001 From: Aman shrivastab Date: Sun, 13 Sep 2026 02:53:41 +0530 Subject: [PATCH 1/2] Add integration readiness status indicators (#4) - Add GET /api/settings/status endpoint (booleans only, no secrets exposed) - Add dashboard Integration Readiness card with configured/not-configured badges - Link missing integrations to their settings tab - Add defensive error handling in aiService.js for invalid settings.json - Add tests/integration-status.test.js --- data/settings.json | 6 +++--- package-lock.json | 3 --- package.json | 2 +- public/index.html | 4 ++++ public/js/app.js | 36 ++++++++++++++++++++++++++++++++ routes/settings.js | 30 +++++++++++++++++++++++++- services/aiService.js | 11 +++++----- tests/integration-status.test.js | 22 +++++++++++++++++++ 8 files changed, 101 insertions(+), 13 deletions(-) create mode 100644 tests/integration-status.test.js diff --git a/data/settings.json b/data/settings.json index 42a07aa..c653770 100644 --- a/data/settings.json +++ b/data/settings.json @@ -5,11 +5,11 @@ "webshareApiKey": "" }, "smtp": { - "host": "", + "host": "smtp.gmail.com", "port": 465, "secure": false, - "user": "", - "pass": "", + "user": "test@gmail.com", + "pass": "test123", "enabled": true }, "twilio": { diff --git a/package-lock.json b/package-lock.json index 0c14cdb..b18639c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,9 +26,6 @@ "ws": "^8.14.2", "xlsx": "^0.18.5" }, - "bin": { - "data-extractor-pro": "server.js" - }, "engines": { "node": ">=18.0.0" } diff --git a/package.json b/package.json index ebeebe2..1e51c34 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "start": "node server.js", "dev": "node server.js", "deploy": "npm install && npm start", - "test": "node --test tests/frontend-integrity.test.js tests/browser-executable.test.js", + "test": "node --test tests/frontend-integrity.test.js tests/browser-executable.test.js tests/integration-status.test.js", "capture:readme": "node scripts/capture-readme-screenshot.js" }, "keywords": [ diff --git a/public/index.html b/public/index.html index daddbcf..74e808e 100644 --- a/public/index.html +++ b/public/index.html @@ -98,6 +98,10 @@
+
+

Integration Readiness

+
+
diff --git a/public/js/app.js b/public/js/app.js index a408c3f..47e194c 100644 --- a/public/js/app.js +++ b/public/js/app.js @@ -140,6 +140,42 @@ async function exportTrafficLogs() { showToast('Failed to export logs', 'error'); } } +const INTEGRATION_LABELS = { + proxy: 'Proxy (Webshare)', + smtp: 'Email (SMTP)', + twilio: 'SMS (Twilio)', + zerobounce: 'Email Verification (ZeroBounce)', + ai: 'AI (OpenAI/Gemini)' +}; + +async function loadIntegrationStatus() { + try { + const res = await fetch('/api/settings/status'); + const status = await res.json(); + const container = document.getElementById('integrationStatusList'); + container.innerHTML = Object.entries(status).map(([key, val]) => ` +
+ ${val.configured ? '✅' : '⚠️'} ${INTEGRATION_LABELS[key] || key} + ${!val.configured ? `Configure` : ''} +
+ `).join(''); + } catch (e) { + console.error('Failed to load integration status', e); + } +} +function goToSettingsTab(tab) { + const settingsNavLink = document.querySelector('.nav-item[data-page="settings"]'); + if (settingsNavLink) settingsNavLink.click(); + + // tab switch thoda delay ke baad, taaki settings page pehle render ho jaaye + setTimeout(() => { + const btn = document.querySelector(`.tab-btn[onclick*="switchSettingsTab('${tab}'"]`); + if (btn) switchSettingsTab(tab, btn); + }, 50); +} + +// call on dashboard load +loadIntegrationStatus(); function appendLog(consoleDiv, message) { const div = document.createElement('div'); diff --git a/routes/settings.js b/routes/settings.js index d57dbbf..35aa3ea 100644 --- a/routes/settings.js +++ b/routes/settings.js @@ -68,6 +68,35 @@ router.get('/', (req, res) => { if (masked.ai?.apiKey) masked.ai.apiKey = masked.ai.apiKey.substring(0, 8) + '...'; res.json(masked); }); +// GET /api/settings/status — readiness check, NEVER returns secret values +router.get('/status', (req, res) => { + const settings = loadSettings(); + + const status = { + proxy: { + configured: Boolean(settings.proxy?.webshareApiKey), + settingsTab: 'proxy' + }, + smtp: { + configured: Boolean(settings.smtp?.host && settings.smtp?.user && settings.smtp?.pass), + settingsTab: 'smtp' + }, + twilio: { + configured: Boolean(settings.twilio?.accountSid && settings.twilio?.authToken && settings.twilio?.fromNumber), + settingsTab: 'twilio' + }, + zerobounce: { + configured: Boolean(settings.apiKeys?.zerobounce), + settingsTab: 'apikeys' + }, + ai: { + configured: Boolean(settings.ai?.apiKey), + settingsTab: 'apikeys' + } + }; + + res.json(status); +}); // GET raw settings (for internal use) router.get('/raw', (req, res) => { @@ -264,5 +293,4 @@ router.post('/fetch-webshare-proxies', async (req, res) => { res.json({ success: false, message: error.message }); } }); - module.exports = router; diff --git a/services/aiService.js b/services/aiService.js index 747a449..48e4caf 100644 --- a/services/aiService.js +++ b/services/aiService.js @@ -11,16 +11,17 @@ class AIService { this.initClient(); } - loadConfig() { + loadConfig() { + try { if (fs.existsSync(SETTINGS_FILE)) { const allSettings = JSON.parse(fs.readFileSync(SETTINGS_FILE, 'utf8')); return allSettings.ai || { provider: 'gemini', apiKey: '' }; } - return { - provider: 'gemini', - apiKey: '' - }; + } catch (e) { + console.error('Error loading AI config, using defaults:', e.message); } + return { provider: 'gemini', apiKey: '' }; +} saveConfig(newConfig) { let allSettings = {}; diff --git a/tests/integration-status.test.js b/tests/integration-status.test.js new file mode 100644 index 0000000..bc18bdd --- /dev/null +++ b/tests/integration-status.test.js @@ -0,0 +1,22 @@ +// tests/integration-status.test.js +const fs = require('node:fs'); +const path = require('node:path'); +const test = require('node:test'); +const assert = require('node:assert/strict'); + +const root = path.join(__dirname, '..'); + +test('settings status route never returns raw secret values', () => { + const source = fs.readFileSync(path.join(root, 'routes', 'settings.js'), 'utf8'); + const statusRoute = source.match(/router\.get\('\/status'[\s\S]*?\}\);/)[0]; + // status block should only build booleans, never echo settings.smtp.pass / authToken / apiKey directly + assert.doesNotMatch(statusRoute, /res\.json\(settings\)/); + assert.match(statusRoute, /configured:\s*Boolean\(/); +}); + +test('dashboard has an integration status container with a render function', () => { + const html = fs.readFileSync(path.join(root, 'public', 'index.html'), 'utf8'); + const app = fs.readFileSync(path.join(root, 'public', 'js', 'app.js'), 'utf8'); + assert.match(html, /id="integrationStatusList"/); + assert.match(app, /async\s+function\s+loadIntegrationStatus\s*\(/); +}); \ No newline at end of file From 83f9a73711af85bf0ad9eeb328dd23ccec48a4bb Mon Sep 17 00:00:00 2001 From: Aman shrivastab Date: Mon, 14 Sep 2026 02:18:03 +0530 Subject: [PATCH 2/2] Fix review feedback: revert settings.json, move readiness card into dashboard, fix AI configure link, add CSS, add functional tests --- data/settings.json | 6 +- package-lock.json | 3 + package.json | 4 +- public/css/style.css | 41 ++++++++++++ public/index.html | 44 +++++++++++-- public/js/app.js | 17 ++++- routes/settings.js | 2 +- services/aiService.js | 11 ++-- tests/configure-buttons.test.js | 84 ++++++++++++++++++++++++ tests/settings-status-functional.test.js | 66 +++++++++++++++++++ 10 files changed, 259 insertions(+), 19 deletions(-) create mode 100644 tests/configure-buttons.test.js create mode 100644 tests/settings-status-functional.test.js diff --git a/data/settings.json b/data/settings.json index c653770..42a07aa 100644 --- a/data/settings.json +++ b/data/settings.json @@ -5,11 +5,11 @@ "webshareApiKey": "" }, "smtp": { - "host": "smtp.gmail.com", + "host": "", "port": 465, "secure": false, - "user": "test@gmail.com", - "pass": "test123", + "user": "", + "pass": "", "enabled": true }, "twilio": { diff --git a/package-lock.json b/package-lock.json index b18639c..0c14cdb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,6 +26,9 @@ "ws": "^8.14.2", "xlsx": "^0.18.5" }, + "bin": { + "data-extractor-pro": "server.js" + }, "engines": { "node": ">=18.0.0" } diff --git a/package.json b/package.json index 1e51c34..4030776 100644 --- a/package.json +++ b/package.json @@ -7,9 +7,9 @@ "start": "node server.js", "dev": "node server.js", "deploy": "npm install && npm start", - "test": "node --test tests/frontend-integrity.test.js tests/browser-executable.test.js tests/integration-status.test.js", + "test": "node --test tests/frontend-integrity.test.js tests/browser-executable.test.js tests/integration-status.test.js tests/settings-status-functional.test.js tests/configure-buttons.test.js", "capture:readme": "node scripts/capture-readme-screenshot.js" - }, +}, "keywords": [ "google-maps-scraper", "data-extractor", diff --git a/public/css/style.css b/public/css/style.css index 7127cfa..e1ddc05 100644 --- a/public/css/style.css +++ b/public/css/style.css @@ -2466,4 +2466,45 @@ textarea { background: var(--accent-primary); color: white; transform: scale(1.1); +} + + +/* Integration Readiness Status */ +.integration-status-list { + display: flex; + flex-direction: column; + gap: 10px; +} + +.integration-badge { + display: flex; + align-items: center; + justify-content: space-between; + padding: 10px 14px; + border-radius: var(--radius-md); + border: 1px solid var(--border-color); + background: var(--bg-tertiary); + font-size: 0.9rem; + color: var(--text-secondary); +} + +.integration-badge.configured { + border-color: var(--success); + color: var(--success); +} + +.integration-badge.not-configured { + border-color: var(--warning); + color: var(--text-secondary); +} + +.integration-badge a { + color: var(--accent-primary); + text-decoration: none; + font-weight: 600; + font-size: 0.85rem; +} + +.integration-badge a:hover { + text-decoration: underline; } \ No newline at end of file diff --git a/public/index.html b/public/index.html index 74e808e..2748093 100644 --- a/public/index.html +++ b/public/index.html @@ -98,16 +98,16 @@
-
-

Integration Readiness

-
-

Dashboard

Overview of your extraction campaigns

+
+

Integration Readiness

+
+
@@ -534,6 +534,8 @@

⚙️ Settings

SMTP + @@ -690,8 +692,38 @@

⚙️ Settings

style="padding: 8px 16px; background: var(--bg-tertiary); border: 1px solid var(--border-color); border-radius: 6px; color: var(--text-secondary); cursor: pointer;">🧪 Test Connection
- - + +